diff mbox series

Correct leftover directories from make kselftest

Message ID 20210128033743.77040-2-erik@hollensbe.org
State New
Headers show
Series Correct leftover directories from make kselftest | expand

Commit Message

Erik Hollensbe Jan. 28, 2021, 3:37 a.m. UTC
Here are some directories that are created/filled as a part of the make
kselftest process, but not ignored.

Signed-off-by: Erik Hollensbe <erik@hollensbe.org>
---
 tools/testing/selftests/gpio/.gitignore   | 1 +
 tools/testing/selftests/timens/.gitignore | 1 +
 2 files changed, 2 insertions(+)

Comments

Shuah Khan Feb. 9, 2021, 12:17 a.m. UTC | #1
On 1/27/21 8:37 PM, Erik Hollensbe wrote:
> Here are some directories that are created/filled as a part of the make

> kselftest process, but not ignored.

> 

> Signed-off-by: Erik Hollensbe <erik@hollensbe.org>

> ---

>   tools/testing/selftests/gpio/.gitignore   | 1 +

>   tools/testing/selftests/timens/.gitignore | 1 +

>   2 files changed, 2 insertions(+)

> 

> diff --git a/tools/testing/selftests/gpio/.gitignore b/tools/testing/selftests/gpio/.gitignore

> index 4c69408f3e84..640b5cb4ed4e 100644

> --- a/tools/testing/selftests/gpio/.gitignore

> +++ b/tools/testing/selftests/gpio/.gitignore

> @@ -1,2 +1,3 @@

>   # SPDX-License-Identifier: GPL-2.0-only

>   gpio-mockup-chardev

> +tools-gpio

> diff --git a/tools/testing/selftests/timens/.gitignore b/tools/testing/selftests/timens/.gitignore

> index 2e43851b47c1..95e97d7bc336 100644

> --- a/tools/testing/selftests/timens/.gitignore

> +++ b/tools/testing/selftests/timens/.gitignore

> @@ -7,3 +7,4 @@ procfs

>   timens

>   timer

>   timerfd

> +futex

> 


Thank you for the patch.

Can you split these into two patches? make separate patches for gpio
and timens.

Gives you more practice. :)

thanks,
-- Shuah
Shuah Khan Feb. 9, 2021, 12:28 a.m. UTC | #2
On 2/8/21 5:17 PM, Shuah Khan wrote:
> On 1/27/21 8:37 PM, Erik Hollensbe wrote:

>> Here are some directories that are created/filled as a part of the make

>> kselftest process, but not ignored.

>>

>> Signed-off-by: Erik Hollensbe <erik@hollensbe.org>

>> ---

>>   tools/testing/selftests/gpio/.gitignore   | 1 +

>>   tools/testing/selftests/timens/.gitignore | 1 +

>>   2 files changed, 2 insertions(+)

>>

>> diff --git a/tools/testing/selftests/gpio/.gitignore 

>> b/tools/testing/selftests/gpio/.gitignore

>> index 4c69408f3e84..640b5cb4ed4e 100644

>> --- a/tools/testing/selftests/gpio/.gitignore

>> +++ b/tools/testing/selftests/gpio/.gitignore

>> @@ -1,2 +1,3 @@

>>   # SPDX-License-Identifier: GPL-2.0-only

>>   gpio-mockup-chardev

>> +tools-gpio

>> diff --git a/tools/testing/selftests/timens/.gitignore 

>> b/tools/testing/selftests/timens/.gitignore

>> index 2e43851b47c1..95e97d7bc336 100644

>> --- a/tools/testing/selftests/timens/.gitignore

>> +++ b/tools/testing/selftests/timens/.gitignore

>> @@ -7,3 +7,4 @@ procfs

>>   timens

>>   timer

>>   timerfd

>> +futex

>>

> 

> Thank you for the patch.

> 

> Can you split these into two patches? make separate patches for gpio

> and timens.

> 


Please send me just the gpio patch. I already applied this patch that
fixes timens .gitignore.

https://patchwork.kernel.org/project/linux-kselftest/patch/20201218165651.4538-1-tklauser@distanz.ch/

thanks,
-- Shuah
Erik Hollensbe Feb. 9, 2021, 10:36 a.m. UTC | #3
On Mon Feb 8, 2021 at 4:17 PM PST, Shuah Khan wrote:
> Thank you for the patch.

>

> Can you split these into two patches? make separate patches for gpio

> and timens.

>

> Gives you more practice. :)


I sent one for gpio; under a different email address (this one), it does
reference the initial patch, however.

Hope that works. Thanks for letting me practice! :D

-Erik
diff mbox series

Patch

diff --git a/tools/testing/selftests/gpio/.gitignore b/tools/testing/selftests/gpio/.gitignore
index 4c69408f3e84..640b5cb4ed4e 100644
--- a/tools/testing/selftests/gpio/.gitignore
+++ b/tools/testing/selftests/gpio/.gitignore
@@ -1,2 +1,3 @@ 
 # SPDX-License-Identifier: GPL-2.0-only
 gpio-mockup-chardev
+tools-gpio
diff --git a/tools/testing/selftests/timens/.gitignore b/tools/testing/selftests/timens/.gitignore
index 2e43851b47c1..95e97d7bc336 100644
--- a/tools/testing/selftests/timens/.gitignore
+++ b/tools/testing/selftests/timens/.gitignore
@@ -7,3 +7,4 @@  procfs
 timens
 timer
 timerfd
+futex