arm: Remove redundant config value DEBUG_UART_NETX

Message ID 1410818986-13273-1-git-send-email-daniel.thompson@linaro.org
State New
Headers show

Commit Message

Daniel Thompson Sept. 15, 2014, 10:09 p.m.
Commit 880fa9b6fd73 ("ARM: 8144/1: netx: Migrate DEBUG_LL macros to
shared directory") spuriously introduces an unused config variable,
DEBUG_UART_NETX. Let's remove it.

Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
---
 arch/arm/Kconfig.debug | 1 -
 1 file changed, 1 deletion(-)

Comments

Daniel Thompson Sept. 15, 2014, 10:15 p.m. | #1
On 15/09/14 23:09, Daniel Thompson wrote:
> Commit 880fa9b6fd73 ("ARM: 8144/1: netx: Migrate DEBUG_LL macros to
> shared directory") spuriously introduces an unused config variable,
> DEBUG_UART_NETX. Let's remove it.

Not sure if this is better shared as a new patch (as below) or respun
from the original (as 8144/2)?
Russell King - ARM Linux Sept. 16, 2014, 4:09 p.m. | #2
On Mon, Sep 15, 2014 at 11:09:46PM +0100, Daniel Thompson wrote:
> Commit 880fa9b6fd73 ("ARM: 8144/1: netx: Migrate DEBUG_LL macros to
> shared directory") spuriously introduces an unused config variable,
> DEBUG_UART_NETX. Let's remove it.
> 
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>

I think arm-soc are handing these changes now...

> ---
>  arch/arm/Kconfig.debug | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 537dd04..b6ec25a 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -450,7 +450,6 @@ choice
>  	config DEBUG_NETX_UART
>  		bool "Kernel low-level debugging messages via NetX UART"
>  		depends on ARCH_NETX
> -		select DEBUG_UART_NETX
>  		help
>  		  Say Y here if you want kernel low-level debugging support
>  		  on Hilscher NetX based platforms.
> -- 
> 1.9.3
>
Russell King - ARM Linux Sept. 16, 2014, 4:10 p.m. | #3
On Mon, Sep 15, 2014 at 11:15:05PM +0100, Daniel Thompson wrote:
> On 15/09/14 23:09, Daniel Thompson wrote:
> > Commit 880fa9b6fd73 ("ARM: 8144/1: netx: Migrate DEBUG_LL macros to
> > shared directory") spuriously introduces an unused config variable,
> > DEBUG_UART_NETX. Let's remove it.
> 
> Not sure if this is better shared as a new patch (as below) or respun
> from the original (as 8144/2)?

Oh, it's a patch I have... in which case, please respin this patch, and
throw the updated patch into the patch system.  Thanks.

Patch

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 537dd04..b6ec25a 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -450,7 +450,6 @@  choice
 	config DEBUG_NETX_UART
 		bool "Kernel low-level debugging messages via NetX UART"
 		depends on ARCH_NETX
-		select DEBUG_UART_NETX
 		help
 		  Say Y here if you want kernel low-level debugging support
 		  on Hilscher NetX based platforms.