diff mbox series

i2c: busses: Replace spin_lock_irqsave with spin_lock in hard IRQ

Message ID 1612781317-51815-1-git-send-email-liweihang@huawei.com
State Accepted
Commit bb3fe9ff5306d058af952f689f22448af286def8
Headers show
Series i2c: busses: Replace spin_lock_irqsave with spin_lock in hard IRQ | expand

Commit Message

Weihang Li Feb. 8, 2021, 10:48 a.m. UTC 
There is no need to do irqsave and irqrestore in context of hard IRQ.

Cc: Baruch Siach <baruch@tkos.co.il>
Cc: Paul Cercueil <paul@crapouillou.net>
Signed-off-by: Weihang Li <liweihang@huawei.com>
---
 drivers/i2c/busses/i2c-digicolor.c | 5 ++---
 drivers/i2c/busses/i2c-jz4780.c    | 5 ++---
 2 files changed, 4 insertions(+), 6 deletions(-)

Comments

Wolfram Sang Feb. 12, 2021, 7:42 a.m. UTC | #1 
On Mon, Feb 08, 2021 at 06:48:37PM +0800, Weihang Li wrote:
> There is no need to do irqsave and irqrestore in context of hard IRQ.

> 

> Cc: Baruch Siach <baruch@tkos.co.il>

> Cc: Paul Cercueil <paul@crapouillou.net>

> Signed-off-by: Weihang Li <liweihang@huawei.com>


Applied to for-next, thanks!
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-digicolor.c b/drivers/i2c/busses/i2c-digicolor.c
index f67639d..60c838c 100644
--- a/drivers/i2c/busses/i2c-digicolor.c
+++ b/drivers/i2c/busses/i2c-digicolor.c
@@ -160,12 +160,11 @@  static irqreturn_t dc_i2c_irq(int irq, void *dev_id)
 {
 	struct dc_i2c *i2c = dev_id;
 	int cmd_status = dc_i2c_cmd_status(i2c);
-	unsigned long flags;
 	u8 addr_cmd;
 
 	writeb_relaxed(1, i2c->regs + II_INTFLAG_CLEAR);
 
-	spin_lock_irqsave(&i2c->lock, flags);
+	spin_lock(&i2c->lock);
 
 	if (cmd_status == II_CMD_STATUS_ACK_BAD
 	    || cmd_status == II_CMD_STATUS_ABORT) {
@@ -207,7 +206,7 @@  static irqreturn_t dc_i2c_irq(int irq, void *dev_id)
 	}
 
 out:
-	spin_unlock_irqrestore(&i2c->lock, flags);
+	spin_unlock(&i2c->lock);
 	return IRQ_HANDLED;
 }
 
diff --git a/drivers/i2c/busses/i2c-jz4780.c b/drivers/i2c/busses/i2c-jz4780.c
index cb4a25e..8509c5f 100644
--- a/drivers/i2c/busses/i2c-jz4780.c
+++ b/drivers/i2c/busses/i2c-jz4780.c
@@ -437,9 +437,8 @@  static irqreturn_t jz4780_i2c_irq(int irqno, void *dev_id)
 	unsigned short intst;
 	unsigned short intmsk;
 	struct jz4780_i2c *i2c = dev_id;
-	unsigned long flags;
 
-	spin_lock_irqsave(&i2c->lock, flags);
+	spin_lock(&i2c->lock);
 	intmsk = jz4780_i2c_readw(i2c, JZ4780_I2C_INTM);
 	intst = jz4780_i2c_readw(i2c, JZ4780_I2C_INTST);
 
@@ -551,7 +550,7 @@  static irqreturn_t jz4780_i2c_irq(int irqno, void *dev_id)
 	}
 
 done:
-	spin_unlock_irqrestore(&i2c->lock, flags);
+	spin_unlock(&i2c->lock);
 	return IRQ_HANDLED;
 }