diff mbox series

[for-next,22/32] scsi: ncr53c8xx: Replace spin_lock_irqsave with spin_lock in hard IRQ

Message ID 1612697823-8073-23-git-send-email-tanxiaofei@huawei.com
State New
Headers show
Series spin lock usage optimization for SCSI drivers | expand

Commit Message

Xiaofei Tan Feb. 7, 2021, 11:36 a.m. UTC 
It is redundant to do irqsave and irqrestore in hardIRQ context, where
it has been in a irq-disabled context.

Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
---
 drivers/scsi/ncr53c8xx.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/drivers/scsi/ncr53c8xx.c b/drivers/scsi/ncr53c8xx.c
index c76e9f0..84e0bb6 100644
--- a/drivers/scsi/ncr53c8xx.c
+++ b/drivers/scsi/ncr53c8xx.c
@@ -8069,7 +8069,6 @@  static DEF_SCSI_QCMD(ncr53c8xx_queue_command)
 
 irqreturn_t ncr53c8xx_intr(int irq, void *dev_id)
 {
-     unsigned long flags;
      struct Scsi_Host *shost = (struct Scsi_Host *)dev_id;
      struct host_data *host_data = (struct host_data *)shost->hostdata;
      struct ncb *np = host_data->ncb;
@@ -8081,11 +8080,11 @@  irqreturn_t ncr53c8xx_intr(int irq, void *dev_id)
 
      if (DEBUG_FLAGS & DEBUG_TINY) printk ("[");
 
-     spin_lock_irqsave(&np->smp_lock, flags);
+	spin_lock(&np->smp_lock);
      ncr_exception(np);
      done_list     = np->done_list;
      np->done_list = NULL;
-     spin_unlock_irqrestore(&np->smp_lock, flags);
+	spin_unlock(&np->smp_lock);
 
      if (DEBUG_FLAGS & DEBUG_TINY) printk ("]\n");