From patchwork Tue Aug 30 15:04:41 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Stubbs X-Patchwork-Id: 3799 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 8009A23FA3 for ; Tue, 30 Aug 2011 15:04:48 +0000 (UTC) Received: from mail-ey0-f170.google.com (mail-ey0-f170.google.com [209.85.215.170]) by fiordland.canonical.com (Postfix) with ESMTP id 6DAA4A184FF for ; Tue, 30 Aug 2011 15:04:48 +0000 (UTC) Received: by eyd10 with SMTP id 10so1159390eyd.29 for ; Tue, 30 Aug 2011 08:04:48 -0700 (PDT) Received: by 10.223.76.201 with SMTP id d9mr9023644fak.119.1314716688258; Tue, 30 Aug 2011 08:04:48 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.152.11.8 with SMTP id m8cs145045lab; Tue, 30 Aug 2011 08:04:47 -0700 (PDT) Received: by 10.216.137.24 with SMTP id x24mr836752wei.114.1314716687156; Tue, 30 Aug 2011 08:04:47 -0700 (PDT) Received: from mail-ww0-f42.google.com (mail-ww0-f42.google.com [74.125.82.42]) by mx.google.com with ESMTPS id i18si5346657wed.83.2011.08.30.08.04.46 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 30 Aug 2011 08:04:47 -0700 (PDT) Received-SPF: pass (google.com: domain of andrew.stubbs@gmail.com designates 74.125.82.42 as permitted sender) client-ip=74.125.82.42; Authentication-Results: mx.google.com; spf=pass (google.com: domain of andrew.stubbs@gmail.com designates 74.125.82.42 as permitted sender) smtp.mail=andrew.stubbs@gmail.com; dkim=pass (test mode) header.i=@gmail.com Received: by wwe5 with SMTP id 5so3498059wwe.1 for ; Tue, 30 Aug 2011 08:04:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type; bh=68LLAtbFHkk72jABjIUdR+uuRsIVVgV8SgbeRqg2x3g=; b=McRUH2T9GlHmKtwBOx/5i/HHM0Z35mBPb4ZwTbF2xBQf/X+kFhd3ijIzCSMrzsy/L8 uCbUsFrTzRdi0zR6v4+thYuARRPW56dFiwtxl3r/P4CgWzaBEYRptQOYUiqOFraeMwho JwRzh30uOlO7B03WQU5B24Jd2r1Y5AsbTGBec= Received: by 10.216.174.80 with SMTP id w58mr850396wel.84.1314716686891; Tue, 30 Aug 2011 08:04:46 -0700 (PDT) Received: from [192.168.0.104] (cpc2-hawk4-0-0-cust828.aztw.cable.virginmedia.com [82.32.123.61]) by mx.google.com with ESMTPS id n20sm4699689wbh.33.2011.08.30.08.04.43 (version=SSLv3 cipher=OTHER); Tue, 30 Aug 2011 08:04:45 -0700 (PDT) Message-ID: <4E5CFC09.20906@codesourcery.com> Date: Tue, 30 Aug 2011 16:04:41 +0100 From: Andrew Stubbs User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110812 Thunderbird/6.0 MIME-Version: 1.0 To: gcc-patches@gcc.gnu.org CC: Richard Earnshaw , patches@linaro.org Subject: Re: [PATCH][ARM] Thumb2 replicated constants References: <4DB013B7.4090504@codesourcery.com> <1304677098.5165.7.camel@e102346-lin.cambridge.arm.com> <4DC814EA.4070608@codesourcery.com> <4E576F60.2000100@codesourcery.com> <4E5CF46F.5090809@codesourcery.com> In-Reply-To: <4E5CF46F.5090809@codesourcery.com> On 30/08/11 15:32, Andrew Stubbs wrote: > On 26/08/11 11:03, Andrew Stubbs wrote: >> There was a bug I found in final testing, so this has been delayed >> somewhat. >> >> I've just committed this version. There are a few minor changes to the >> way negative/inverted constants are generated. > > Bernd found another bug whist testing for arm. Apparently there was a > bug that didn't show up in my thumb tests, although I have no clue why? > > Anyway, fixed thusly and committed as obvious (and urgent). And also there was an issue build with -Werror ... I'm not having much luck at the moment. :( Anyway, likewise fixed and committed as obvious. Andrew 2011-08-30 Andrew Stubbs gcc/ * config/arm/arm.c (optimal_immediate_sequence_1): Make b1, b2, b3 and b4 unsigned. --- a/gcc/config/arm/arm.c +++ b/gcc/config/arm/arm.c @@ -2624,7 +2624,7 @@ optimal_immediate_sequence_1 (enum rtx_code code, unsigned HOST_WIDE_INT val, do { int end; - int b1, b2, b3, b4; + unsigned int b1, b2, b3, b4; unsigned HOST_WIDE_INT result; int loc;