diff mbox series

[1/2] sbsa-ref: remove cortex-a53 from list of supported cpus

Message ID 20210211123638.1820482-1-marcin.juszkiewicz@linaro.org
State Superseded
Headers show
Series [1/2] sbsa-ref: remove cortex-a53 from list of supported cpus | expand

Commit Message

Marcin Juszkiewicz Feb. 11, 2021, 12:36 p.m. UTC
Cortex-A53 supports 40bits of address space. sbsa-ref's memory starts
above this limit.

Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>

---
 hw/arm/sbsa-ref.c | 1 -
 1 file changed, 1 deletion(-)

-- 
2.29.2

Comments

Philippe Mathieu-Daudé Feb. 11, 2021, 1:44 p.m. UTC | #1
Hi Marcin,

This is v2.

Please don't post new patch series as subthread in another one.

On 2/11/21 1:36 PM, Marcin Juszkiewicz wrote:
> Cortex-A53 supports 40bits of address space. sbsa-ref's memory starts

> above this limit.

> 

> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>

> ---

>  hw/arm/sbsa-ref.c | 1 -

>  1 file changed, 1 deletion(-)


Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Leif Lindholm Feb. 11, 2021, 2:16 p.m. UTC | #2
On Thu, Feb 11, 2021 at 13:36:37 +0100, Marcin Juszkiewicz wrote:
> Cortex-A53 supports 40bits of address space. sbsa-ref's memory starts

> above this limit.

> 

> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>


Acked-by: Leif Lindholm <leif@nuviainc.com>


> ---

>  hw/arm/sbsa-ref.c | 1 -

>  1 file changed, 1 deletion(-)

> 

> diff --git hw/arm/sbsa-ref.c hw/arm/sbsa-ref.c

> index 9f70735153..276243d122 100644

> --- hw/arm/sbsa-ref.c

> +++ hw/arm/sbsa-ref.c

> @@ -145,7 +145,6 @@ static const int sbsa_ref_irqmap[] = {

>  };

>  

>  static const char * const valid_cpus[] = {

> -    ARM_CPU_TYPE_NAME("cortex-a53"),

>      ARM_CPU_TYPE_NAME("cortex-a57"),

>      ARM_CPU_TYPE_NAME("cortex-a72"),

>  };

> -- 

> 2.29.2

>
Peter Maydell Feb. 16, 2021, 2:23 p.m. UTC | #3
On Thu, 11 Feb 2021 at 12:36, Marcin Juszkiewicz
<marcin.juszkiewicz@linaro.org> wrote:
>

> Cortex-A53 supports 40bits of address space. sbsa-ref's memory starts

> above this limit.

>

> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>


Hi; could you resend your patches in the right format, please?
 * with a cover letter if it's a multi-patch series
 * with the cover letter not a reply-to or follow-up to any
   existing email
 * with each patch in the series being a follow-up to its cover letter
 * with a suitable '[PATCH v3]' in the subject if this is v3 of
   a patch(series), etc
 * with any accumulated reviewed-by, acked-by, etc tags

Otherwise it's pretty confusing to try to fish the right version
out of the mailing list; in particular the automated patch handling
tools and scripts have got confused by your patches here.

https://wiki.qemu.org/Contribute/SubmitAPatch has some notes.

thanks
-- PMM
diff mbox series

Patch

diff --git hw/arm/sbsa-ref.c hw/arm/sbsa-ref.c
index 9f70735153..276243d122 100644
--- hw/arm/sbsa-ref.c
+++ hw/arm/sbsa-ref.c
@@ -145,7 +145,6 @@  static const int sbsa_ref_irqmap[] = {
 };
 
 static const char * const valid_cpus[] = {
-    ARM_CPU_TYPE_NAME("cortex-a53"),
     ARM_CPU_TYPE_NAME("cortex-a57"),
     ARM_CPU_TYPE_NAME("cortex-a72"),
 };