diff mbox series

mmc: dw_mmc: Drop redundant call to ->card_event callback

Message ID 20210212132406.237270-1-ulf.hansson@linaro.org
State New
Headers show
Series mmc: dw_mmc: Drop redundant call to ->card_event callback | expand

Commit Message

Ulf Hansson Feb. 12, 2021, 1:24 p.m. UTC
The ->card_event callback isn't being used by any of the dw_mmc variants.
It's likely a leftover from an earlier change, hence let's just drop the
redundant call to it.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

---
 drivers/mmc/host/dw_mmc.c | 2 --
 1 file changed, 2 deletions(-)

-- 
2.25.1

Comments

Jaehoon Chung Feb. 18, 2021, 12:23 a.m. UTC | #1
On 2/12/21 10:24 PM, Ulf Hansson wrote:
> The ->card_event callback isn't being used by any of the dw_mmc variants.

> It's likely a leftover from an earlier change, hence let's just drop the

> redundant call to it.

> 

> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>


Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>


Best Regards
Jaehoon Chung

> ---

>  drivers/mmc/host/dw_mmc.c | 2 --

>  1 file changed, 2 deletions(-)

> 

> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c

> index a5244435556b..df327c89cec5 100644

> --- a/drivers/mmc/host/dw_mmc.c

> +++ b/drivers/mmc/host/dw_mmc.c

> @@ -2606,8 +2606,6 @@ static void dw_mci_handle_cd(struct dw_mci *host)

>  {

>  	struct dw_mci_slot *slot = host->slot;

>  

> -	if (slot->mmc->ops->card_event)

> -		slot->mmc->ops->card_event(slot->mmc);

>  	mmc_detect_change(slot->mmc,

>  		msecs_to_jiffies(host->pdata->detect_delay_ms));

>  }

>
diff mbox series

Patch

diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index a5244435556b..df327c89cec5 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -2606,8 +2606,6 @@  static void dw_mci_handle_cd(struct dw_mci *host)
 {
 	struct dw_mci_slot *slot = host->slot;
 
-	if (slot->mmc->ops->card_event)
-		slot->mmc->ops->card_event(slot->mmc);
 	mmc_detect_change(slot->mmc,
 		msecs_to_jiffies(host->pdata->detect_delay_ms));
 }