diff mbox series

[alsa-ucm-conf,1/2] codecs/rt5672: Move +12dB input boost from 'STO1 ADC Boost Gain' to 'ADC Capture Volume'

Message ID 20210217143436.74209-1-hdegoede@redhat.com
State New
Headers show
Series [alsa-ucm-conf,1/2] codecs/rt5672: Move +12dB input boost from 'STO1 ADC Boost Gain' to 'ADC Capture Volume' | expand

Commit Message

Hans de Goede Feb. 17, 2021, 2:34 p.m. UTC
Both the 'STO1 ADC Boost Gain' and the 'ADC Capture Volume' controls are
digital and the 'ADC Capture Volume' control goes up to +30dB.

When adding hw-volume-control support adding the +12dB boost gain on to of
the max +30dB of 'ADC Capture Volume' is a bit too much.

So move the +12dB from the 'STO1 ADC Boost Gain' control to the
'ADC Capture Volume' control.

This way we keep the same setting for userspace which does not support
hw-volume-control, while getting a better range when we start using
'ADC Capture Volume' as hw-volume-control.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 ucm2/codecs/rt5672/EnableSeq.conf | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

Comments

Hans de Goede March 13, 2021, 3:47 p.m. UTC | #1
Hi,

On 2/17/21 3:34 PM, Hans de Goede wrote:
> Both the 'STO1 ADC Boost Gain' and the 'ADC Capture Volume' controls are
> digital and the 'ADC Capture Volume' control goes up to +30dB.
> 
> When adding hw-volume-control support adding the +12dB boost gain on to of
> the max +30dB of 'ADC Capture Volume' is a bit too much.
> 
> So move the +12dB from the 'STO1 ADC Boost Gain' control to the
> 'ADC Capture Volume' control.
> 
> This way we keep the same setting for userspace which does not support
> hw-volume-control, while getting a better range when we start using
> 'ADC Capture Volume' as hw-volume-control.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Ping? This series seems to have fallen through the cracks, AFAIK
there is nothing blocking this series from getting merged.

If you want a resend let me know and I'll resubmit.

Regards,

Hans


> ---
>  ucm2/codecs/rt5672/EnableSeq.conf | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/ucm2/codecs/rt5672/EnableSeq.conf b/ucm2/codecs/rt5672/EnableSeq.conf
> index ddfb1c7..e373275 100644
> --- a/ucm2/codecs/rt5672/EnableSeq.conf
> +++ b/ucm2/codecs/rt5672/EnableSeq.conf
> @@ -26,14 +26,13 @@ EnableSequence [
>  	# cset "name='LOUT MIX OUTMIX L Switch' on"
>  	# cset "name='LOUT MIX OUTMIX R Switch' on"
>  
> -	# 47=0dB, 0.375 dB/step
> -	cset "name='ADC Capture Volume' 47"
> +	# Both the DMICs and the headset mic (even with the 20dB boost below)
> +	# are quite soft, set the default capture volume to +12dB
> +	# 47=0dB, 0.375dB/step, 79=+12dB
> +	cset "name='ADC Capture Volume' 79"
>  	cset "name='ADC Capture Switch' on"
> -
> -	# Both the DMICs and the headset mic (even with the 20 dB boost below)
> -	# are quite soft, set the ADC Boost gain (range 0-3) to 1 = 12 dB the
> -	# next step is 24 dB which is a bit too much
> -	cset "name='STO1 ADC Boost Gain Volume' 1"
> +	# 0=0dB
> +	cset "name='STO1 ADC Boost Gain Volume' 0"
>  
>  	# Headset mic is quite soft, boost it a bit, 1 = 20dB which is the first
>  	# available boost step
>
Jaroslav Kysela March 13, 2021, 3:56 p.m. UTC | #2
Dne 13. 03. 21 v 16:47 Hans de Goede napsal(a):
> Hi,
> 
> On 2/17/21 3:34 PM, Hans de Goede wrote:
>> Both the 'STO1 ADC Boost Gain' and the 'ADC Capture Volume' controls are
>> digital and the 'ADC Capture Volume' control goes up to +30dB.
>>
>> When adding hw-volume-control support adding the +12dB boost gain on to of
>> the max +30dB of 'ADC Capture Volume' is a bit too much.
>>
>> So move the +12dB from the 'STO1 ADC Boost Gain' control to the
>> 'ADC Capture Volume' control.
>>
>> This way we keep the same setting for userspace which does not support
>> hw-volume-control, while getting a better range when we start using
>> 'ADC Capture Volume' as hw-volume-control.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> 
> Ping? This series seems to have fallen through the cracks, AFAIK
> there is nothing blocking this series from getting merged.

Yep, it was somehow lost on my side. It's merged now. Thank you.

				Jaroslav
diff mbox series

Patch

diff --git a/ucm2/codecs/rt5672/EnableSeq.conf b/ucm2/codecs/rt5672/EnableSeq.conf
index ddfb1c7..e373275 100644
--- a/ucm2/codecs/rt5672/EnableSeq.conf
+++ b/ucm2/codecs/rt5672/EnableSeq.conf
@@ -26,14 +26,13 @@  EnableSequence [
 	# cset "name='LOUT MIX OUTMIX L Switch' on"
 	# cset "name='LOUT MIX OUTMIX R Switch' on"
 
-	# 47=0dB, 0.375 dB/step
-	cset "name='ADC Capture Volume' 47"
+	# Both the DMICs and the headset mic (even with the 20dB boost below)
+	# are quite soft, set the default capture volume to +12dB
+	# 47=0dB, 0.375dB/step, 79=+12dB
+	cset "name='ADC Capture Volume' 79"
 	cset "name='ADC Capture Switch' on"
-
-	# Both the DMICs and the headset mic (even with the 20 dB boost below)
-	# are quite soft, set the ADC Boost gain (range 0-3) to 1 = 12 dB the
-	# next step is 24 dB which is a bit too much
-	cset "name='STO1 ADC Boost Gain Volume' 1"
+	# 0=0dB
+	cset "name='STO1 ADC Boost Gain Volume' 0"
 
 	# Headset mic is quite soft, boost it a bit, 1 = 20dB which is the first
 	# available boost step