diff mbox

[edk2] Add .gitignore

Message ID 1412782427-7670-1-git-send-email-leif.lindholm@linaro.org
State New
Headers show

Commit Message

Leif Lindholm Oct. 8, 2014, 3:33 p.m. UTC
From: Ryan Harkin <ryan.harkin@linaro.org>

From: Ryan Harkin <ryan.harkin@linaro.org>

While edk2 is still maintained in SVN, Many edk2 developers use git
for their main workflow, using the official mirrors.
This .gitignore file prevents files generated as part of the build
from cluttering up "git status" output.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ryan Harkin <ryan.harkin@linaro.org>
[removed Linaro-specific bits]
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
 .gitignore |   20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 .gitignore

Comments

Laszlo Ersek Oct. 8, 2014, 4:56 p.m. UTC | #1
On 10/08/14 17:33, Leif Lindholm wrote:
> From: Ryan Harkin <ryan.harkin@linaro.org>
> 
> From: Ryan Harkin <ryan.harkin@linaro.org>
> 
> While edk2 is still maintained in SVN, Many edk2 developers use git
> for their main workflow, using the official mirrors.
> This .gitignore file prevents files generated as part of the build
> from cluttering up "git status" output.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ryan Harkin <ryan.harkin@linaro.org>
> [removed Linaro-specific bits]
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
>  .gitignore |   20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>  create mode 100644 .gitignore
> 
> diff --git a/.gitignore b/.gitignore
> new file mode 100644
> index 0000000..8b6147b
> --- /dev/null
> +++ b/.gitignore
> @@ -0,0 +1,20 @@
> +*.d
> +*.o
> +*.pyc
> +BaseTools/Source/C/VfrCompile/EfiVfrParser.cpp
> +BaseTools/Source/C/VfrCompile/EfiVfrParser.h
> +BaseTools/Source/C/VfrCompile/Pccts/antlr/antlr
> +BaseTools/Source/C/VfrCompile/Pccts/dlg/dlg
> +BaseTools/Source/C/VfrCompile/VfrLexer.cpp
> +BaseTools/Source/C/VfrCompile/VfrLexer.h
> +BaseTools/Source/C/VfrCompile/VfrParser.dlg
> +BaseTools/Source/C/VfrCompile/VfrSyntax.cpp
> +BaseTools/Source/C/VfrCompile/VfrTokens.h
> +BaseTools/Source/C/bin/
> +BaseTools/Source/C/libs/
> +Build/
> +Conf/.cache/
> +Conf/BuildEnv.sh
> +Conf/build_rule.txt
> +Conf/target.txt
> +Conf/tools_def.txt
> 

Please consider adding "tags" as well.

Thanks
Laszlo

------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
Leif Lindholm Oct. 8, 2014, 9:56 p.m. UTC | #2
On 8 October 2014 17:56, Laszlo Ersek <lersek@redhat.com> wrote:
> Please consider adding "tags" as well.

Good call.
Not added as it isn't a build artefact as such, but if people would
accept taking this patch to begin with, I agree that tags would be a
useful addition.

Regards,

Leif

------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
Laszlo Ersek Oct. 9, 2014, 11:46 a.m. UTC | #3
On 10/08/14 23:56, Leif Lindholm wrote:
> On 8 October 2014 17:56, Laszlo Ersek <lersek@redhat.com> wrote:
>> Please consider adding "tags" as well.
> 
> Good call.
> Not added as it isn't a build artefact as such, but if people would
> accept taking this patch to begin with, I agree that tags would be a
> useful addition.

"Who maintains the root directory of the tree" is a good question. I
don't know. But, if you intersect that set with the set of people that
care about .gitignore, I bet you end up with {}.

On the other hand, I doubt a .gitignore file in the root dir would
*bother* SVN users (we already have some SVN meta-files in the tree, and
git users aren't complaining). So, please resubmit with "tags" added,
then I'll respond with my R-b, and I'll commit the patch as well.

Let's expedite this open source thing a bit. At worst I lose my SVN
commit rights. Nothing ventured, nothing gained! :)

Another request I have -- please test if the .gitignore file works with
*CRLF* (ie. not just LF) line endings as well (that is, git continues to
recognize the pathnames / patterns in it). Submitting it as such would
be friendly because Windows users could at least open the file with
their editors. If it only works with LFs, then we shall commit it with LFs.

Thanks!
Laszlo

------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
Jordan Justen Oct. 9, 2014, 12:50 p.m. UTC | #4
On Wed, Oct 8, 2014 at 8:33 AM, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> From: Ryan Harkin <ryan.harkin@linaro.org>
>
> From: Ryan Harkin <ryan.harkin@linaro.org>
>
> While edk2 is still maintained in SVN, Many edk2 developers use git
> for their main workflow, using the official mirrors.
> This .gitignore file prevents files generated as part of the build
> from cluttering up "git status" output.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ryan Harkin <ryan.harkin@linaro.org>
> [removed Linaro-specific bits]
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
>  .gitignore |   20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>  create mode 100644 .gitignore
>
> diff --git a/.gitignore b/.gitignore
> new file mode 100644
> index 0000000..8b6147b
> --- /dev/null
> +++ b/.gitignore
> @@ -0,0 +1,20 @@
> +*.d
> +*.o
> +*.pyc
> +BaseTools/Source/C/VfrCompile/EfiVfrParser.cpp
> +BaseTools/Source/C/VfrCompile/EfiVfrParser.h
> +BaseTools/Source/C/VfrCompile/Pccts/antlr/antlr
> +BaseTools/Source/C/VfrCompile/Pccts/dlg/dlg
> +BaseTools/Source/C/VfrCompile/VfrLexer.cpp
> +BaseTools/Source/C/VfrCompile/VfrLexer.h
> +BaseTools/Source/C/VfrCompile/VfrParser.dlg
> +BaseTools/Source/C/VfrCompile/VfrSyntax.cpp
> +BaseTools/Source/C/VfrCompile/VfrTokens.h
> +BaseTools/Source/C/bin/
> +BaseTools/Source/C/libs/

How about BaseTools/.gitignore for these? (I guess it is possible that
someone might want to use git submodule or repo to compose their
tree.)

> +Build/
> +Conf/.cache/
> +Conf/BuildEnv.sh
> +Conf/build_rule.txt
> +Conf/target.txt
> +Conf/tools_def.txt

What about Conf/.gitignore with '*'?

-Jordan

------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
Laszlo Ersek Oct. 9, 2014, 12:58 p.m. UTC | #5
On 10/09/14 14:50, Jordan Justen wrote:
> On Wed, Oct 8, 2014 at 8:33 AM, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>> From: Ryan Harkin <ryan.harkin@linaro.org>
>>
>> From: Ryan Harkin <ryan.harkin@linaro.org>
>>
>> While edk2 is still maintained in SVN, Many edk2 developers use git
>> for their main workflow, using the official mirrors.
>> This .gitignore file prevents files generated as part of the build
>> from cluttering up "git status" output.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Ryan Harkin <ryan.harkin@linaro.org>
>> [removed Linaro-specific bits]
>> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>> ---
>>  .gitignore |   20 ++++++++++++++++++++
>>  1 file changed, 20 insertions(+)
>>  create mode 100644 .gitignore
>>
>> diff --git a/.gitignore b/.gitignore
>> new file mode 100644
>> index 0000000..8b6147b
>> --- /dev/null
>> +++ b/.gitignore
>> @@ -0,0 +1,20 @@
>> +*.d
>> +*.o
>> +*.pyc
>> +BaseTools/Source/C/VfrCompile/EfiVfrParser.cpp
>> +BaseTools/Source/C/VfrCompile/EfiVfrParser.h
>> +BaseTools/Source/C/VfrCompile/Pccts/antlr/antlr
>> +BaseTools/Source/C/VfrCompile/Pccts/dlg/dlg
>> +BaseTools/Source/C/VfrCompile/VfrLexer.cpp
>> +BaseTools/Source/C/VfrCompile/VfrLexer.h
>> +BaseTools/Source/C/VfrCompile/VfrParser.dlg
>> +BaseTools/Source/C/VfrCompile/VfrSyntax.cpp
>> +BaseTools/Source/C/VfrCompile/VfrTokens.h
>> +BaseTools/Source/C/bin/
>> +BaseTools/Source/C/libs/
> 
> How about BaseTools/.gitignore for these? (I guess it is possible that
> someone might want to use git submodule or repo to compose their
> tree.)
> 
>> +Build/
>> +Conf/.cache/
>> +Conf/BuildEnv.sh
>> +Conf/build_rule.txt
>> +Conf/target.txt
>> +Conf/tools_def.txt
> 
> What about Conf/.gitignore with '*'?

"Conf/ReadMe.txt" should not be ignored.

Thanks
Laszlo


------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
Jordan Justen Oct. 9, 2014, 1:23 p.m. UTC | #6
On Thu, Oct 9, 2014 at 5:58 AM, Laszlo Ersek <lersek@redhat.com> wrote:
> On 10/09/14 14:50, Jordan Justen wrote:
>> On Wed, Oct 8, 2014 at 8:33 AM, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>>> From: Ryan Harkin <ryan.harkin@linaro.org>
>>>
>>> From: Ryan Harkin <ryan.harkin@linaro.org>
>>>
>>> While edk2 is still maintained in SVN, Many edk2 developers use git
>>> for their main workflow, using the official mirrors.
>>> This .gitignore file prevents files generated as part of the build
>>> from cluttering up "git status" output.
>>>
>>> Contributed-under: TianoCore Contribution Agreement 1.0
>>> Signed-off-by: Ryan Harkin <ryan.harkin@linaro.org>
>>> [removed Linaro-specific bits]
>>> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>>> ---
>>>  .gitignore |   20 ++++++++++++++++++++
>>>  1 file changed, 20 insertions(+)
>>>  create mode 100644 .gitignore
>>>
>>> diff --git a/.gitignore b/.gitignore
>>> new file mode 100644
>>> index 0000000..8b6147b
>>> --- /dev/null
>>> +++ b/.gitignore
>>> @@ -0,0 +1,20 @@
>>> +*.d
>>> +*.o
>>> +*.pyc
>>> +BaseTools/Source/C/VfrCompile/EfiVfrParser.cpp
>>> +BaseTools/Source/C/VfrCompile/EfiVfrParser.h
>>> +BaseTools/Source/C/VfrCompile/Pccts/antlr/antlr
>>> +BaseTools/Source/C/VfrCompile/Pccts/dlg/dlg
>>> +BaseTools/Source/C/VfrCompile/VfrLexer.cpp
>>> +BaseTools/Source/C/VfrCompile/VfrLexer.h
>>> +BaseTools/Source/C/VfrCompile/VfrParser.dlg
>>> +BaseTools/Source/C/VfrCompile/VfrSyntax.cpp
>>> +BaseTools/Source/C/VfrCompile/VfrTokens.h
>>> +BaseTools/Source/C/bin/
>>> +BaseTools/Source/C/libs/
>>
>> How about BaseTools/.gitignore for these? (I guess it is possible that
>> someone might want to use git submodule or repo to compose their
>> tree.)
>>
>>> +Build/
>>> +Conf/.cache/
>>> +Conf/BuildEnv.sh
>>> +Conf/build_rule.txt
>>> +Conf/target.txt
>>> +Conf/tools_def.txt
>>
>> What about Conf/.gitignore with '*'?
>
> "Conf/ReadMe.txt" should not be ignored.

This should not prevent git from showing that ReadMe.txt was modified.
(Not that it ever changes.)

-Jordan

------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
diff mbox

Patch

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000..8b6147b
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,20 @@ 
+*.d
+*.o
+*.pyc
+BaseTools/Source/C/VfrCompile/EfiVfrParser.cpp
+BaseTools/Source/C/VfrCompile/EfiVfrParser.h
+BaseTools/Source/C/VfrCompile/Pccts/antlr/antlr
+BaseTools/Source/C/VfrCompile/Pccts/dlg/dlg
+BaseTools/Source/C/VfrCompile/VfrLexer.cpp
+BaseTools/Source/C/VfrCompile/VfrLexer.h
+BaseTools/Source/C/VfrCompile/VfrParser.dlg
+BaseTools/Source/C/VfrCompile/VfrSyntax.cpp
+BaseTools/Source/C/VfrCompile/VfrTokens.h
+BaseTools/Source/C/bin/
+BaseTools/Source/C/libs/
+Build/
+Conf/.cache/
+Conf/BuildEnv.sh
+Conf/build_rule.txt
+Conf/target.txt
+Conf/tools_def.txt