| Message ID | 20210222213306.22654-4-pierre-louis.bossart@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | 0587e83c5d8bc09af005bd736234b480a8fd66f2 |
| Headers | show |
| Series | ASoC: samsung: remove cppcheck warnings | expand |
On 22.02.2021 22:33, Pierre-Louis Bossart wrote: > cppcheck warning: > > sound/soc/samsung/s3c24xx_simtec.c:191:7: style: Variable 'ret' is > assigned a value that is never used. [unreadVariable] > ret = snd_soc_dai_set_clkdiv(cpu_dai, S3C24XX_DIV_PRESCALER, > ^ > > Looking at the code, it's not clear why the return value is checked in > the two other cases but not here, so mirror the behavior and add a > check. > > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
diff --git a/sound/soc/samsung/s3c24xx_simtec.c b/sound/soc/samsung/s3c24xx_simtec.c index 3cddd11344ac..81a29d12c57d 100644 --- a/sound/soc/samsung/s3c24xx_simtec.c +++ b/sound/soc/samsung/s3c24xx_simtec.c @@ -190,6 +190,11 @@ static int simtec_hw_params(struct snd_pcm_substream *substream, ret = snd_soc_dai_set_clkdiv(cpu_dai, S3C24XX_DIV_PRESCALER, cdclk_scale); + if (ret) { + pr_err("%s: failed to set clock div\n", + __func__); + return ret; + } } return 0;
cppcheck warning: sound/soc/samsung/s3c24xx_simtec.c:191:7: style: Variable 'ret' is assigned a value that is never used. [unreadVariable] ret = snd_soc_dai_set_clkdiv(cpu_dai, S3C24XX_DIV_PRESCALER, ^ Looking at the code, it's not clear why the return value is checked in the two other cases but not here, so mirror the behavior and add a check. Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> --- sound/soc/samsung/s3c24xx_simtec.c | 5 +++++ 1 file changed, 5 insertions(+)