thermal: amlogic: Omit superfluous error message in amlogic_thermal_probe()

Message ID 20210222061105.6008-1-tangbin@cmss.chinamobile.com
State New
Headers show
Series
  • thermal: amlogic: Omit superfluous error message in amlogic_thermal_probe()
Related show

Commit Message

Tang Bin Feb. 22, 2021, 6:11 a.m.
The function devm_platform_ioremap_resource has already contains error
message, so remove the redundant dev_err here.

Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
 drivers/thermal/amlogic_thermal.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Neil Armstrong April 7, 2021, 8:51 a.m. | #1
On 22/02/2021 07:11, Tang Bin wrote:
> The function devm_platform_ioremap_resource has already contains error

> message, so remove the redundant dev_err here.

> 

> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>

> ---

>  drivers/thermal/amlogic_thermal.c | 4 +---

>  1 file changed, 1 insertion(+), 3 deletions(-)

> 

> diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c

> index ccb1fe18e..bba9f3b14 100644

> --- a/drivers/thermal/amlogic_thermal.c

> +++ b/drivers/thermal/amlogic_thermal.c

> @@ -253,10 +253,8 @@ static int amlogic_thermal_probe(struct platform_device *pdev)

>  	platform_set_drvdata(pdev, pdata);

>  

>  	base = devm_platform_ioremap_resource(pdev, 0);

> -	if (IS_ERR(base)) {

> -		dev_err(dev, "failed to get io address\n");

> +	if (IS_ERR(base))

>  		return PTR_ERR(base);

> -	}

>  

>  	pdata->regmap = devm_regmap_init_mmio(dev, base,

>  					      pdata->data->regmap_config);

> 


Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

Patch

diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c
index ccb1fe18e..bba9f3b14 100644
--- a/drivers/thermal/amlogic_thermal.c
+++ b/drivers/thermal/amlogic_thermal.c
@@ -253,10 +253,8 @@  static int amlogic_thermal_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, pdata);
 
 	base = devm_platform_ioremap_resource(pdev, 0);
-	if (IS_ERR(base)) {
-		dev_err(dev, "failed to get io address\n");
+	if (IS_ERR(base))
 		return PTR_ERR(base);
-	}
 
 	pdata->regmap = devm_regmap_init_mmio(dev, base,
 					      pdata->data->regmap_config);