[edk2] Add .gitignore

Message ID 20141010183850.GY22224@bivouac.eciton.net
State New
Headers show

Commit Message

Leif Lindholm Oct. 10, 2014, 6:38 p.m.
On Fri, Oct 10, 2014 at 07:09:22AM -0700, Jordan Justen wrote:
> >> > I guess that should be in addition to keeping it here?
> >>
> >> There is no need for those patterns at the root if they are ignored at
> >> the BaseTools directory level.
> >
> > There is until the next BaseTools sync.
> 
> BaseTools trunk is now in EDK II, so the sync problem is gone.

In which case, how about:

>From acd1645a354e315aba1507dd27d95990691f38a4 Mon Sep 17 00:00:00 2001
From: Ryan Harkin <ryan.harkin@linaro.org>
Date: Wed, 8 May 2013 16:18:34 +0100
Subject: [PATCH] Add .gitignore files

While edk2 is still maintained in SVN, Many edk2 developers use git
for their main workflow, using the official mirrors.
Add a .gitignore and a BaseTools/.gitignore to prevents files
generated as part of the build from cluttering up "git status" output.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ryan Harkin <ryan.harkin@linaro.org>
[removed Linaro-specific bits, rework for upstream]
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
 .gitignore           |    6 ++++++
 BaseTools/.gitignore |   11 +++++++++++
 2 files changed, 17 insertions(+)
 create mode 100644 .gitignore
 create mode 100644 BaseTools/.gitignore

Comments

Jordan Justen Oct. 10, 2014, 8:46 p.m. | #1
On Fri, Oct 10, 2014 at 11:38 AM, Leif Lindholm
<leif.lindholm@linaro.org> wrote:
> On Fri, Oct 10, 2014 at 07:09:22AM -0700, Jordan Justen wrote:
> > >> > I guess that should be in addition to keeping it here?
> > >>
> > >> There is no need for those patterns at the root if they are ignored at
> > >> the BaseTools directory level.
> > >
> > > There is until the next BaseTools sync.
> >
> > BaseTools trunk is now in EDK II, so the sync problem is gone.
>
> In which case, how about:
>
> >From acd1645a354e315aba1507dd27d95990691f38a4 Mon Sep 17 00:00:00 2001
> From: Ryan Harkin <ryan.harkin@linaro.org>
> Date: Wed, 8 May 2013 16:18:34 +0100
> Subject: [PATCH] Add .gitignore files
>
> While edk2 is still maintained in SVN, Many edk2 developers use git
> for their main workflow, using the official mirrors.
> Add a .gitignore and a BaseTools/.gitignore to prevents files
> generated as part of the build from cluttering up "git status" output.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ryan Harkin <ryan.harkin@linaro.org>
> [removed Linaro-specific bits, rework for upstream]
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
>  .gitignore           |    6 ++++++
>  BaseTools/.gitignore |   11 +++++++++++
>  2 files changed, 17 insertions(+)
>  create mode 100644 .gitignore
>  create mode 100644 BaseTools/.gitignore
>
> diff --git a/.gitignore b/.gitignore
> new file mode 100644
> index 0000000..918478d
> --- /dev/null
> +++ b/.gitignore
> @@ -0,0 +1,6 @@
> +*.d
> +*.o
> +*.pyc

These should only be needed in BaseTools.

> +Build/
> +Conf/

Can you move this to Conf/.gitignore as *?

-Jordan

> +tags/
> diff --git a/BaseTools/.gitignore b/BaseTools/.gitignore
> new file mode 100644
> index 0000000..37f89e3
> --- /dev/null
> +++ b/BaseTools/.gitignore
> @@ -0,0 +1,11 @@
> +Source/C/VfrCompile/EfiVfrParser.cpp
> +Source/C/VfrCompile/EfiVfrParser.h
> +Source/C/VfrCompile/Pccts/antlr/antlr
> +Source/C/VfrCompile/Pccts/dlg/dlg
> +Source/C/VfrCompile/VfrLexer.cpp
> +Source/C/VfrCompile/VfrLexer.h
> +Source/C/VfrCompile/VfrParser.dlg
> +Source/C/VfrCompile/VfrSyntax.cpp
> +Source/C/VfrCompile/VfrTokens.h
> +Source/C/bin/
> +Source/C/libs/
> --
> 1.7.10.4
>
>
> ------------------------------------------------------------------------------
> Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
> Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
> Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
> Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
> http://p.sf.net/sfu/Zoho
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel

------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://p.sf.net/sfu/Zoho
Leif Lindholm Oct. 10, 2014, 8:57 p.m. | #2
On Fri, Oct 10, 2014 at 01:46:04PM -0700, Jordan Justen wrote:
> On Fri, Oct 10, 2014 at 11:38 AM, Leif Lindholm
> <leif.lindholm@linaro.org> wrote:
> > On Fri, Oct 10, 2014 at 07:09:22AM -0700, Jordan Justen wrote:
> > > >> > I guess that should be in addition to keeping it here?
> > > >>
> > > >> There is no need for those patterns at the root if they are ignored at
> > > >> the BaseTools directory level.
> > > >
> > > > There is until the next BaseTools sync.
> > >
> > > BaseTools trunk is now in EDK II, so the sync problem is gone.
> >
> > In which case, how about:
> >
> > >From acd1645a354e315aba1507dd27d95990691f38a4 Mon Sep 17 00:00:00 2001
> > From: Ryan Harkin <ryan.harkin@linaro.org>
> > Date: Wed, 8 May 2013 16:18:34 +0100
> > Subject: [PATCH] Add .gitignore files
> >
> > While edk2 is still maintained in SVN, Many edk2 developers use git
> > for their main workflow, using the official mirrors.
> > Add a .gitignore and a BaseTools/.gitignore to prevents files
> > generated as part of the build from cluttering up "git status" output.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Ryan Harkin <ryan.harkin@linaro.org>
> > [removed Linaro-specific bits, rework for upstream]
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> > ---
> >  .gitignore           |    6 ++++++
> >  BaseTools/.gitignore |   11 +++++++++++
> >  2 files changed, 17 insertions(+)
> >  create mode 100644 .gitignore
> >  create mode 100644 BaseTools/.gitignore
> >
> > diff --git a/.gitignore b/.gitignore
> > new file mode 100644
> > index 0000000..918478d
> > --- /dev/null
> > +++ b/.gitignore
> > @@ -0,0 +1,6 @@
> > +*.d
> > +*.o
> > +*.pyc
> 
> These should only be needed in BaseTools.

Would we want to not ignore these if they appeared elsewhere?

> > +Build/
> > +Conf/
> 
> Can you move this to Conf/.gitignore as *?

Are these the final comments?

/
    Leif

------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://p.sf.net/sfu/Zoho
Jordan Justen Oct. 10, 2014, 9:08 p.m. | #3
On Fri, Oct 10, 2014 at 1:57 PM, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Fri, Oct 10, 2014 at 01:46:04PM -0700, Jordan Justen wrote:
>> On Fri, Oct 10, 2014 at 11:38 AM, Leif Lindholm
>> <leif.lindholm@linaro.org> wrote:
>> > On Fri, Oct 10, 2014 at 07:09:22AM -0700, Jordan Justen wrote:
>> > > >> > I guess that should be in addition to keeping it here?
>> > > >>
>> > > >> There is no need for those patterns at the root if they are ignored at
>> > > >> the BaseTools directory level.
>> > > >
>> > > > There is until the next BaseTools sync.
>> > >
>> > > BaseTools trunk is now in EDK II, so the sync problem is gone.
>> >
>> > In which case, how about:
>> >
>> > >From acd1645a354e315aba1507dd27d95990691f38a4 Mon Sep 17 00:00:00 2001
>> > From: Ryan Harkin <ryan.harkin@linaro.org>
>> > Date: Wed, 8 May 2013 16:18:34 +0100
>> > Subject: [PATCH] Add .gitignore files
>> >
>> > While edk2 is still maintained in SVN, Many edk2 developers use git
>> > for their main workflow, using the official mirrors.
>> > Add a .gitignore and a BaseTools/.gitignore to prevents files
>> > generated as part of the build from cluttering up "git status" output.
>> >
>> > Contributed-under: TianoCore Contribution Agreement 1.0
>> > Signed-off-by: Ryan Harkin <ryan.harkin@linaro.org>
>> > [removed Linaro-specific bits, rework for upstream]
>> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>> > ---
>> >  .gitignore           |    6 ++++++
>> >  BaseTools/.gitignore |   11 +++++++++++
>> >  2 files changed, 17 insertions(+)
>> >  create mode 100644 .gitignore
>> >  create mode 100644 BaseTools/.gitignore
>> >
>> > diff --git a/.gitignore b/.gitignore
>> > new file mode 100644
>> > index 0000000..918478d
>> > --- /dev/null
>> > +++ b/.gitignore
>> > @@ -0,0 +1,6 @@
>> > +*.d
>> > +*.o
>> > +*.pyc
>>
>> These should only be needed in BaseTools.
>
> Would we want to not ignore these if they appeared elsewhere?

I can't think of a good reason for them to appear elsewhere in the tree.

>> > +Build/
>> > +Conf/
>>
>> Can you move this to Conf/.gitignore as *?
>
> Are these the final comments?

I did mentioned these previously. :)

Anyway, with those changes
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://p.sf.net/sfu/Zoho

Patch

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000..918478d
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,6 @@ 
+*.d
+*.o
+*.pyc
+Build/
+Conf/
+tags/
diff --git a/BaseTools/.gitignore b/BaseTools/.gitignore
new file mode 100644
index 0000000..37f89e3
--- /dev/null
+++ b/BaseTools/.gitignore
@@ -0,0 +1,11 @@ 
+Source/C/VfrCompile/EfiVfrParser.cpp
+Source/C/VfrCompile/EfiVfrParser.h
+Source/C/VfrCompile/Pccts/antlr/antlr
+Source/C/VfrCompile/Pccts/dlg/dlg
+Source/C/VfrCompile/VfrLexer.cpp
+Source/C/VfrCompile/VfrLexer.h
+Source/C/VfrCompile/VfrParser.dlg
+Source/C/VfrCompile/VfrSyntax.cpp
+Source/C/VfrCompile/VfrTokens.h
+Source/C/bin/
+Source/C/libs/