diff mbox series

[v3] net: usb: qmi_wwan: support ZTE P685M modem

Message ID 20210223183456.6377-1-lech.perczak@gmail.com
State New
Headers show
Series [v3] net: usb: qmi_wwan: support ZTE P685M modem | expand

Commit Message

Lech Perczak Feb. 23, 2021, 6:34 p.m. UTC 
Now that interface 3 in "option" driver is no longer mapped, add device
ID matching it to qmi_wwan.

The modem is used inside ZTE MF283+ router and carriers identify it as
such.
Interface mapping is:
0: QCDM, 1: AT (PCUI), 2: AT (Modem), 3: QMI, 4: ADB

T:  Bus=02 Lev=02 Prnt=02 Port=05 Cnt=01 Dev#=  3 Spd=480  MxCh= 0
D:  Ver= 2.01 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
P:  Vendor=19d2 ProdID=1275 Rev=f0.00
S:  Manufacturer=ZTE,Incorporated
S:  Product=ZTE Technologies MSM
S:  SerialNumber=P685M510ZTED0000CP&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&0
C:* #Ifs= 5 Cfg#= 1 Atr=a0 MxPwr=500mA
I:* If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=option
E:  Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E:  Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
I:* If#= 1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
E:  Ad=83(I) Atr=03(Int.) MxPS=  10 Ivl=32ms
E:  Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E:  Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
I:* If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
E:  Ad=85(I) Atr=03(Int.) MxPS=  10 Ivl=32ms
E:  Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E:  Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
I:* If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan
E:  Ad=87(I) Atr=03(Int.) MxPS=   8 Ivl=32ms
E:  Ad=86(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E:  Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
I:* If#= 4 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none)
E:  Ad=88(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E:  Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms

Acked-by: Bjørn Mork <bjorn@mork.no>
Signed-off-by: Lech Perczak <lech.perczak@gmail.com>
---
Now that patch for "option" has landed in 'master' and 'net', resend the second part.

v3: no changes, resend separately again, add Acked-by from Bjørn Mork.

v2: no changes to this patch, resend as series.

 drivers/net/usb/qmi_wwan.c | 1 +
 1 file changed, 1 insertion(+)

Comments

patchwork-bot+netdevbpf@kernel.org Feb. 24, 2021, 6:10 p.m. UTC | #1 
Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Tue, 23 Feb 2021 19:34:56 +0100 you wrote:
> Now that interface 3 in "option" driver is no longer mapped, add device
> ID matching it to qmi_wwan.
> 
> The modem is used inside ZTE MF283+ router and carriers identify it as
> such.
> Interface mapping is:
> 0: QCDM, 1: AT (PCUI), 2: AT (Modem), 3: QMI, 4: ADB
> 
> [...]

Here is the summary with links:
  - [v3] net: usb: qmi_wwan: support ZTE P685M modem
    https://git.kernel.org/netdev/net/c/88eee9b7b42e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Jakub Kicinski March 2, 2021, 11:12 p.m. UTC | #2 
On Mon, 1 Mar 2021 22:13:08 +0100 Lech Perczak wrote:
> On 2021-02-24 at 19:10, patchwork-bot+netdevbpf@kernel.org wrote:

> > Hello:

> >

> > This patch was applied to netdev/net.git (refs/heads/master):

> >

> > On Tue, 23 Feb 2021 19:34:56 +0100 you wrote:  

> >> Now that interface 3 in "option" driver is no longer mapped, add device

> >> ID matching it to qmi_wwan.

> >>

> >> The modem is used inside ZTE MF283+ router and carriers identify it as

> >> such.

> >> Interface mapping is:

> >> 0: QCDM, 1: AT (PCUI), 2: AT (Modem), 3: QMI, 4: ADB

> >>

> >> [...]  

> > Here is the summary with links:

> >    - [v3] net: usb: qmi_wwan: support ZTE P685M modem

> >      https://git.kernel.org/netdev/net/c/88eee9b7b42e

> >

> > You are awesome, thank you!

> > --

> > Deet-doot-dot, I am a bot.

> > https://korg.docs.kernel.org/patchwork/pwbot.html

> >  

> I see that the usb-serial counterpart of this patch was queued up for 

> stable [1], so just for the sake of completeness, it might be worthy to 

> consider this one too. This would likely make OpenWrt folks happy -  I 

> think that going for 5.4.y and upper would suffice, as 5.4 is currently 

> used as stable kernel there, and most of targets are switching to 5.10 

> right now.

> 

> Upstream commit is 88eee9b7b42e69fb622ddb3ff6f37e8e4347f5b2.

> 

> [1] 

> https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-5.11/usb-serial-option-update-interface-mapping-for-zte-p685m.patch?id=a15ddfc3cd600b31862fdde91f8988e1cfc7bffe


Please send this request directly to stable@, we're through with 
this patch on our end. Thanks!
diff mbox series

Patch

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 6c3d8c2abd38..17a050521b86 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1318,6 +1318,7 @@  static const struct usb_device_id products[] = {
 	{QMI_FIXED_INTF(0x19d2, 0x1255, 4)},
 	{QMI_FIXED_INTF(0x19d2, 0x1256, 4)},
 	{QMI_FIXED_INTF(0x19d2, 0x1270, 5)},	/* ZTE MF667 */
+	{QMI_FIXED_INTF(0x19d2, 0x1275, 3)},	/* ZTE P685M */
 	{QMI_FIXED_INTF(0x19d2, 0x1401, 2)},
 	{QMI_FIXED_INTF(0x19d2, 0x1402, 2)},	/* ZTE MF60 */
 	{QMI_FIXED_INTF(0x19d2, 0x1424, 2)},