[edk2] ArmVExpressPkg: enable specifying firmware version string on build

Message ID 1413288353-28739-1-git-send-email-leif.lindholm@linaro.org
State New
Headers show

Commit Message

Leif Lindholm Oct. 14, 2014, 12:05 p.m.
If FIRMWARE_VER is defined on the build command line, set
gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString based on it.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
 ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc |    3 +++
 1 file changed, 3 insertions(+)

Comments

Olivier Martin Oct. 14, 2014, 2:47 p.m. | #1
Thanks Leif for the contribution.

Reviewed-By:  Olivier Martin <olivier.martin@arm.com>

Committed in SVN rev16212.

> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: 14 October 2014 13:06
> To: edk2-devel@lists.sourceforge.net
> Cc: Olivier Martin
> Subject: [PATCH] ArmVExpressPkg: enable specifying firmware version
> string on build
> 
> If FIRMWARE_VER is defined on the build command line, set
> gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString based on it.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
>  ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc
> b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc
> index fb2efd5..c97aa58 100644
> --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc
> +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc
> @@ -256,6 +256,9 @@
> 
>  [PcdsFixedAtBuild.common]
>    gArmPlatformTokenSpaceGuid.PcdFirmwareVendor|"ARM Versatile Express"
> +!ifdef $(FIRMWARE_VER)
> +
> gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VE
> R)"
> +!endif
> 
>    gEmbeddedTokenSpaceGuid.PcdEmbeddedPrompt|"VExpress"
>    gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000
> --
> 1.7.10.4
> 





------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho

Patch

diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc
index fb2efd5..c97aa58 100644
--- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc
+++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc
@@ -256,6 +256,9 @@ 
 
 [PcdsFixedAtBuild.common]
   gArmPlatformTokenSpaceGuid.PcdFirmwareVendor|"ARM Versatile Express"
+!ifdef $(FIRMWARE_VER)
+  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)"
+!endif
 
   gEmbeddedTokenSpaceGuid.PcdEmbeddedPrompt|"VExpress"
   gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000