| Message ID | 1614071362-123210-1-git-send-email-yang.lee@linux.alibaba.com |
|---|---|
| State | New |
| Headers | show |
| Series | drivers: ipa: Add missing IRQF_ONESHOT | expand |
diff --git a/drivers/net/ipa/ipa_smp2p.c b/drivers/net/ipa/ipa_smp2p.c index a5f7a79..1149ed8 100644 --- a/drivers/net/ipa/ipa_smp2p.c +++ b/drivers/net/ipa/ipa_smp2p.c @@ -183,7 +183,7 @@ static int ipa_smp2p_irq_init(struct ipa_smp2p *smp2p, const char *name, } irq = ret; - ret = request_threaded_irq(irq, NULL, handler, 0, name, smp2p); + ret = request_threaded_irq(irq, NULL, handler, IRQF_ONESHOT, name, smp2p); if (ret) { dev_err(dev, "error %d requesting \"%s\" IRQ\n", ret, name); return ret;
fixed the following coccicheck: ./drivers/net/ipa/ipa_smp2p.c:186:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/net/ipa/ipa_smp2p.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)