| Message ID | 1413552079-17759-1-git-send-email-ciprian.barbu@linaro.org |
|---|---|
| State | New |
| Headers | show |
Mike suggested to set the default value of --with-platform to the current platform, might be a good idea to do the same for the other repos. On Fri, Oct 17, 2014 at 4:21 PM, Ciprian Barbu <ciprian.barbu@linaro.org> wrote: > Signed-off-by: Ciprian Barbu <ciprian.barbu@linaro.org> > --- > configure.ac | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index bba280f..a1c68ba 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -45,9 +45,9 @@ AC_TYPE_UINT64_T > ########################################################################## > AC_ARG_WITH([platform], > [AS_HELP_STRING([--with-platform=prefix], > - [Select platform to be used, default linux-generic])], > + [Select platform to be used, default linux-netmap])], > [], > - [with_platform=linux-generic]) > + [with_platform=linux-netmap]) > > AC_SUBST([with_platform]) > > -- > 1.8.3.2 >
On 17 October 2014 09:21, Ciprian Barbu <ciprian.barbu@linaro.org> wrote: > Signed-off-by: Ciprian Barbu <ciprian.barbu@linaro.org> > Reviewed-by: Mike Holmes <mike.holmes@linaro.org> This makes the default be the build of the repo just pulled rather than a confusing build of linux-generic which is also included mostly to steal its headers. > --- > configure.ac | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index bba280f..a1c68ba 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -45,9 +45,9 @@ AC_TYPE_UINT64_T > ########################################################################## > AC_ARG_WITH([platform], > [AS_HELP_STRING([--with-platform=prefix], > - [Select platform to be used, default linux-generic])], > + [Select platform to be used, default linux-netmap])], > [], > - [with_platform=linux-generic]) > + [with_platform=linux-netmap]) > > AC_SUBST([with_platform]) > > -- > 1.8.3.2 > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
On Fri, Oct 17, 2014 at 4:34 PM, Mike Holmes <mike.holmes@linaro.org> wrote: > > > On 17 October 2014 09:21, Ciprian Barbu <ciprian.barbu@linaro.org> wrote: >> >> Signed-off-by: Ciprian Barbu <ciprian.barbu@linaro.org> > > > Reviewed-by: Mike Holmes <mike.holmes@linaro.org> > > This makes the default be the build of the repo just pulled rather than a > confusing build of linux-generic which is also included mostly to steal its > headers. Applied, thank you! I added the extra description lines for better tracking. > > >> >> --- >> configure.ac | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/configure.ac b/configure.ac >> index bba280f..a1c68ba 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -45,9 +45,9 @@ AC_TYPE_UINT64_T >> >> ########################################################################## >> AC_ARG_WITH([platform], >> [AS_HELP_STRING([--with-platform=prefix], >> - [Select platform to be used, default linux-generic])], >> + [Select platform to be used, default linux-netmap])], >> [], >> - [with_platform=linux-generic]) >> + [with_platform=linux-netmap]) >> >> AC_SUBST([with_platform]) >> >> -- >> 1.8.3.2 >> >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> http://lists.linaro.org/mailman/listinfo/lng-odp > > > > > -- > Mike Holmes > Linaro Sr Technical Manager > LNG - ODP
diff --git a/configure.ac b/configure.ac index bba280f..a1c68ba 100644 --- a/configure.ac +++ b/configure.ac @@ -45,9 +45,9 @@ AC_TYPE_UINT64_T ########################################################################## AC_ARG_WITH([platform], [AS_HELP_STRING([--with-platform=prefix], - [Select platform to be used, default linux-generic])], + [Select platform to be used, default linux-netmap])], [], - [with_platform=linux-generic]) + [with_platform=linux-netmap]) AC_SUBST([with_platform])
Signed-off-by: Ciprian Barbu <ciprian.barbu@linaro.org> --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)