[net,3/3] net: dsa: rtl4_a: Syntax fixes

Message ID 20210301133241.1277164-3-linus.walleij@linaro.org
State New
Headers show
Series
  • [net,1/3] net: dsa: rtl4_a: Pad using __skb_put_padto()
Related show

Commit Message

Linus Walleij March 1, 2021, 1:32 p.m.
Some errors spotted in the initial patch: use reverse
christmas tree for nice code looks and fix a spelling
mistake.

Reported-by: Andrew Lunn <andrew@lunn.ch>
Reported-by: DENG Qingfang <dqfext@gmail.com>
Cc: Mauri Sandberg <sandberg@mailfence.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
 net/dsa/tag_rtl4_a.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.29.2

Comments

Florian Fainelli March 2, 2021, 1:41 a.m. | #1
On 3/1/2021 5:32 AM, Linus Walleij wrote:
> Some errors spotted in the initial patch: use reverse
> christmas tree for nice code looks and fix a spelling
> mistake.
> 
> Reported-by: Andrew Lunn <andrew@lunn.ch>
> Reported-by: DENG Qingfang <dqfext@gmail.com>
> Cc: Mauri Sandberg <sandberg@mailfence.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

Patch

diff --git a/net/dsa/tag_rtl4_a.c b/net/dsa/tag_rtl4_a.c
index 8098d81f660b..9da56c5ea9dc 100644
--- a/net/dsa/tag_rtl4_a.c
+++ b/net/dsa/tag_rtl4_a.c
@@ -36,8 +36,8 @@  static struct sk_buff *rtl4a_tag_xmit(struct sk_buff *skb,
 {
 	struct dsa_port *dp = dsa_slave_to_port(dev);
 	u8 *tag;
-	u16 *p;
 	u16 out;
+	u16 *p;
 
 	/* Pad out to at least 60 bytes */
 	if (__skb_put_padto(skb, ETH_ZLEN, false))
@@ -55,7 +55,7 @@  static struct sk_buff *rtl4a_tag_xmit(struct sk_buff *skb,
 	*p = htons(RTL4_A_ETHERTYPE);
 
 	out = (RTL4_A_PROTOCOL_RTL8366RB << 12) | (2 << 8);
-	/* The lower bits is the port numer */
+	/* The lower bits are the port numer */
 	out |= (u8)dp->index;
 	p = (u16 *)(tag + 2);
 	*p = htons(out);