From patchwork Sat Oct 18 01:23:25 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 39000 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f198.google.com (mail-wi0-f198.google.com [209.85.212.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 9338A2054E for ; Sat, 18 Oct 2014 01:24:04 +0000 (UTC) Received: by mail-wi0-f198.google.com with SMTP id hi2sf1089640wib.1 for ; Fri, 17 Oct 2014 18:24:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :mime-version:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe:content-type; bh=rsQegpojPM+h5QaXr4p6aJTTcnxx/vm1lUzg2h+ooFg=; b=ESUhJ1KbZqHjPaBKE8/niflYcQ4o2k1Pp5ivvQOqixk82nUJVcKikwpkHrJbCi2ShH z+cHrW1D+Ly83L1J2JekxooJatsi/ms/FueAmOeQE/dVVcDnj3nSL6FXAfhPwIQGhcBU 6qWT3a/aFq8wgkoPpfsJDMtqc08KKVoxE1NzRffi2ayeTAgsmnLNItUSo3p9GoOrq57a YWq8jxmOQq8S5huXGAeG7A1lLvCcSCflQx9ce/lQ1OFjWpGMiPfgKv505FyohL4OLkwF dT9Oiod/UFnef1udEJSKjSXP9a7hDg3/FNnWfzeyoDBPyvf0oeMDbF1caFTsaX+6a9vD 6Kmw== X-Gm-Message-State: ALoCoQlUrQAxx1AJ0MzupXN8sQ+BiHhrrxHHwJQe/2n4PfA8cHfVUoQ14HYAFVgCVaUR/7B8OkWK X-Received: by 10.152.25.202 with SMTP id e10mr1939106lag.2.1413595443340; Fri, 17 Oct 2014 18:24:03 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.23.133 with SMTP id m5ls293020laf.102.gmail; Fri, 17 Oct 2014 18:24:02 -0700 (PDT) X-Received: by 10.152.30.9 with SMTP id o9mr465256lah.8.1413595442945; Fri, 17 Oct 2014 18:24:02 -0700 (PDT) Received: from mail-la0-f53.google.com (mail-la0-f53.google.com. [209.85.215.53]) by mx.google.com with ESMTPS id s6si4304044laj.90.2014.10.17.18.24.02 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 17 Oct 2014 18:24:02 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.53 as permitted sender) client-ip=209.85.215.53; Received: by mail-la0-f53.google.com with SMTP id gq15so1574999lab.12 for ; Fri, 17 Oct 2014 18:24:02 -0700 (PDT) X-Received: by 10.152.161.195 with SMTP id xu3mr12149321lab.15.1413595442528; Fri, 17 Oct 2014 18:24:02 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.84.229 with SMTP id c5csp327910lbz; Fri, 17 Oct 2014 18:24:01 -0700 (PDT) X-Received: by 10.68.109.195 with SMTP id hu3mr80761pbb.136.1413595441019; Fri, 17 Oct 2014 18:24:01 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id kp1si2492930pbd.33.2014.10.17.18.24.00 for ; Fri, 17 Oct 2014 18:24:01 -0700 (PDT) Received-SPF: none (google.com: linux-usb-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751096AbaJRBXt (ORCPT + 3 others); Fri, 17 Oct 2014 21:23:49 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:54293 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750870AbaJRBXt (ORCPT ); Fri, 17 Oct 2014 21:23:49 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id s9I1NefS012068; Fri, 17 Oct 2014 20:23:40 -0500 Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s9I1Ndvl028727; Fri, 17 Oct 2014 20:23:40 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.3.174.1; Fri, 17 Oct 2014 20:23:40 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s9I1NcNT032403; Fri, 17 Oct 2014 20:23:39 -0500 From: Felipe Balbi To: Linux USB Mailing List CC: Paul Zimmerman , , , , , Felipe Balbi Subject: [PATCH 1/4] usb: dwc2: gadget: do not call usb_gadget_unregister_driver() Date: Fri, 17 Oct 2014 20:23:25 -0500 Message-ID: <1413595408-2011-1-git-send-email-balbi@ti.com> X-Mailer: git-send-email 2.1.0.GIT MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: balbi@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.53 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , that call is completely unnecessary because usb_del_gadget_udc() already makes sure the gadget driver is properly unregistered from the UDC. Signed-off-by: Felipe Balbi Acked-by: Paul Zimmerman --- found while reading code drivers/usb/dwc2/gadget.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index e55ba85..8f1502f 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -3608,14 +3608,7 @@ static int s3c_hsotg_remove(struct platform_device *pdev) struct s3c_hsotg *hsotg = platform_get_drvdata(pdev); usb_del_gadget_udc(&hsotg->gadget); - s3c_hsotg_delete_debug(hsotg); - - if (hsotg->driver) { - /* should have been done already by driver model core */ - usb_gadget_unregister_driver(hsotg->driver); - } - clk_disable_unprepare(hsotg->clk); return 0;