[4/4] usb: gadget: udc: pxa27x: do not call usb_gadget_unregister_driver()

Message ID 1413595408-2011-4-git-send-email-balbi@ti.com
State Accepted
Commit 76bfa95eab10f6bfd7e7d33a9b7cccbefa036f5c
Headers show

Commit Message

Felipe Balbi Oct. 18, 2014, 1:23 a.m.
that call is completely unnecessary because
usb_del_gadget_udc() already makes sure the
gadget driver is properly unregistered from
the UDC.

Signed-off-by: Felipe Balbi <balbi@ti.com>
---

found while reading code

 drivers/usb/gadget/udc/pxa27x_udc.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Robert Jarzmik Oct. 18, 2014, 3:07 p.m. | #1
Felipe Balbi <balbi@ti.com> writes:

> that call is completely unnecessary because
> usb_del_gadget_udc() already makes sure the
> gadget driver is properly unregistered from
> the UDC.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
>
> found while reading code
>
>  drivers/usb/gadget/udc/pxa27x_udc.c | 1 -
>  1 file changed, 1 deletion(-)
Indeed.

Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

Cheers.

--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c
index dd6890d..69e7b816 100644
--- a/drivers/usb/gadget/udc/pxa27x_udc.c
+++ b/drivers/usb/gadget/udc/pxa27x_udc.c
@@ -2501,7 +2501,6 @@  static int pxa_udc_remove(struct platform_device *_dev)
 	struct pxa_udc *udc = platform_get_drvdata(_dev);
 
 	usb_del_gadget_udc(&udc->gadget);
-	usb_gadget_unregister_driver(udc->driver);
 	pxa_cleanup_debugfs(udc);
 
 	usb_put_phy(udc->transceiver);