From patchwork Sat Oct 18 01:23:28 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 39001 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f198.google.com (mail-lb0-f198.google.com [209.85.217.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id E56FB2054E for ; Sat, 18 Oct 2014 01:24:05 +0000 (UTC) Received: by mail-lb0-f198.google.com with SMTP id 10sf1012290lbg.5 for ; Fri, 17 Oct 2014 18:24:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=R7FggnqqH9tjBdibfwJ0i8HWVVFTKts4TZPDl7kWGkM=; b=DZdRqxT+j8fhxLFo7hW7f5OY3wZnkEVso8jm9n5Ywlvye9HKJqMqqyj8q1rg1faKxp Gcp3ymMToC0h0PK08a4vJGUa7WgY8YaCNPVkheI5eO3KJBJvqgsckQqchFKZtYZOMRk1 rCAM9F/1nTtG6joUakIEVK7wTK2taZH/26eVsFs2OTVKuVaJ2FkwUV2+CVPk0qj535G2 RrDBZzHAawA8L7xvIA8P4g/IyRWfV3ghaHn1QJ6hqVHWLACj5oofBgol6Wbw5Z0ALqMH 6ugQTEqK+3wjSGWu8Cg+yZ9zUH6xAezXc2gKpNj8Ovxl3zj4w05rWeKkQZSakykgwkwO I74w== X-Gm-Message-State: ALoCoQkzaBHLYi8exnzWoWfkpYV8sctDzF7wBKDESavrn6G+yEK8AJlIa1Lf+IJyAWnONYftmGTH X-Received: by 10.180.186.142 with SMTP id fk14mr384821wic.4.1413595444379; Fri, 17 Oct 2014 18:24:04 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.203.167 with SMTP id kr7ls293029lac.94.gmail; Fri, 17 Oct 2014 18:24:03 -0700 (PDT) X-Received: by 10.152.9.201 with SMTP id c9mr12191484lab.38.1413595443868; Fri, 17 Oct 2014 18:24:03 -0700 (PDT) Received: from mail-lb0-f174.google.com (mail-lb0-f174.google.com. [209.85.217.174]) by mx.google.com with ESMTPS id h5si4283416laf.110.2014.10.17.18.24.03 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 17 Oct 2014 18:24:03 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.174 as permitted sender) client-ip=209.85.217.174; Received: by mail-lb0-f174.google.com with SMTP id p9so1539732lbv.33 for ; Fri, 17 Oct 2014 18:24:03 -0700 (PDT) X-Received: by 10.152.87.66 with SMTP id v2mr12217641laz.28.1413595443626; Fri, 17 Oct 2014 18:24:03 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.84.229 with SMTP id c5csp327911lbz; Fri, 17 Oct 2014 18:24:02 -0700 (PDT) X-Received: by 10.68.89.3 with SMTP id bk3mr11877672pbb.73.1413595441925; Fri, 17 Oct 2014 18:24:01 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id pn4si2487741pac.47.2014.10.17.18.24.01 for ; Fri, 17 Oct 2014 18:24:01 -0700 (PDT) Received-SPF: none (google.com: linux-usb-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751392AbaJRBX6 (ORCPT + 3 others); Fri, 17 Oct 2014 21:23:58 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:33302 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751214AbaJRBXu (ORCPT ); Fri, 17 Oct 2014 21:23:50 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id s9I1Nhad012508; Fri, 17 Oct 2014 20:23:43 -0500 Received: from DLEE70.ent.ti.com (dlemailx.itg.ti.com [157.170.170.113]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id s9I1NhBX025010; Fri, 17 Oct 2014 20:23:43 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.3.174.1; Fri, 17 Oct 2014 20:23:42 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id s9I1NgxB000526; Fri, 17 Oct 2014 20:23:42 -0500 From: Felipe Balbi To: Linux USB Mailing List CC: Paul Zimmerman , , , , , Felipe Balbi Subject: [PATCH 4/4] usb: gadget: udc: pxa27x: do not call usb_gadget_unregister_driver() Date: Fri, 17 Oct 2014 20:23:28 -0500 Message-ID: <1413595408-2011-4-git-send-email-balbi@ti.com> X-Mailer: git-send-email 2.1.0.GIT In-Reply-To: <1413595408-2011-1-git-send-email-balbi@ti.com> References: <1413595408-2011-1-git-send-email-balbi@ti.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: balbi@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.174 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , that call is completely unnecessary because usb_del_gadget_udc() already makes sure the gadget driver is properly unregistered from the UDC. Signed-off-by: Felipe Balbi Acked-by: Robert Jarzmik --- found while reading code drivers/usb/gadget/udc/pxa27x_udc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c index dd6890d..69e7b816 100644 --- a/drivers/usb/gadget/udc/pxa27x_udc.c +++ b/drivers/usb/gadget/udc/pxa27x_udc.c @@ -2501,7 +2501,6 @@ static int pxa_udc_remove(struct platform_device *_dev) struct pxa_udc *udc = platform_get_drvdata(_dev); usb_del_gadget_udc(&udc->gadget); - usb_gadget_unregister_driver(udc->driver); pxa_cleanup_debugfs(udc); usb_put_phy(udc->transceiver);