[3/4] usb: gadget: udc: net2272: do not call usb_gadget_unregister_driver()

Message ID 1413595408-2011-3-git-send-email-balbi@ti.com
State Accepted
Commit 7fd1f9d6663fa20997d2d951ef7ee7e2cd0d266e
Headers show

Commit Message

Felipe Balbi Oct. 18, 2014, 1:23 a.m.
that call is completely unnecessary because
usb_del_gadget_udc() already makes sure the
gadget driver is properly unregistered from
the UDC.

Signed-off-by: Felipe Balbi <balbi@ti.com>
---

found while reading code

 drivers/usb/gadget/udc/net2272.c | 10 ----------
 1 file changed, 10 deletions(-)

Patch

diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c
index 887bea4..ab3a739 100644
--- a/drivers/usb/gadget/udc/net2272.c
+++ b/drivers/usb/gadget/udc/net2272.c
@@ -2195,18 +2195,8 @@  static void
 net2272_remove(struct net2272 *dev)
 {
 	usb_del_gadget_udc(&dev->gadget);
-
-	/* start with the driver above us */
-	if (dev->driver) {
-		/* should have been done already by driver model core */
-		dev_warn(dev->dev, "pci remove, driver '%s' is still registered\n",
-			dev->driver->driver.name);
-		usb_gadget_unregister_driver(dev->driver);
-	}
-
 	free_irq(dev->irq, dev);
 	iounmap(dev->base_addr);
-
 	device_remove_file(dev->dev, &dev_attr_registers);
 
 	dev_info(dev->dev, "unbind\n");