From patchwork Sat Oct 18 01:23:27 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 39002 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f70.google.com (mail-la0-f70.google.com [209.85.215.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id CA2942054E for ; Sat, 18 Oct 2014 01:24:06 +0000 (UTC) Received: by mail-la0-f70.google.com with SMTP id ge10sf1003191lab.9 for ; Fri, 17 Oct 2014 18:24:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=ELGpnHNQSPsrZSZOxSUDZPUKhLLZCansTgrEug7bCsk=; b=XmLoFEoCPgCqPKKHKgKsxcnFhpcR8mHWaBgJ3TZkTNPoc8TU3L9XjKIHUzj5hiuKi6 hP2BIhSkRZOVi/j1aY8Gq8CnuFyPdkfn3j0FIr1rI1vl05S56BdF0GJZCPy+/QVFWdx/ vfsddyI0nR/OPrcefiPYc4eNKBomD70UUMnyWfBDGNLgmpdKkcVDhQUaYvRW6vtXz+aM Yop4xDxBsM+P2WiISomG4jIIkRsMLZCBgo5eXWLEV0hTeNtQpXSKNdOctZT/kK+A7lsO SQX1h1ZDD73PszEspbETSPS1ut9FVkXSIHqvfG5qeOPsGXPrd4hBw+y3MZKU9A243BKh ZUNQ== X-Gm-Message-State: ALoCoQn8HdvzGNGdQwcho4rW1SAYitZ2ALW2jnV9nTj8t1Tba3LmnzDEAppDiBaPzYxkNxuDdVH4 X-Received: by 10.180.186.142 with SMTP id fk14mr384833wic.4.1413595445636; Fri, 17 Oct 2014 18:24:05 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.28.133 with SMTP id b5ls280076lah.26.gmail; Fri, 17 Oct 2014 18:24:05 -0700 (PDT) X-Received: by 10.112.198.226 with SMTP id jf2mr33319lbc.84.1413595445507; Fri, 17 Oct 2014 18:24:05 -0700 (PDT) Received: from mail-lb0-f170.google.com (mail-lb0-f170.google.com. [209.85.217.170]) by mx.google.com with ESMTPS id f8si4258193lbc.136.2014.10.17.18.24.05 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 17 Oct 2014 18:24:05 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.170 as permitted sender) client-ip=209.85.217.170; Received: by mail-lb0-f170.google.com with SMTP id u10so1529608lbd.1 for ; Fri, 17 Oct 2014 18:24:05 -0700 (PDT) X-Received: by 10.112.140.74 with SMTP id re10mr12336925lbb.40.1413595445315; Fri, 17 Oct 2014 18:24:05 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.84.229 with SMTP id c5csp327912lbz; Fri, 17 Oct 2014 18:24:04 -0700 (PDT) X-Received: by 10.68.130.134 with SMTP id oe6mr11951926pbb.3.1413595443777; Fri, 17 Oct 2014 18:24:03 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id pn4si2487741pac.47.2014.10.17.18.24.03 for ; Fri, 17 Oct 2014 18:24:03 -0700 (PDT) Received-SPF: none (google.com: linux-usb-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751334AbaJRBYA (ORCPT + 3 others); Fri, 17 Oct 2014 21:24:00 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:33301 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750989AbaJRBXu (ORCPT ); Fri, 17 Oct 2014 21:23:50 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id s9I1Ngwp012503; Fri, 17 Oct 2014 20:23:42 -0500 Received: from DLEE70.ent.ti.com (dlee70.ent.ti.com [157.170.170.113]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id s9I1NfJM025002; Fri, 17 Oct 2014 20:23:41 -0500 Received: from dlep32.itg.ti.com (157.170.170.100) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.3.174.1; Fri, 17 Oct 2014 20:23:41 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id s9I1Nf67031531; Fri, 17 Oct 2014 20:23:41 -0500 From: Felipe Balbi To: Linux USB Mailing List CC: Paul Zimmerman , , , , , Felipe Balbi Subject: [PATCH 3/4] usb: gadget: udc: net2272: do not call usb_gadget_unregister_driver() Date: Fri, 17 Oct 2014 20:23:27 -0500 Message-ID: <1413595408-2011-3-git-send-email-balbi@ti.com> X-Mailer: git-send-email 2.1.0.GIT In-Reply-To: <1413595408-2011-1-git-send-email-balbi@ti.com> References: <1413595408-2011-1-git-send-email-balbi@ti.com> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: balbi@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.170 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , that call is completely unnecessary because usb_del_gadget_udc() already makes sure the gadget driver is properly unregistered from the UDC. Signed-off-by: Felipe Balbi --- found while reading code drivers/usb/gadget/udc/net2272.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c index 887bea4..ab3a739 100644 --- a/drivers/usb/gadget/udc/net2272.c +++ b/drivers/usb/gadget/udc/net2272.c @@ -2195,18 +2195,8 @@ static void net2272_remove(struct net2272 *dev) { usb_del_gadget_udc(&dev->gadget); - - /* start with the driver above us */ - if (dev->driver) { - /* should have been done already by driver model core */ - dev_warn(dev->dev, "pci remove, driver '%s' is still registered\n", - dev->driver->driver.name); - usb_gadget_unregister_driver(dev->driver); - } - free_irq(dev->irq, dev); iounmap(dev->base_addr); - device_remove_file(dev->dev, &dev_attr_registers); dev_info(dev->dev, "unbind\n");