| Message ID | 1413913943-40964-1-git-send-email-mike.holmes@linaro.org |
|---|---|
| State | Accepted |
| Commit | 5c7aed2c4d194beea0d88c8fe46c08c7183be94b |
| Headers | show |
why do we do that? Is it for case that other platforms can implement that before linux-generic? Maxim. On 10/21/2014 09:52 PM, Mike Holmes wrote: > Initially implement the termination functions as ODP_UNIMPLEMENTED so that > the unit test cases can call them without a change in behaviour. > > Signed-off-by: Mike Holmes <mike.holmes@linaro.org> > --- > platform/linux-generic/odp_init.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/platform/linux-generic/odp_init.c b/platform/linux-generic/odp_init.c > index c97c5aa..672b3d6 100644 > --- a/platform/linux-generic/odp_init.c > +++ b/platform/linux-generic/odp_init.c > @@ -7,6 +7,7 @@ > #include <odp_init.h> > #include <odp_internal.h> > #include <odp_debug.h> > +#include <odp_debug_internal.h> > > > int odp_init_global(odp_init_t *params ODP_UNUSED, > @@ -57,6 +58,11 @@ int odp_init_global(odp_init_t *params ODP_UNUSED, > return 0; > } > > +int odp_term_global(void) > +{ > + ODP_UNIMPLEMENTED(); > + return 0; > +} > > int odp_init_local(void) > { > @@ -77,3 +83,9 @@ int odp_init_local(void) > > return 0; > } > + > +int odp_term_local(void) > +{ > + ODP_UNIMPLEMENTED(); > + return 0; > +}
On 21 October 2014 14:52, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > why do we do that? Is it for case that other platforms can implement that > before linux-generic? > > Just as with classification we need an implementation so that we can write unit tests against the documentation for that API. It may be that the unit tests following the specification for the API will fail when run against linux generic until the implementation is fixed. I think it is likely that other implementations may implement these before linux generic does, for example I believe KS2 has a need for them already. > Maxim. > > > On 10/21/2014 09:52 PM, Mike Holmes wrote: > >> Initially implement the termination functions as ODP_UNIMPLEMENTED so that >> the unit test cases can call them without a change in behaviour. >> >> Signed-off-by: Mike Holmes <mike.holmes@linaro.org> >> --- >> platform/linux-generic/odp_init.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/platform/linux-generic/odp_init.c >> b/platform/linux-generic/odp_init.c >> index c97c5aa..672b3d6 100644 >> --- a/platform/linux-generic/odp_init.c >> +++ b/platform/linux-generic/odp_init.c >> @@ -7,6 +7,7 @@ >> #include <odp_init.h> >> #include <odp_internal.h> >> #include <odp_debug.h> >> +#include <odp_debug_internal.h> >> int odp_init_global(odp_init_t *params ODP_UNUSED, >> @@ -57,6 +58,11 @@ int odp_init_global(odp_init_t *params ODP_UNUSED, >> return 0; >> } >> +int odp_term_global(void) >> +{ >> + ODP_UNIMPLEMENTED(); >> + return 0; >> +} >> int odp_init_local(void) >> { >> @@ -77,3 +83,9 @@ int odp_init_local(void) >> return 0; >> } >> + >> +int odp_term_local(void) >> +{ >> + ODP_UNIMPLEMENTED(); >> + return 0; >> +} >> > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
Merged. Maxim. On 10/21/2014 09:52 PM, Mike Holmes wrote: > Initially implement the termination functions as ODP_UNIMPLEMENTED so that > the unit test cases can call them without a change in behaviour. > > Signed-off-by: Mike Holmes <mike.holmes@linaro.org> > --- > platform/linux-generic/odp_init.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/platform/linux-generic/odp_init.c b/platform/linux-generic/odp_init.c > index c97c5aa..672b3d6 100644 > --- a/platform/linux-generic/odp_init.c > +++ b/platform/linux-generic/odp_init.c > @@ -7,6 +7,7 @@ > #include <odp_init.h> > #include <odp_internal.h> > #include <odp_debug.h> > +#include <odp_debug_internal.h> > > > int odp_init_global(odp_init_t *params ODP_UNUSED, > @@ -57,6 +58,11 @@ int odp_init_global(odp_init_t *params ODP_UNUSED, > return 0; > } > > +int odp_term_global(void) > +{ > + ODP_UNIMPLEMENTED(); > + return 0; > +} > > int odp_init_local(void) > { > @@ -77,3 +83,9 @@ int odp_init_local(void) > > return 0; > } > + > +int odp_term_local(void) > +{ > + ODP_UNIMPLEMENTED(); > + return 0; > +}
diff --git a/platform/linux-generic/odp_init.c b/platform/linux-generic/odp_init.c index c97c5aa..672b3d6 100644 --- a/platform/linux-generic/odp_init.c +++ b/platform/linux-generic/odp_init.c @@ -7,6 +7,7 @@ #include <odp_init.h> #include <odp_internal.h> #include <odp_debug.h> +#include <odp_debug_internal.h> int odp_init_global(odp_init_t *params ODP_UNUSED, @@ -57,6 +58,11 @@ int odp_init_global(odp_init_t *params ODP_UNUSED, return 0; } +int odp_term_global(void) +{ + ODP_UNIMPLEMENTED(); + return 0; +} int odp_init_local(void) { @@ -77,3 +83,9 @@ int odp_init_local(void) return 0; } + +int odp_term_local(void) +{ + ODP_UNIMPLEMENTED(); + return 0; +}
Initially implement the termination functions as ODP_UNIMPLEMENTED so that the unit test cases can call them without a change in behaviour. Signed-off-by: Mike Holmes <mike.holmes@linaro.org> --- platform/linux-generic/odp_init.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)