diff mbox

[RFC,06/12] time: Fix build warnings for time64_t to __kernel_time_t warning on 64-bit systems.

Message ID 1414388802-5866-5-git-send-email-pang.xunlei@linaro.org
State New
Headers show

Commit Message

pang.xunlei Oct. 27, 2014, 5:46 a.m. UTC
The kernel uses 32-bit signed value(time_t) for seconds since 1970-01-01:00:00:00, so it
will overflow at 2038-01-19 03:14:08 on 32-bit systems. We call this "2038 safety" issue.

This patch fixed the build warnings brought by former patches.

Signed-off-by: pang.xunlei <pang.xunlei@linaro.org>
---
 include/linux/time64.h |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Thomas Gleixner Oct. 27, 2014, 9:41 p.m. UTC | #1
On Mon, 27 Oct 2014, pang.xunlei wrote:

> The kernel uses 32-bit signed value(time_t) for seconds since 1970-01-01:00:00:00, so it
> will overflow at 2038-01-19 03:14:08 on 32-bit systems. We call this "2038 safety" issue.
> 
> This patch fixed the build warnings brought by former patches.

If we know that the previous patch introduced the warning and that
patch has not yet been committed to any immutable git tree then we fix
it in that very patch and not after the fact.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
diff mbox

Patch

diff --git a/include/linux/time64.h b/include/linux/time64.h
index a383147..02f2c87 100644
--- a/include/linux/time64.h
+++ b/include/linux/time64.h
@@ -3,15 +3,15 @@ 
 
 #include <uapi/linux/time.h>
 
-typedef __s64 time64_t;
-
 /*
  * This wants to go into uapi/linux/time.h once we agreed about the
  * userspace interfaces.
  */
 #if __BITS_PER_LONG == 64
-# define timespec64 timespec
+typedef __kernel_time_t time64_t;
+#define timespec64 timespec
 #else
+typedef __s64 time64_t;
 struct timespec64 {
 	time64_t	tv_sec;			/* seconds */
 	long		tv_nsec;		/* nanoseconds */