diff mbox

[v2,1/5] ARM: introduce a CONFIG_ARCH_MULTIPLATFORM_STRICT Kconfig option

Message ID 1414503095-25986-2-git-send-email-kaixu.xia@linaro.org
State New
Headers show

Commit Message

Xia Kaixu Oct. 28, 2014, 1:31 p.m. UTC
The current allmodconfig kernel boot fails on OMAP4460. There
are several configuration options that can only work on a subset
of the available machines, and enabling them will break other
machines that may be enabled in a multiplatform kernel.

Now we introduce a CONFIG_ARCH_MULTIPLATFORM_STRICT Kconfig
option that prevent those other options from getting enabled
and get a strict multiplatform kernel.

Signed-off-by: Xia Kaixu <kaixu.xia@linaro.org>
---
 arch/arm/Kconfig | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Arnd Bergmann Oct. 28, 2014, 2:18 p.m. UTC | #1
On Tuesday 28 October 2014 21:31:31 Xia Kaixu wrote:
>  endmenu
>  
> +config ARCH_MULTIPLATFORM_STRICT
> +        bool "Only allow options that do not break other platforms"
> +        depends on ARCH_MULTIPLATFORM
> +        default y
> +       help
> +          There are several configuration options that can only work
> 

Something seems to be wrong with the whitespace here. Please use tab
characters for indentation like we do elsewhere in the file.

Otherwise looks good, I think this is a good step in the right direction.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Russell King - ARM Linux Oct. 28, 2014, 2:21 p.m. UTC | #2
On Tue, Oct 28, 2014 at 03:18:48PM +0100, Arnd Bergmann wrote:
> On Tuesday 28 October 2014 21:31:31 Xia Kaixu wrote:
> >  endmenu
> >  
> > +config ARCH_MULTIPLATFORM_STRICT
> > +        bool "Only allow options that do not break other platforms"
> > +        depends on ARCH_MULTIPLATFORM
> > +        default y
> > +       help
> > +          There are several configuration options that can only work
> > 
> 
> Something seems to be wrong with the whitespace here. Please use tab
> characters for indentation like we do elsewhere in the file.
> 
> Otherwise looks good, I think this is a good step in the right direction.

I totally disagree.  I've raised individual objections on all uses of
this new symbol in separate emails.
diff mbox

Patch

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 89c4b5c..50762cc 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -840,6 +840,20 @@  config ARCH_MULTI_CPU_AUTO
 
 endmenu
 
+config ARCH_MULTIPLATFORM_STRICT
+        bool "Only allow options that do not break other platforms"
+        depends on ARCH_MULTIPLATFORM
+        default y
+	help
+          There are several configuration options that can only work
+          on a subset of the available machines, and enabling them
+          will break running the kernel on other machines that may be
+          enabled in a multiplatform kernel.
+
+          Enabling ARCH_MULTIPLATFORM_STRICT will prevent those other
+          options from getting enabled, so the kernel should always
+          run on any hardware that is part of the configuration.
+
 config ARCH_VIRT
 	bool "Dummy Virtual Machine" if ARCH_MULTI_V7
 	select ARM_AMBA