diff mbox

[OVS,v2,3/4] Config option to enable ODP debug

Message ID 1414589046-16214-4-git-send-email-zoltan.kiss@linaro.org
State New
Headers show

Commit Message

Zoltan Kiss Oct. 29, 2014, 1:24 p.m. UTC
Signed-off-by: Zoltan Kiss <zoltan.kiss@linaro.org>
---
 acinclude.m4 | 31 ++++++++++++++++++++++++++++++-
 configure.ac |  1 +
 2 files changed, 31 insertions(+), 1 deletion(-)

Comments

Anders Roxell Oct. 31, 2014, 7:17 p.m. UTC | #1
On 2014-10-29 13:24, Zoltan Kiss wrote:
> Signed-off-by: Zoltan Kiss <zoltan.kiss@linaro.org>
> ---
>  acinclude.m4 | 31 ++++++++++++++++++++++++++++++-
>  configure.ac |  1 +
>  2 files changed, 31 insertions(+), 1 deletion(-)
> 
> diff --git a/acinclude.m4 b/acinclude.m4
> index 1579286..5e9f3ee 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -218,6 +218,35 @@ AC_DEFUN([OVS_CHECK_DPDK], [
>    AM_CONDITIONAL([DPDK_NETDEV], test -n "$RTE_SDK")
>  ])
>  
> +dnl OVS_CHECK_ODP_DEBUG
> +dnl
> +dnl Configure ODP debug flag
> +AC_DEFUN([OVS_CHECK_ODP_DEBUG], [
> +  AC_MSG_CHECKING([for ODP Debug])
> +
> +  ODP_DEBUG=0
> +
> +  AC_ARG_WITH([odp-debug],
> +              [AC_HELP_STRING([--with-odp-debug=[@<:@yes | no@:>@]],
> +                              [ODP debug flag; default is false])],
> +              [
> +                 case "$withval" in
> +                 "" |  n | no)
> +                     ODP_DEBUG=0
> +                     AC_MSG_RESULT([no])
> +                     ;;
> +                 y | ye | yes)
> +                     ODP_DEBUG=1
> +                     AC_MSG_RESULT([yes])
> +                     ;;
> +                 *)
> +                     AC_MSG_ERROR([invalid config option])
> +                     ;;
> +                 esac
> +              ]
> +             )
> +])
> +
>  dnl OVS_CHECK_ODP_PLATFORM
>  dnl
>  dnl Configure ODP platform
> @@ -272,7 +301,7 @@ AC_DEFUN([OVS_CHECK_ODP], [
>  
>                   AC_SUBST([ODP_INCLUDE])
>                   AC_SUBST([ODP_LIB_DIR])
> -                 CFLAGS="$CFLAGS -I$ODP_INCLUDE -I$ODPH_INCLUDE"
> +                 CFLAGS="$CFLAGS -I$ODP_INCLUDE -I$ODPH_INCLUDE -DODP_DEBUG_PRINT=$ODP_DEBUG"

Sorry for the late reply.

To have two different variables to set only one feels odd.

and no application should use ODP_DEBUG_PRINT that should be used to get
out debug information from ODP library.

Cheers,
Anders

>                   LDFLAGS="$LDFLAGS $SSL_LDFLAGS -L$ODP_LIB_DIR"
>                     ;;
>                   esac
> diff --git a/configure.ac b/configure.ac
> index e7be627..4cdbd75 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -120,6 +120,7 @@ AC_ARG_VAR(KARCH, [Kernel Architecture String])
>  AC_SUBST(KARCH)
>  OVS_CHECK_LINUX
>  OVS_CHECK_DPDK
> +OVS_CHECK_ODP_DEBUG
>  OVS_CHECK_ODP_PLATFORM
>  OVS_CHECK_ODP
>  
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/acinclude.m4 b/acinclude.m4
index 1579286..5e9f3ee 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -218,6 +218,35 @@  AC_DEFUN([OVS_CHECK_DPDK], [
   AM_CONDITIONAL([DPDK_NETDEV], test -n "$RTE_SDK")
 ])
 
+dnl OVS_CHECK_ODP_DEBUG
+dnl
+dnl Configure ODP debug flag
+AC_DEFUN([OVS_CHECK_ODP_DEBUG], [
+  AC_MSG_CHECKING([for ODP Debug])
+
+  ODP_DEBUG=0
+
+  AC_ARG_WITH([odp-debug],
+              [AC_HELP_STRING([--with-odp-debug=[@<:@yes | no@:>@]],
+                              [ODP debug flag; default is false])],
+              [
+                 case "$withval" in
+                 "" |  n | no)
+                     ODP_DEBUG=0
+                     AC_MSG_RESULT([no])
+                     ;;
+                 y | ye | yes)
+                     ODP_DEBUG=1
+                     AC_MSG_RESULT([yes])
+                     ;;
+                 *)
+                     AC_MSG_ERROR([invalid config option])
+                     ;;
+                 esac
+              ]
+             )
+])
+
 dnl OVS_CHECK_ODP_PLATFORM
 dnl
 dnl Configure ODP platform
@@ -272,7 +301,7 @@  AC_DEFUN([OVS_CHECK_ODP], [
 
                  AC_SUBST([ODP_INCLUDE])
                  AC_SUBST([ODP_LIB_DIR])
-                 CFLAGS="$CFLAGS -I$ODP_INCLUDE -I$ODPH_INCLUDE"
+                 CFLAGS="$CFLAGS -I$ODP_INCLUDE -I$ODPH_INCLUDE -DODP_DEBUG_PRINT=$ODP_DEBUG"
                  LDFLAGS="$LDFLAGS $SSL_LDFLAGS -L$ODP_LIB_DIR"
                    ;;
                  esac
diff --git a/configure.ac b/configure.ac
index e7be627..4cdbd75 100644
--- a/configure.ac
+++ b/configure.ac
@@ -120,6 +120,7 @@  AC_ARG_VAR(KARCH, [Kernel Architecture String])
 AC_SUBST(KARCH)
 OVS_CHECK_LINUX
 OVS_CHECK_DPDK
+OVS_CHECK_ODP_DEBUG
 OVS_CHECK_ODP_PLATFORM
 OVS_CHECK_ODP