From patchwork Thu Oct 30 12:02:49 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 39831 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f197.google.com (mail-wi0-f197.google.com [209.85.212.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 6F9A7202FE for ; Thu, 30 Oct 2014 12:02:59 +0000 (UTC) Received: by mail-wi0-f197.google.com with SMTP id ex7sf3093985wid.0 for ; Thu, 30 Oct 2014 05:02:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=juyQwwmdVAFhcOYr3GBrSWAFs6OX03pUwXia9/dnLL8=; b=SrQJgOygJ3CApTcINGmacXoWidr0yrclMpk6qnPwhLbN+T5QEoWz6+xt0AGw2h76c9 WfbAz/bcD+ShNMBZOTsZmuHqsIHsYycQwZkddHDMPlbC+rVMtXrxx3FHlRpC/TWzhB6J Jlr9lpXGz6LA0LyjWyNZtS0kAadcGPjfV/ssLPR35O33dk/U1mWV+I4ZsKN8N+zJvHJO lT6b9WXv0oVHzZ12eraylkqrf37d2hRg23rZMpd92DvhfOjqWzSZ6sHMpCE1qv6jPKHf 4bDq3KQ/i8HlRSgJTV3OHMvecHBYMVs29mN3JyqUQLX348+0bdEpk0twAq6hghnm9HMA b5FA== X-Gm-Message-State: ALoCoQnhejLyAdvb653U8dL72psDjnT7ZGWxK/CULlFyXlcCtzXTWNq/2gzvMwwHMe0S/UnuyRro X-Received: by 10.112.170.167 with SMTP id an7mr2887530lbc.4.1414670578622; Thu, 30 Oct 2014 05:02:58 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.153.7.70 with SMTP id da6ls50532lad.72.gmail; Thu, 30 Oct 2014 05:02:58 -0700 (PDT) X-Received: by 10.112.11.201 with SMTP id s9mr18199126lbb.79.1414670577952; Thu, 30 Oct 2014 05:02:57 -0700 (PDT) Received: from mail-la0-f52.google.com (mail-la0-f52.google.com. [209.85.215.52]) by mx.google.com with ESMTPS id o3si11738307lag.29.2014.10.30.05.02.57 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 30 Oct 2014 05:02:57 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.52 as permitted sender) client-ip=209.85.215.52; Received: by mail-la0-f52.google.com with SMTP id pv20so2458721lab.11 for ; Thu, 30 Oct 2014 05:02:57 -0700 (PDT) X-Received: by 10.112.189.10 with SMTP id ge10mr18212402lbc.23.1414670577870; Thu, 30 Oct 2014 05:02:57 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.112.84.229 with SMTP id c5csp27807lbz; Thu, 30 Oct 2014 05:02:57 -0700 (PDT) X-Received: by 10.152.29.41 with SMTP id g9mr18605658lah.83.1414670577493; Thu, 30 Oct 2014 05:02:57 -0700 (PDT) Received: from mail-la0-f44.google.com (mail-la0-f44.google.com. [209.85.215.44]) by mx.google.com with ESMTPS id is3si11761745lac.11.2014.10.30.05.02.57 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 30 Oct 2014 05:02:57 -0700 (PDT) Received-SPF: pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.215.44 as permitted sender) client-ip=209.85.215.44; Received: by mail-la0-f44.google.com with SMTP id gf13so4276662lab.17 for ; Thu, 30 Oct 2014 05:02:57 -0700 (PDT) X-Received: by 10.152.9.129 with SMTP id z1mr8220609laa.14.1414670577297; Thu, 30 Oct 2014 05:02:57 -0700 (PDT) Received: from uffe-Latitude-E6430s.lan (90-231-160-185-no158.tbcn.telia.com. [90.231.160.185]) by mx.google.com with ESMTPSA id r1sm3123004lae.25.2014.10.30.05.02.54 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 30 Oct 2014 05:02:56 -0700 (PDT) From: Ulf Hansson To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , linux-pm@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Geert Uytterhoeven , Kevin Hilman , Alan Stern , Greg Kroah-Hartman , Tomasz Figa , Simon Horman , Magnus Damm , Ben Dooks , Kukjin Kim , Philipp Zabel , Mark Brown , Wolfram Sang , Russell King , Dmitry Torokhov , Jack Dai , Jinkun Hong , Aaron Lu , Sylwester Nawrocki , Ulf Hansson Subject: [PATCH] PM / Domains: Change prototype for the ->attach_dev() callback Date: Thu, 30 Oct 2014 13:02:49 +0100 Message-Id: <1414670569-3002-1-git-send-email-ulf.hansson@linaro.org> X-Mailer: git-send-email 1.9.1 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ulf.hansson@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.52 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Convert the prototype to return and int. This is just an initial step, needed to support error handling. Signed-off-by: Ulf Hansson Acked-by: Geert Uytterhoeven Acked-by: Pavel Machek Acked-by: Kevin Hilman Acked-by: Dmitry Torokhov Acked-by: Geert Uytterhoeven --- This patch is intended as fix for 3.18 rc[n]. Why? There are other SOC specific patches around that adds genpd support and which implements the ->attach_dev() callback. To prevent having an "atomic" patch during the next release cycle, let's change the prototype now instead. Further patches will add the actual error handling in genpd and these can then be reviewed and tested thoroughly. --- include/linux/pm_domain.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h index 73e938b..d44f071 100644 --- a/include/linux/pm_domain.h +++ b/include/linux/pm_domain.h @@ -72,7 +72,7 @@ struct generic_pm_domain { bool max_off_time_changed; bool cached_power_down_ok; struct gpd_cpuidle_data *cpuidle_data; - void (*attach_dev)(struct device *dev); + int (*attach_dev)(struct device *dev); void (*detach_dev)(struct device *dev); };