diff mbox series

[v1,07/14] plugins: expand the typedef kernel-docs for translation

Message ID 20210312172821.31647-8-alex.bennee@linaro.org
State New
Headers show
Series plugins/next (phys addr, syscalls, lots of docs) | expand

Commit Message

Alex Bennée March 12, 2021, 5:28 p.m. UTC
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
 include/qemu/qemu-plugin.h | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

-- 
2.20.1

Comments

Xingtao Yao (Fujitsu)" via March 12, 2021, 6:27 p.m. UTC | #1
On Mar 12 17:28, Alex Bennée wrote:
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>


Reviewed-by: Aaron Lindsay <aaron@os.amperecomputing.com>


> ---

>  include/qemu/qemu-plugin.h | 17 ++++++++++-------

>  1 file changed, 10 insertions(+), 7 deletions(-)

> 

> diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h

> index 09b235f0b4..9ae3940d89 100644

> --- a/include/qemu/qemu-plugin.h

> +++ b/include/qemu/qemu-plugin.h

> @@ -202,11 +202,9 @@ void qemu_plugin_register_vcpu_idle_cb(qemu_plugin_id_t id,

>  void qemu_plugin_register_vcpu_resume_cb(qemu_plugin_id_t id,

>                                           qemu_plugin_vcpu_simple_cb_t cb);

>  

> -/*

> - * Opaque types that the plugin is given during the translation and

> - * instrumentation phase.

> - */

> +/** struct qemu_plugin_tb - Opaque handle for a translation block */

>  struct qemu_plugin_tb;

> +/** struct qemu_plugin_insn - Opaque handle for a translated instruction */

>  struct qemu_plugin_insn;

>  

>  enum qemu_plugin_cb_flags {

> @@ -221,6 +219,14 @@ enum qemu_plugin_mem_rw {

>      QEMU_PLUGIN_MEM_RW,

>  };

>  

> +/**

> + * typedef qemu_plugin_vcpu_tb_trans_cb_t - translation callback

> + * @id: unique plugin id

> + * @tb: opaque handle used for querying and instrumenting a block.

> + */

> +typedef void (*qemu_plugin_vcpu_tb_trans_cb_t)(qemu_plugin_id_t id,

> +                                               struct qemu_plugin_tb *tb);

> +

>  /**

>   * qemu_plugin_register_vcpu_tb_trans_cb() - register a translate cb

>   * @id: plugin ID

> @@ -233,9 +239,6 @@ enum qemu_plugin_mem_rw {

>   * callbacks to be triggered when the block or individual instruction

>   * executes.

>   */

> -typedef void (*qemu_plugin_vcpu_tb_trans_cb_t)(qemu_plugin_id_t id,

> -                                               struct qemu_plugin_tb *tb);

> -

>  void qemu_plugin_register_vcpu_tb_trans_cb(qemu_plugin_id_t id,

>                                             qemu_plugin_vcpu_tb_trans_cb_t cb);

>  

> -- 

> 2.20.1

>
diff mbox series

Patch

diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h
index 09b235f0b4..9ae3940d89 100644
--- a/include/qemu/qemu-plugin.h
+++ b/include/qemu/qemu-plugin.h
@@ -202,11 +202,9 @@  void qemu_plugin_register_vcpu_idle_cb(qemu_plugin_id_t id,
 void qemu_plugin_register_vcpu_resume_cb(qemu_plugin_id_t id,
                                          qemu_plugin_vcpu_simple_cb_t cb);
 
-/*
- * Opaque types that the plugin is given during the translation and
- * instrumentation phase.
- */
+/** struct qemu_plugin_tb - Opaque handle for a translation block */
 struct qemu_plugin_tb;
+/** struct qemu_plugin_insn - Opaque handle for a translated instruction */
 struct qemu_plugin_insn;
 
 enum qemu_plugin_cb_flags {
@@ -221,6 +219,14 @@  enum qemu_plugin_mem_rw {
     QEMU_PLUGIN_MEM_RW,
 };
 
+/**
+ * typedef qemu_plugin_vcpu_tb_trans_cb_t - translation callback
+ * @id: unique plugin id
+ * @tb: opaque handle used for querying and instrumenting a block.
+ */
+typedef void (*qemu_plugin_vcpu_tb_trans_cb_t)(qemu_plugin_id_t id,
+                                               struct qemu_plugin_tb *tb);
+
 /**
  * qemu_plugin_register_vcpu_tb_trans_cb() - register a translate cb
  * @id: plugin ID
@@ -233,9 +239,6 @@  enum qemu_plugin_mem_rw {
  * callbacks to be triggered when the block or individual instruction
  * executes.
  */
-typedef void (*qemu_plugin_vcpu_tb_trans_cb_t)(qemu_plugin_id_t id,
-                                               struct qemu_plugin_tb *tb);
-
 void qemu_plugin_register_vcpu_tb_trans_cb(qemu_plugin_id_t id,
                                            qemu_plugin_vcpu_tb_trans_cb_t cb);