[v1/1] linux-generic : crypto

Message ID 1414757220-32274-1-git-send-email-alexandru.badicioiu@linaro.org
State New
Headers show

Commit Message

Alexandru Badicioiu Oct. 31, 2014, 12:07 p.m.
From: Alexandru Badicioiu <alexandru.badicioiu@linaro.org>

Add missing API functions to crypto implementation.
Required by crypto unit testing.

Signed-off-by: Alexandru Badicioiu <alexandru.badicioiu@linaro.org>
---
 platform/linux-generic/odp_crypto.c |   26 ++++++++++++++++++++++++++
 1 files changed, 26 insertions(+), 0 deletions(-)

Comments

Mike Holmes Oct. 31, 2014, 12:34 p.m. | #1
On 31 October 2014 08:07, <alexandru.badicioiu@linaro.org> wrote:

> From: Alexandru Badicioiu <alexandru.badicioiu@linaro.org>
>
> Add missing API functions to crypto implementation.
> Required by crypto unit testing.
>
> Signed-off-by: Alexandru Badicioiu <alexandru.badicioiu@linaro.org>
> ---
>  platform/linux-generic/odp_crypto.c |   26 ++++++++++++++++++++++++++
>  1 files changed, 26 insertions(+), 0 deletions(-)
>
> diff --git a/platform/linux-generic/odp_crypto.c
> b/platform/linux-generic/odp_crypto.c
> index 1475437..b9dd3e7 100644
> --- a/platform/linux-generic/odp_crypto.c
> +++ b/platform/linux-generic/odp_crypto.c
> @@ -13,6 +13,7 @@
>  #include <odp_align.h>
>  #include <odp_shared_memory.h>
>  #include <odp_crypto_internal.h>
> +#include <odp_debug_internal.h>
>  #include <odp_hints.h>
>  #include <odph_packet.h>
>
> @@ -467,3 +468,28 @@ odp_crypto_get_ses_create_compl_session(odp_buffer_t
> completion_event,
>         result = odp_buffer_addr(completion_event);
>         *session = result->session;
>  }
> +
> +void
> +odp_crypto_set_operation_compl_ctx(odp_buffer_t completion_event,
> +                                  void *ctx)
> +{
> +       (void)completion_event;
>

I assume this is to remove the unused error at compile time,  ODP_UNUSED in
the argument list to the function is the way we have handled that else where


> +       (void)ctx;
> +       ODP_UNIMPLEMENTED();
> +}
> +
> +void
> +*odp_crypto_get_operation_compl_ctx(odp_buffer_t completion_event)
> +{
> +       (void)completion_event;
> +       ODP_UNIMPLEMENTED();
> +       return NULL;
> +}
> +
> +odp_packet_t
> +odp_crypto_get_operation_compl_packet(odp_buffer_t completion_event)
> +{
> +       (void)completion_event;
> +       ODP_UNIMPLEMENTED();
> +       return ODP_PACKET_INVALID;
> +}
> --
> 1.7.3.4
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
>
Alexandru Badicioiu Oct. 31, 2014, 12:44 p.m. | #2
This patch is to avoid link error for previously submitted crypto tests.
The tests use these calls and they are not implemented by linux-generic.

On 31 October 2014 14:34, Mike Holmes <mike.holmes@linaro.org> wrote:

>
>
> On 31 October 2014 08:07, <alexandru.badicioiu@linaro.org> wrote:
>
>> From: Alexandru Badicioiu <alexandru.badicioiu@linaro.org>
>>
>> Add missing API functions to crypto implementation.
>> Required by crypto unit testing.
>>
>> Signed-off-by: Alexandru Badicioiu <alexandru.badicioiu@linaro.org>
>> ---
>>  platform/linux-generic/odp_crypto.c |   26 ++++++++++++++++++++++++++
>>  1 files changed, 26 insertions(+), 0 deletions(-)
>>
>> diff --git a/platform/linux-generic/odp_crypto.c
>> b/platform/linux-generic/odp_crypto.c
>> index 1475437..b9dd3e7 100644
>> --- a/platform/linux-generic/odp_crypto.c
>> +++ b/platform/linux-generic/odp_crypto.c
>> @@ -13,6 +13,7 @@
>>  #include <odp_align.h>
>>  #include <odp_shared_memory.h>
>>  #include <odp_crypto_internal.h>
>> +#include <odp_debug_internal.h>
>>  #include <odp_hints.h>
>>  #include <odph_packet.h>
>>
>> @@ -467,3 +468,28 @@ odp_crypto_get_ses_create_compl_session(odp_buffer_t
>> completion_event,
>>         result = odp_buffer_addr(completion_event);
>>         *session = result->session;
>>  }
>> +
>> +void
>> +odp_crypto_set_operation_compl_ctx(odp_buffer_t completion_event,
>> +                                  void *ctx)
>> +{
>> +       (void)completion_event;
>>
>
> I assume this is to remove the unused error at compile time,  ODP_UNUSED
> in the argument list to the function is the way we have handled that else
> where
>
>
>> +       (void)ctx;
>> +       ODP_UNIMPLEMENTED();
>> +}
>> +
>> +void
>> +*odp_crypto_get_operation_compl_ctx(odp_buffer_t completion_event)
>> +{
>> +       (void)completion_event;
>> +       ODP_UNIMPLEMENTED();
>> +       return NULL;
>> +}
>> +
>> +odp_packet_t
>> +odp_crypto_get_operation_compl_packet(odp_buffer_t completion_event)
>> +{
>> +       (void)completion_event;
>> +       ODP_UNIMPLEMENTED();
>> +       return ODP_PACKET_INVALID;
>> +}
>> --
>> 1.7.3.4
>>
>>
>> _______________________________________________
>> lng-odp mailing list
>> lng-odp@lists.linaro.org
>> http://lists.linaro.org/mailman/listinfo/lng-odp
>>
>
>
>
> --
> *Mike Holmes*
> Linaro  Sr Technical Manager
> LNG - ODP
>

Patch

diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c
index 1475437..b9dd3e7 100644
--- a/platform/linux-generic/odp_crypto.c
+++ b/platform/linux-generic/odp_crypto.c
@@ -13,6 +13,7 @@ 
 #include <odp_align.h>
 #include <odp_shared_memory.h>
 #include <odp_crypto_internal.h>
+#include <odp_debug_internal.h>
 #include <odp_hints.h>
 #include <odph_packet.h>
 
@@ -467,3 +468,28 @@  odp_crypto_get_ses_create_compl_session(odp_buffer_t completion_event,
 	result = odp_buffer_addr(completion_event);
 	*session = result->session;
 }
+
+void
+odp_crypto_set_operation_compl_ctx(odp_buffer_t completion_event,
+				   void *ctx)
+{
+	(void)completion_event;
+	(void)ctx;
+	ODP_UNIMPLEMENTED();
+}
+
+void
+*odp_crypto_get_operation_compl_ctx(odp_buffer_t completion_event)
+{
+	(void)completion_event;
+	ODP_UNIMPLEMENTED();
+	return NULL;
+}
+
+odp_packet_t
+odp_crypto_get_operation_compl_packet(odp_buffer_t completion_event)
+{
+	(void)completion_event;
+	ODP_UNIMPLEMENTED();
+	return ODP_PACKET_INVALID;
+}