| Message ID | 20210315185141.18013-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | e5391a02bce2422fa57a520dfaaf2693ec7f9546 |
| Headers | show |
| Series | [v1,1/1] gpio: mockup: Drop duplicate NULL check in gpio_mockup_unregister_pdevs() | expand |
On Mon, Mar 15, 2021 at 7:51 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > Since platform_device_unregister() is NULL-aware, we don't need to duplicate > this check. Remove it and fold the rest of the code. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/gpio/gpio-mockup.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c > index 28b757d34046..d7e73876a3b9 100644 > --- a/drivers/gpio/gpio-mockup.c > +++ b/drivers/gpio/gpio-mockup.c > @@ -479,15 +479,10 @@ static struct platform_device *gpio_mockup_pdevs[GPIO_MOCKUP_MAX_GC]; > > static void gpio_mockup_unregister_pdevs(void) > { > - struct platform_device *pdev; > int i; > > - for (i = 0; i < GPIO_MOCKUP_MAX_GC; i++) { > - pdev = gpio_mockup_pdevs[i]; > - > - if (pdev) > - platform_device_unregister(pdev); > - } > + for (i = 0; i < GPIO_MOCKUP_MAX_GC; i++) > + platform_device_unregister(gpio_mockup_pdevs[i]); > } > > static __init char **gpio_mockup_make_line_names(const char *label, > -- > 2.30.2 > Applied, thanks! Bartosz
diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c index 28b757d34046..d7e73876a3b9 100644 --- a/drivers/gpio/gpio-mockup.c +++ b/drivers/gpio/gpio-mockup.c @@ -479,15 +479,10 @@ static struct platform_device *gpio_mockup_pdevs[GPIO_MOCKUP_MAX_GC]; static void gpio_mockup_unregister_pdevs(void) { - struct platform_device *pdev; int i; - for (i = 0; i < GPIO_MOCKUP_MAX_GC; i++) { - pdev = gpio_mockup_pdevs[i]; - - if (pdev) - platform_device_unregister(pdev); - } + for (i = 0; i < GPIO_MOCKUP_MAX_GC; i++) + platform_device_unregister(gpio_mockup_pdevs[i]); } static __init char **gpio_mockup_make_line_names(const char *label,
Since platform_device_unregister() is NULL-aware, we don't need to duplicate this check. Remove it and fold the rest of the code. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/gpio/gpio-mockup.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-)