[1/3] lsb 4.1: Deal with "make clean" breakage

Message ID 1415108447-16821-1-git-send-email-koen.kooi@linaro.org
State New
Headers show

Commit Message

Koen Kooi Nov. 4, 2014, 1:40 p.m.
LSB can't cope with a "make clean" so disable that
newly enabled functionality.

Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
---
 meta/recipes-extended/lsb/lsb_4.1.bb | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Richard Purdie Nov. 5, 2014, 10:48 a.m. | #1
On Tue, 2014-11-04 at 14:40 +0100, Koen Kooi wrote:
> LSB can't cope with a "make clean" so disable that
> newly enabled functionality.
> 
> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
> ---
>  meta/recipes-extended/lsb/lsb_4.1.bb | 6 ++++++
>  1 file changed, 6 insertions(+)

In the interests of being clear and transparent, there are issues with
the clean change and I think we need a better mechanism for controlling
this. I've a patch in progress which introduces a CLEANBROKEN variable
which can be set in recipes where "make clean" is broken.

I have a list of several other recipes with the issue and am working on
pulling together a list/patch.

Cheers,

Richard


> diff --git a/meta/recipes-extended/lsb/lsb_4.1.bb b/meta/recipes-extended/lsb/lsb_4.1.bb
> index d265731..34a70d0 100644
> --- a/meta/recipes-extended/lsb/lsb_4.1.bb
> +++ b/meta/recipes-extended/lsb/lsb_4.1.bb
> @@ -21,6 +21,12 @@ SRC_URI[md5sum] = "30537ef5a01e0ca94b7b8eb6a36bb1e4"
>  SRC_URI[sha256sum] = "99321288f8d62e7a1d485b7c6bdccf06766fb8ca603c6195806e4457fdf17172"
>  S = "${WORKDIR}/lsb-release-1.4"
>  
> +# 'make clean' isn't supported
> +
> +do_configure() {
> +	:
> +}
> +
>  do_install(){
>  	oe_runmake install prefix=${D}  mandir=${D}/${datadir}/man/ DESTDIR=${D}
>  
> -- 
> 1.9.3
>

Patch

diff --git a/meta/recipes-extended/lsb/lsb_4.1.bb b/meta/recipes-extended/lsb/lsb_4.1.bb
index d265731..34a70d0 100644
--- a/meta/recipes-extended/lsb/lsb_4.1.bb
+++ b/meta/recipes-extended/lsb/lsb_4.1.bb
@@ -21,6 +21,12 @@  SRC_URI[md5sum] = "30537ef5a01e0ca94b7b8eb6a36bb1e4"
 SRC_URI[sha256sum] = "99321288f8d62e7a1d485b7c6bdccf06766fb8ca603c6195806e4457fdf17172"
 S = "${WORKDIR}/lsb-release-1.4"
 
+# 'make clean' isn't supported
+
+do_configure() {
+	:
+}
+
 do_install(){
 	oe_runmake install prefix=${D}  mandir=${D}/${datadir}/man/ DESTDIR=${D}