| Message ID | 1415295366-593-2-git-send-email-balbi@ti.com |
|---|---|
| State | Accepted |
| Commit | 60f0e628c9940dc59463e986ddfa2c9e74ea89bb |
| Headers | show |
* Felipe Balbi <balbi@ti.com> [141106 09:40]: > Whenever Suspend PHY bit is set on AM437x devices, > USB will not work due to Set EP Configuration command > always failing. > > This was only found after a recent commit 2164a47 (usb: > dwc3: set SUSPHY bit for all cores, which will be merged > for v3.19) added a missing *required* step to dwc3 > initialization. Synopsys Databook requires that we enable > Suspend PHY bit after initialization but that, unfortunately, > breaks AM437x. > > Signed-off-by: Felipe Balbi <balbi@ti.com> This should be safe to queue along with the related USB changes: Acked-by: Tony Lindgren <tony@atomide.com> > --- > arch/arm/boot/dts/am4372.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi > index 46660ff..e19068d 100644 > --- a/arch/arm/boot/dts/am4372.dtsi > +++ b/arch/arm/boot/dts/am4372.dtsi > @@ -817,6 +817,8 @@ > maximum-speed = "high-speed"; > dr_mode = "otg"; > status = "disabled"; > + snps,dis_u3_susphy_quirk; > + snps,dis_u2_susphy_quirk; > }; > }; > > @@ -839,6 +841,8 @@ > maximum-speed = "high-speed"; > dr_mode = "otg"; > status = "disabled"; > + snps,dis_u3_susphy_quirk; > + snps,dis_u2_susphy_quirk; > }; > }; > > -- > 2.1.0.GIT > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi index 46660ff..e19068d 100644 --- a/arch/arm/boot/dts/am4372.dtsi +++ b/arch/arm/boot/dts/am4372.dtsi @@ -817,6 +817,8 @@ maximum-speed = "high-speed"; dr_mode = "otg"; status = "disabled"; + snps,dis_u3_susphy_quirk; + snps,dis_u2_susphy_quirk; }; }; @@ -839,6 +841,8 @@ maximum-speed = "high-speed"; dr_mode = "otg"; status = "disabled"; + snps,dis_u3_susphy_quirk; + snps,dis_u2_susphy_quirk; }; };
Whenever Suspend PHY bit is set on AM437x devices, USB will not work due to Set EP Configuration command always failing. This was only found after a recent commit 2164a47 (usb: dwc3: set SUSPHY bit for all cores, which will be merged for v3.19) added a missing *required* step to dwc3 initialization. Synopsys Databook requires that we enable Suspend PHY bit after initialization but that, unfortunately, breaks AM437x. Signed-off-by: Felipe Balbi <balbi@ti.com> --- arch/arm/boot/dts/am4372.dtsi | 4 ++++ 1 file changed, 4 insertions(+)