[v3,3/3] exynos: Increase command line buffer size (CONFIG_SYS_CBSIZE)

Message ID 1415529873-1510-3-git-send-email-ijc@hellion.org.uk
State Accepted
Commit cf3c03b173038c51c19b1d871f225fc0c62f2a85
Headers show

Commit Message

Ian Campbell Nov. 9, 2014, 10:44 a.m.
From: Ian Campbell <ian.campbell@citrix.com>

I was running into this limit with a not overly long PXE append line.

Since the PXE code wants to print the resulting command line increase
CONFIG_SYS_PBSIZE too.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
v2: Apply to exynos generally since consolidation.
---
 include/configs/exynos-common.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Simon Glass Nov. 10, 2014, 3:46 p.m. | #1
On 9 November 2014 03:44, Ian Campbell <ijc@hellion.org.uk> wrote:
> From: Ian Campbell <ian.campbell@citrix.com>
>
> I was running into this limit with a not overly long PXE append line.
>
> Since the PXE code wants to print the resulting command line increase
> CONFIG_SYS_PBSIZE too.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

Acked-by: Simon Glass <sjg@chromium.org>
Fabio Estevam Nov. 10, 2014, 3:50 p.m. | #2
On Sun, Nov 9, 2014 at 8:44 AM, Ian Campbell <ijc@hellion.org.uk> wrote:

>  /* Miscellaneous configurable options */
> -#define CONFIG_SYS_CBSIZE              256     /* Console I/O Buffer Size */
> -#define CONFIG_SYS_PBSIZE              384     /* Print Buffer Size */
> +#define CONFIG_SYS_CBSIZE              1024    /* Console I/O Buffer Size */
> +#define CONFIG_SYS_PBSIZE              1024    /* Print Buffer Size */
>  #define CONFIG_SYS_MAXARGS             16      /* max number of command args */

What if we add a default definition like this:

#define CONFIG_SYS_CBSIZE              1024    /* Console I/O Buffer Size */
#define CONFIG_SYS_PBSIZE              1024    /* Print Buffer Size */

,then if CONFIG_SYS_CBSIZE and CONFIG_SYS_PBSIZE are not defined in
the board file, we just use the default?

I had the same issue sometime ago and I am wondering if this could be
a better way to handle it.

Patch

diff --git a/include/configs/exynos-common.h b/include/configs/exynos-common.h
index 1246305..1f3ee55 100644
--- a/include/configs/exynos-common.h
+++ b/include/configs/exynos-common.h
@@ -74,8 +74,8 @@ 
 #define CONFIG_PARTITION_UUIDS
 
 /* Miscellaneous configurable options */
-#define CONFIG_SYS_CBSIZE		256	/* Console I/O Buffer Size */
-#define CONFIG_SYS_PBSIZE		384	/* Print Buffer Size */
+#define CONFIG_SYS_CBSIZE		1024	/* Console I/O Buffer Size */
+#define CONFIG_SYS_PBSIZE		1024	/* Print Buffer Size */
 #define CONFIG_SYS_MAXARGS		16	/* max number of command args */
 
 /* Boot Argument Buffer Size */