| Message ID | 1616412093-144386-1-git-send-email-dj0227@163.com |
|---|---|
| State | New |
| Headers | show |
| Series | power-supply: Use IRQF_ONESHOT | expand |
Hi, On Mon, Mar 22, 2021 at 07:21:33PM +0800, Jian Dong wrote: > From: dongjian <dongjian@yulong.com> > > Fixes coccicheck error: > > drivers/power/supply/pm2301_charger.c:1089:7-27: ERROR: > drivers/power/supply/lp8788-charger.c:502:8-28: ERROR: > drivers/power/supply/tps65217_charger.c:239:8-33: ERROR: > drivers/power/supply/tps65090-charger.c:303:8-33: ERROR: > > Threaded IRQ with no primary handler requested without IRQF_ONESHOT > > Signed-off-by: dongjian <dongjian@yulong.com> > --- Thanks, queued. -- Sebastian > drivers/power/supply/lp8788-charger.c | 2 +- > drivers/power/supply/pm2301_charger.c | 2 +- > drivers/power/supply/tps65090-charger.c | 2 +- > drivers/power/supply/tps65217_charger.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/power/supply/lp8788-charger.c b/drivers/power/supply/lp8788-charger.c > index e7931ff..397e5a0 100644 > --- a/drivers/power/supply/lp8788-charger.c > +++ b/drivers/power/supply/lp8788-charger.c > @@ -501,7 +501,7 @@ static int lp8788_set_irqs(struct platform_device *pdev, > > ret = request_threaded_irq(virq, NULL, > lp8788_charger_irq_thread, > - 0, name, pchg); > + IRQF_ONESHOT, name, pchg); > if (ret) > break; > } > diff --git a/drivers/power/supply/pm2301_charger.c b/drivers/power/supply/pm2301_charger.c > index ac06ecf..a3bfb96 100644 > --- a/drivers/power/supply/pm2301_charger.c > +++ b/drivers/power/supply/pm2301_charger.c > @@ -1089,7 +1089,7 @@ static int pm2xxx_wall_charger_probe(struct i2c_client *i2c_client, > ret = request_threaded_irq(gpio_to_irq(pm2->pdata->gpio_irq_number), > NULL, > pm2xxx_charger_irq[0].isr, > - pm2->pdata->irq_type, > + pm2->pdata->irq_type | IRQF_ONESHOT, > pm2xxx_charger_irq[0].name, pm2); > > if (ret != 0) { > diff --git a/drivers/power/supply/tps65090-charger.c b/drivers/power/supply/tps65090-charger.c > index 6b0098e..0990b2f 100644 > --- a/drivers/power/supply/tps65090-charger.c > +++ b/drivers/power/supply/tps65090-charger.c > @@ -301,7 +301,7 @@ static int tps65090_charger_probe(struct platform_device *pdev) > > if (irq != -ENXIO) { > ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, > - tps65090_charger_isr, 0, "tps65090-charger", cdata); > + tps65090_charger_isr, IRQF_ONESHOT, "tps65090-charger", cdata); > if (ret) { > dev_err(cdata->dev, > "Unable to register irq %d err %d\n", irq, > diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps65217_charger.c > index 814c2b8..ba33d16 100644 > --- a/drivers/power/supply/tps65217_charger.c > +++ b/drivers/power/supply/tps65217_charger.c > @@ -238,7 +238,7 @@ static int tps65217_charger_probe(struct platform_device *pdev) > for (i = 0; i < NUM_CHARGER_IRQS; i++) { > ret = devm_request_threaded_irq(&pdev->dev, irq[i], NULL, > tps65217_charger_irq, > - 0, "tps65217-charger", > + IRQF_ONESHOT, "tps65217-charger", > charger); > if (ret) { > dev_err(charger->dev, > -- > 1.9.1 > >
diff --git a/drivers/power/supply/lp8788-charger.c b/drivers/power/supply/lp8788-charger.c index e7931ff..397e5a0 100644 --- a/drivers/power/supply/lp8788-charger.c +++ b/drivers/power/supply/lp8788-charger.c @@ -501,7 +501,7 @@ static int lp8788_set_irqs(struct platform_device *pdev, ret = request_threaded_irq(virq, NULL, lp8788_charger_irq_thread, - 0, name, pchg); + IRQF_ONESHOT, name, pchg); if (ret) break; } diff --git a/drivers/power/supply/pm2301_charger.c b/drivers/power/supply/pm2301_charger.c index ac06ecf..a3bfb96 100644 --- a/drivers/power/supply/pm2301_charger.c +++ b/drivers/power/supply/pm2301_charger.c @@ -1089,7 +1089,7 @@ static int pm2xxx_wall_charger_probe(struct i2c_client *i2c_client, ret = request_threaded_irq(gpio_to_irq(pm2->pdata->gpio_irq_number), NULL, pm2xxx_charger_irq[0].isr, - pm2->pdata->irq_type, + pm2->pdata->irq_type | IRQF_ONESHOT, pm2xxx_charger_irq[0].name, pm2); if (ret != 0) { diff --git a/drivers/power/supply/tps65090-charger.c b/drivers/power/supply/tps65090-charger.c index 6b0098e..0990b2f 100644 --- a/drivers/power/supply/tps65090-charger.c +++ b/drivers/power/supply/tps65090-charger.c @@ -301,7 +301,7 @@ static int tps65090_charger_probe(struct platform_device *pdev) if (irq != -ENXIO) { ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, - tps65090_charger_isr, 0, "tps65090-charger", cdata); + tps65090_charger_isr, IRQF_ONESHOT, "tps65090-charger", cdata); if (ret) { dev_err(cdata->dev, "Unable to register irq %d err %d\n", irq, diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps65217_charger.c index 814c2b8..ba33d16 100644 --- a/drivers/power/supply/tps65217_charger.c +++ b/drivers/power/supply/tps65217_charger.c @@ -238,7 +238,7 @@ static int tps65217_charger_probe(struct platform_device *pdev) for (i = 0; i < NUM_CHARGER_IRQS; i++) { ret = devm_request_threaded_irq(&pdev->dev, irq[i], NULL, tps65217_charger_irq, - 0, "tps65217-charger", + IRQF_ONESHOT, "tps65217-charger", charger); if (ret) { dev_err(charger->dev,