diff mbox series

[v2,1/3] dt-bindings: serial: amlogic,meson-uart: add fifo-size property

Message ID 20210325152410.1795557-2-narmstrong@baylibre.com
State Superseded
Headers show
Series [v2,1/3] dt-bindings: serial: amlogic,meson-uart: add fifo-size property | expand

Commit Message

Neil Armstrong March 25, 2021, 3:24 p.m. UTC
On most of the Amlogic SoCs, the first UART controller in the "Everything-Else"
power domain has 128bytes of RX & TX FIFO, so add an optional property to describe
a different FIFO size from the other ports (64bytes).

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
 .../devicetree/bindings/serial/amlogic,meson-uart.yaml      | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Neil Armstrong April 26, 2021, 6:06 p.m. UTC | #1
Hi Rob,

On 25/03/2021 16:24, Neil Armstrong wrote:
> On most of the Amlogic SoCs, the first UART controller in the "Everything-Else"

> power domain has 128bytes of RX & TX FIFO, so add an optional property to describe

> a different FIFO size from the other ports (64bytes).

> 

> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

> ---

>  .../devicetree/bindings/serial/amlogic,meson-uart.yaml      | 6 ++++++

>  1 file changed, 6 insertions(+)

> 

> diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml

> index 75ebc9952a99..8ece7f420c19 100644

> --- a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml

> +++ b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml

> @@ -55,6 +55,12 @@ properties:

>        - const: pclk

>        - const: baud

>  

> +

> +  fifo-size:

> +    description: The fifo size supported by the UART channel.

> +    $ref: /schemas/types.yaml#/definitions/uint32

> +    enum: [64, 128]

> +

>  required:

>    - compatible

>    - reg

> 



Is it ok with the generic fifo-size property ?

Neil
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
index 75ebc9952a99..8ece7f420c19 100644
--- a/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/amlogic,meson-uart.yaml
@@ -55,6 +55,12 @@  properties:
       - const: pclk
       - const: baud
 
+
+  fifo-size:
+    description: The fifo size supported by the UART channel.
+    $ref: /schemas/types.yaml#/definitions/uint32
+    enum: [64, 128]
+
 required:
   - compatible
   - reg