| Message ID | 20210326215927.936377-10-pierre-louis.bossart@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | 00a820086ddd8c6f3eeeca3a034d234cebf084ba |
| Headers | show |
| Series | ASoC: remove cppcheck warnings for multiple SOCs | expand |
Hi, > -----Original Message----- > From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > Sent: vendredi 26 mars 2021 22:59 > To: alsa-devel@alsa-project.org > Cc: tiwai@suse.de; broonie@kernel.org; linux-kernel@vger.kernel.org; Pierre- > Louis Bossart <pierre-louis.bossart@linux.intel.com>; Arnaud POULIQUEN > <arnaud.pouliquen@st.com>; Liam Girdwood <lgirdwood@gmail.com>; > Jaroslav Kysela <perex@perex.cz>; Takashi Iwai <tiwai@suse.com> > Subject: [PATCH 09/17] ASoC: sti: uniperif: align function prototypes > > cppcheck warning: > > sound/soc/sti/uniperif_player.c:1049:24: style:inconclusive: Function > 'uni_player_init' argument 2 names different: declaration 'uni_player' > definition 'player'. [funcArgNamesDifferent] > struct uniperif *player) > ^ > sound/soc/sti/uniperif.h:1375:24: note: Function 'uni_player_init' > argument 2 names different: declaration 'uni_player' definition 'player'. > struct uniperif *uni_player); > ^ > sound/soc/sti/uniperif_player.c:1049:24: note: Function 'uni_player_init' > argument 2 names different: declaration 'uni_player' > definition 'player'. > struct uniperif *player) > ^ > sound/soc/sti/uniperif_reader.c:411:24: style:inconclusive: Function > 'uni_reader_init' argument 2 names different: declaration 'uni_reader' > definition 'reader'. [funcArgNamesDifferent] > struct uniperif *reader) > ^ > sound/soc/sti/uniperif.h:1380:24: note: Function 'uni_reader_init' > argument 2 names different: declaration 'uni_reader' definition 'reader'. > struct uniperif *uni_reader); > ^ > sound/soc/sti/uniperif_reader.c:411:24: note: Function 'uni_reader_init' > argument 2 names different: declaration 'uni_reader' > definition 'reader'. > struct uniperif *reader) > ^ > > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@st.com> Thanks Arnaud > --- > sound/soc/sti/uniperif.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/sti/uniperif.h b/sound/soc/sti/uniperif.h index > a16adeb7c1e9..2a5de328501c 100644 > --- a/sound/soc/sti/uniperif.h > +++ b/sound/soc/sti/uniperif.h > @@ -1372,12 +1372,12 @@ static __maybe_unused const struct > snd_pcm_hardware uni_tdm_hw = { > > /* uniperiph player*/ > int uni_player_init(struct platform_device *pdev, > - struct uniperif *uni_player); > + struct uniperif *player); > int uni_player_resume(struct uniperif *player); > > /* uniperiph reader */ > int uni_reader_init(struct platform_device *pdev, > - struct uniperif *uni_reader); > + struct uniperif *reader); > > /* common */ > int sti_uniperiph_dai_set_fmt(struct snd_soc_dai *dai, > -- > 2.25.1
diff --git a/sound/soc/sti/uniperif.h b/sound/soc/sti/uniperif.h index a16adeb7c1e9..2a5de328501c 100644 --- a/sound/soc/sti/uniperif.h +++ b/sound/soc/sti/uniperif.h @@ -1372,12 +1372,12 @@ static __maybe_unused const struct snd_pcm_hardware uni_tdm_hw = { /* uniperiph player*/ int uni_player_init(struct platform_device *pdev, - struct uniperif *uni_player); + struct uniperif *player); int uni_player_resume(struct uniperif *player); /* uniperiph reader */ int uni_reader_init(struct platform_device *pdev, - struct uniperif *uni_reader); + struct uniperif *reader); /* common */ int sti_uniperiph_dai_set_fmt(struct snd_soc_dai *dai,
cppcheck warning: sound/soc/sti/uniperif_player.c:1049:24: style:inconclusive: Function 'uni_player_init' argument 2 names different: declaration 'uni_player' definition 'player'. [funcArgNamesDifferent] struct uniperif *player) ^ sound/soc/sti/uniperif.h:1375:24: note: Function 'uni_player_init' argument 2 names different: declaration 'uni_player' definition 'player'. struct uniperif *uni_player); ^ sound/soc/sti/uniperif_player.c:1049:24: note: Function 'uni_player_init' argument 2 names different: declaration 'uni_player' definition 'player'. struct uniperif *player) ^ sound/soc/sti/uniperif_reader.c:411:24: style:inconclusive: Function 'uni_reader_init' argument 2 names different: declaration 'uni_reader' definition 'reader'. [funcArgNamesDifferent] struct uniperif *reader) ^ sound/soc/sti/uniperif.h:1380:24: note: Function 'uni_reader_init' argument 2 names different: declaration 'uni_reader' definition 'reader'. struct uniperif *uni_reader); ^ sound/soc/sti/uniperif_reader.c:411:24: note: Function 'uni_reader_init' argument 2 names different: declaration 'uni_reader' definition 'reader'. struct uniperif *reader) ^ Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> --- sound/soc/sti/uniperif.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)