diff mbox series

arm64: dts: imx8mp-evk: Add i2c bus driving the PMIC

Message ID 20210326142459.30679-1-u.kleine-koenig@pengutronix.de
State New
Headers show
Series arm64: dts: imx8mp-evk: Add i2c bus driving the PMIC | expand

Commit Message

Uwe Kleine-König March 26, 2021, 2:24 p.m. UTC
There is no binding and driver for the PMIC itself, but making the bus
available allows to access its registers using i2c-tools at least.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

Comments

Fabio Estevam March 26, 2021, 6:26 p.m. UTC | #1
Hi Uwe,

On Fri, Mar 26, 2021 at 11:25 AM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> There is no binding and driver for the PMIC itself, but making the bus

What about the commit below that landed in kernel 5.9?

commit 0935ff5f1f0a44f66a13e075ed49f97ad99d2fdc
Author: Robin Gong <yibin.gong@nxp.com>
Date:   Sat Jul 4 00:19:35 2020 +0800

    regulator: pca9450: add pca9450 pmic driver

    Add NXP pca9450 pmic driver.

    Signed-off-by: Robin Gong <yibin.gong@nxp.com>
    Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
    Link: https://lore.kernel.org/r/1593793178-9737-2-git-send-email-yibin.gong@nxp.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
Uwe Kleine-König March 27, 2021, 8:45 p.m. UTC | #2
Hello Fabio,

On Fri, Mar 26, 2021 at 03:26:25PM -0300, Fabio Estevam wrote:
> On Fri, Mar 26, 2021 at 11:25 AM Uwe Kleine-König

> <u.kleine-koenig@pengutronix.de> wrote:

> >

> > There is no binding and driver for the PMIC itself, but making the bus

> 

> What about the commit below that landed in kernel 5.9?

> 

> commit 0935ff5f1f0a44f66a13e075ed49f97ad99d2fdc

> Author: Robin Gong <yibin.gong@nxp.com>

> Date:   Sat Jul 4 00:19:35 2020 +0800

> 

>     regulator: pca9450: add pca9450 pmic driver

> 

>     Add NXP pca9450 pmic driver.

> 

>     Signed-off-by: Robin Gong <yibin.gong@nxp.com>

>     Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>

>     Link: https://lore.kernel.org/r/1593793178-9737-2-git-send-email-yibin.gong@nxp.com

>     Signed-off-by: Mark Brown <broonie@kernel.org>


Hmm, now that you wrote that my git grep also finds it. How did you do
that? :-)

I will respin the patch and also add the pmic as an i2c device.

Thanks and best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
index 7db4273cc88b..69e5c965930c 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
@@ -102,6 +102,15 @@  ethphy1: ethernet-phy@1 {
 	};
 };
 
+&i2c1 {
+	clock-frequency = <400000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c1>;
+	status = "okay";
+
+	/* PMIC PCA9450C at address 0x25, irq to GPIO1_IO03. */
+};
+
 &i2c3 {
 	clock-frequency = <400000>;
 	pinctrl-names = "default";
@@ -227,6 +236,13 @@  MX8MP_IOMUXC_NAND_READY_B__GPIO3_IO16	0x19
 		>;
 	};
 
+	pinctrl_i2c1: i2c1grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_I2C1_SCL__I2C1_SCL		0x400001c3
+			MX8MP_IOMUXC_I2C1_SDA__I2C1_SDA		0x400001c3
+		>;
+	};
+
 	pinctrl_i2c3: i2c3grp {
 		fsl,pins = <
 			MX8MP_IOMUXC_I2C3_SCL__I2C3_SCL		0x400001c3