| Message ID | 20210326215927.936377-4-pierre-louis.bossart@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | 6692dc07fa113939fc2c15d58dc3b27e28fc767c |
| Headers | show |
| Series | ASoC: remove cppcheck warnings for multiple SOCs | expand |
On 26.03.2021 23:59, Pierre-Louis Bossart wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Cppcheck complains: > > sound/soc/atmel/atmel-i2s.c:628:6: style: Redundant initialization for 'err'. The initialized value is overwritten before it is read. [redundantInitialization] > err = devm_request_irq(&pdev->dev, irq, atmel_i2s_interrupt, 0, > ^ > sound/soc/atmel/atmel-i2s.c:598:10: note: err is initialized > int err = -ENXIO; > ^ > sound/soc/atmel/atmel-i2s.c:628:6: note: err is overwritten > err = devm_request_irq(&pdev->dev, irq, atmel_i2s_interrupt, 0, > ^ > > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> Thanks!
diff --git a/sound/soc/atmel/atmel-i2s.c b/sound/soc/atmel/atmel-i2s.c index 7c6187e41f2b..584656cc7d3c 100644 --- a/sound/soc/atmel/atmel-i2s.c +++ b/sound/soc/atmel/atmel-i2s.c @@ -595,7 +595,7 @@ static int atmel_i2s_probe(struct platform_device *pdev) struct regmap *regmap; void __iomem *base; int irq; - int err = -ENXIO; + int err; unsigned int pcm_flags = 0; unsigned int version;
Cppcheck complains: sound/soc/atmel/atmel-i2s.c:628:6: style: Redundant initialization for 'err'. The initialized value is overwritten before it is read. [redundantInitialization] err = devm_request_irq(&pdev->dev, irq, atmel_i2s_interrupt, 0, ^ sound/soc/atmel/atmel-i2s.c:598:10: note: err is initialized int err = -ENXIO; ^ sound/soc/atmel/atmel-i2s.c:628:6: note: err is overwritten err = devm_request_irq(&pdev->dev, irq, atmel_i2s_interrupt, 0, ^ Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> --- sound/soc/atmel/atmel-i2s.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)