diff mbox series

[net-next,v2] net: lantiq: Remove redundant dev_err call in xrx200_probe()

Message ID 1616841111-8722-1-git-send-email-huangguobin4@huawei.com
State New
Headers show
Series [net-next,v2] net: lantiq: Remove redundant dev_err call in xrx200_probe() | expand

Commit Message

Huang Guobin March 27, 2021, 10:31 a.m. UTC
From: Guobin Huang <huangguobin4@huawei.com>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
---
 drivers/net/ethernet/lantiq_xrx200.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org March 29, 2021, 1:10 a.m. UTC | #1
Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sat, 27 Mar 2021 18:31:51 +0800 you wrote:
> From: Guobin Huang <huangguobin4@huawei.com>

> 

> There is a error message within devm_ioremap_resource

> already, so remove the dev_err call to avoid redundant

> error message.

> 

> Reported-by: Hulk Robot <hulkci@huawei.com>

> Signed-off-by: Guobin Huang <huangguobin4@huawei.com>

> 

> [...]


Here is the summary with links:
  - [net-next,v2] net: lantiq: Remove redundant dev_err call in xrx200_probe()
    https://git.kernel.org/netdev/net-next/c/d759c1bd2696

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/net/ethernet/lantiq_xrx200.c b/drivers/net/ethernet/lantiq_xrx200.c
index 51ed8a54d380..0f8ef8f1232c 100644
--- a/drivers/net/ethernet/lantiq_xrx200.c
+++ b/drivers/net/ethernet/lantiq_xrx200.c
@@ -460,10 +460,8 @@  static int xrx200_probe(struct platform_device *pdev)
 	}
 
 	priv->pmac_reg = devm_ioremap_resource(dev, res);
-	if (IS_ERR(priv->pmac_reg)) {
-		dev_err(dev, "failed to request and remap io ranges\n");
+	if (IS_ERR(priv->pmac_reg))
 		return PTR_ERR(priv->pmac_reg);
-	}
 
 	priv->chan_rx.dma.irq = platform_get_irq_byname(pdev, "rx");
 	if (priv->chan_rx.dma.irq < 0)