diff mbox series

lan743x: remove redundant intializations of pointers adapter and phydev

Message ID 20210328214647.66220-1-colin.king@canonical.com
State New
Headers show
Series lan743x: remove redundant intializations of pointers adapter and phydev | expand

Commit Message

Colin King March 28, 2021, 9:46 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The pointers adapter and phydev are being initialized with values that
are never read and are being updated later with a new value. The
initialization is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/microchip/lan743x_ethtool.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org March 29, 2021, 6 p.m. UTC | #1 
Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sun, 28 Mar 2021 22:46:47 +0100 you wrote:
> From: Colin Ian King <colin.king@canonical.com>

> 

> The pointers adapter and phydev are being initialized with values that

> are never read and are being updated later with a new value. The

> initialization is redundant and can be removed.

> 

> Addresses-Coverity: ("Unused value")

> Signed-off-by: Colin Ian King <colin.king@canonical.com>

> 

> [...]


Here is the summary with links:
  - lan743x: remove redundant intializations of pointers adapter and phydev
    https://git.kernel.org/netdev/net-next/c/37f368d8d09d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/net/ethernet/microchip/lan743x_ethtool.c b/drivers/net/ethernet/microchip/lan743x_ethtool.c
index c5de8f46cdd3..91a755efe2e6 100644
--- a/drivers/net/ethernet/microchip/lan743x_ethtool.c
+++ b/drivers/net/ethernet/microchip/lan743x_ethtool.c
@@ -730,8 +730,8 @@  static int lan743x_ethtool_get_eee(struct net_device *netdev,
 static int lan743x_ethtool_set_eee(struct net_device *netdev,
 				   struct ethtool_eee *eee)
 {
-	struct lan743x_adapter *adapter = netdev_priv(netdev);
-	struct phy_device *phydev = NULL;
+	struct lan743x_adapter *adapter;
+	struct phy_device *phydev;
 	u32 buf = 0;
 	int ret = 0;