| Message ID | 20210329045904.135183-1-xiubli@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | ceph: fix a typo in comments | expand |
On Mon, 2021-03-29 at 12:59 +0800, xiubli@redhat.com wrote: > From: Xiubo Li <xiubli@redhat.com> > > Signed-off-by: Xiubo Li <xiubli@redhat.com> > --- > fs/ceph/addr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c > index 57c67180ce5c..5b66f17afe0c 100644 > --- a/fs/ceph/addr.c > +++ b/fs/ceph/addr.c > @@ -1945,7 +1945,7 @@ int ceph_pool_perm_check(struct inode *inode, int need) > if (ci->i_vino.snap != CEPH_NOSNAP) { > /* > * Pool permission check needs to write to the first object. > - * But for snapshot, head of the first object may have alread > + * But for snapshot, head of the first object may have already > * been deleted. Skip check to avoid creating orphan object. > */ > return 0; In general, I don't like to merge patches that just change comments without other substantive changes. I did make an exception in this patch: [PATCH 1/2] ceph: fix kerneldoc copypasta over ceph_start_io_direct ...but that was mainly because that was generating a warning at build- time for me. I'm going to drop this patch for now. Cheers, -- Jeff Layton <jlayton@kernel.org>
On 2021/4/5 19:30, Jeff Layton wrote: > On Mon, 2021-03-29 at 12:59 +0800, xiubli@redhat.com wrote: >> From: Xiubo Li <xiubli@redhat.com> >> >> Signed-off-by: Xiubo Li <xiubli@redhat.com> >> --- >> fs/ceph/addr.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c >> index 57c67180ce5c..5b66f17afe0c 100644 >> --- a/fs/ceph/addr.c >> +++ b/fs/ceph/addr.c >> @@ -1945,7 +1945,7 @@ int ceph_pool_perm_check(struct inode *inode, int need) >> if (ci->i_vino.snap != CEPH_NOSNAP) { >> /* >> * Pool permission check needs to write to the first object. >> - * But for snapshot, head of the first object may have alread >> + * But for snapshot, head of the first object may have already >> * been deleted. Skip check to avoid creating orphan object. >> */ >> return 0; > In general, I don't like to merge patches that just change comments > without other substantive changes. I did make an exception in this > patch: > > [PATCH 1/2] ceph: fix kerneldoc copypasta over ceph_start_io_direct > > ...but that was mainly because that was generating a warning at build- > time for me. I'm going to drop this patch for now. Sure, will fix it in my next patch series. Thanks > Cheers,
diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c index 57c67180ce5c..5b66f17afe0c 100644 --- a/fs/ceph/addr.c +++ b/fs/ceph/addr.c @@ -1945,7 +1945,7 @@ int ceph_pool_perm_check(struct inode *inode, int need) if (ci->i_vino.snap != CEPH_NOSNAP) { /* * Pool permission check needs to write to the first object. - * But for snapshot, head of the first object may have alread + * But for snapshot, head of the first object may have already * been deleted. Skip check to avoid creating orphan object. */ return 0;