From patchwork Wed Nov 19 11:15:38 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 41136 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ee0-f72.google.com (mail-ee0-f72.google.com [74.125.83.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 9CD7820CBB for ; Wed, 19 Nov 2014 11:16:40 +0000 (UTC) Received: by mail-ee0-f72.google.com with SMTP id e53sf546162eek.3 for ; Wed, 19 Nov 2014 03:16:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=eYKZubBewas5kV88/fBp90n6Gi6/iBPmyCeFP3nQNds=; b=bJyJehcUIIVEnwjP9zTQeAO5m9L9c3ozFRIUC5QnTM/ZiugOigKRr1u+3lSQyx2pkW 81fZ3hP6/FWTLjR067Ksw8VpxvtVWjsyqk5/ERGczen/OuKAwkLbBjm4NKdWUtc72XYS JuwvVfuSK4r4cZ8RVHJNU1412Hj7Y8YHJ4Jbwqu4b7BFKxA123y+jYg1OrLffqeQw0vy DUyjjUV8Y1tWzdTdNuWZoi469dIMMxF7ofxdGDBpI0/kCZ5+5EKpTr32I8IcQW0J26J/ AxZRX60uA9IZ3zILbvLIhR/ZWMvAWP3VL8fkdW6DsC9GterKEGjuSx0sxS2JWlmyWYt2 7/dw== X-Gm-Message-State: ALoCoQnxTt+CSKa8jxubSvWHBy2Ln6zehKM+GsGKwIijwe5lKEUOMVgXpK9XqhFIoOwO0XIsQB1N X-Received: by 10.152.88.98 with SMTP id bf2mr16315284lab.1.1416395799907; Wed, 19 Nov 2014 03:16:39 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.5.134 with SMTP id s6ls1165144las.27.gmail; Wed, 19 Nov 2014 03:16:39 -0800 (PST) X-Received: by 10.152.205.11 with SMTP id lc11mr4819735lac.34.1416395799659; Wed, 19 Nov 2014 03:16:39 -0800 (PST) Received: from mail-lb0-f175.google.com (mail-lb0-f175.google.com. [209.85.217.175]) by mx.google.com with ESMTPS id ro8si1450581lbb.75.2014.11.19.03.16.39 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 19 Nov 2014 03:16:39 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.175 as permitted sender) client-ip=209.85.217.175; Received: by mail-lb0-f175.google.com with SMTP id n15so295224lbi.6 for ; Wed, 19 Nov 2014 03:16:39 -0800 (PST) X-Received: by 10.112.14.69 with SMTP id n5mr4857020lbc.34.1416395799547; Wed, 19 Nov 2014 03:16:39 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.184.201 with SMTP id ew9csp64289lbc; Wed, 19 Nov 2014 03:16:38 -0800 (PST) X-Received: by 10.68.203.195 with SMTP id ks3mr10471941pbc.104.1416395793688; Wed, 19 Nov 2014 03:16:33 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id xo9si2087857pbc.210.2014.11.19.03.16.33 for ; Wed, 19 Nov 2014 03:16:33 -0800 (PST) Received-SPF: none (google.com: linux-samsung-soc-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754376AbaKSLQc (ORCPT + 4 others); Wed, 19 Nov 2014 06:16:32 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:39165 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751204AbaKSLQb (ORCPT ); Wed, 19 Nov 2014 06:16:31 -0500 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NFA001O1A43AR40@mailout2.w1.samsung.com> for linux-samsung-soc@vger.kernel.org; Wed, 19 Nov 2014 11:19:15 +0000 (GMT) X-AuditID: cbfec7f5-b7f956d000005ed7-c7-546c7c0caf64 Received: from eusync1.samsung.com ( [203.254.199.211]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 2E.A2.24279.C0C7C645; Wed, 19 Nov 2014 11:16:28 +0000 (GMT) Received: from amdc1339.digital.local ([106.116.147.30]) by eusync1.samsung.com (Oracle Communications Messaging Server 7u4-23.01 (7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0NFA00GC59YMTL30@eusync1.samsung.com>; Wed, 19 Nov 2014 11:16:28 +0000 (GMT) From: Marek Szyprowski To: iommu@lists.linux-foundation.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Marek Szyprowski , linaro-mm-sig@lists.linaro.org, Arnd Bergmann , Shaik Ameer Basha , Cho KyongHo , Joerg Roedel , Thierry Reding , Olof Johansson , Laurent Pinchart , Rob Herring , Will Deacon , David Wodhouse , Inki Dae , Kukjin Kim , Tomasz Figa , Kyungmin Park Subject: [PATCH v3 09/19] iommu: exynos: remove useless spinlock Date: Wed, 19 Nov 2014 12:15:38 +0100 Message-id: <1416395748-10731-10-git-send-email-m.szyprowski@samsung.com> X-Mailer: git-send-email 1.9.2 In-reply-to: <1416395748-10731-1-git-send-email-m.szyprowski@samsung.com> References: <1416395748-10731-1-git-send-email-m.szyprowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJLMWRmVeSWpSXmKPExsVy+t/xy7o8NTkhBpcnalr8nXSM3WLiysnM FpPuT2CxWLDf2qJz9gZ2i94FV9kszja9YbfonLiE3eLLlYdMFpseX2O1mHF+H5PF2iN32S1O Xf/MZvGv9yCjxf89O9gtjjzczW6xatcfRovbv/ksXn48weIg7PHk4DwmjzXz1jB6/P41idFj 56y77B6zO2ayemxeoeWxaVUnm8fmJfUet/89ZvaYfGM5o8eVE02sHr3N79g8+rasYvT4vEku gC+KyyYlNSezLLVI3y6BK+NY1yGWgrO8FT93nGFpYOzk7mLk4JAQMJGYuDa7i5ETyBSTuHBv PVsXIxeHkMBSRonJzRfYIZw+JomDLXPYQarYBAwlut52sYHYIgL5Ei/2/mUBsZkF3rBI3Ntk CGILCzhILDm9lgnEZhFQlbh68CAjiM0r4Cnx/OxpJohtchL/X65gAjmCEyh+/QXYGCEBD4mm 6etYJzDyLmBkWMUomlqaXFCclJ5rpFecmFtcmpeul5yfu4kREh1fdzAuPWZ1iFGAg1GJh7eh OCdEiDWxrLgy9xCjBAezkghvcSFQiDclsbIqtSg/vqg0J7X4ECMTB6dUA2P+Zn3Lvma/uFI1 AaU9wY0rlK7lP8qzS2G2f5iWnFyg+UY4dXOydsGpeSFi67+oTFDq/iHxJEHAvE3t0+FZ2a+6 tPflye3QnDP3lkKm6O/+h4e+fdBwS7Up3mcX2Xj203lu0zevpt6+yXpzhcKFxwsfrbkhL3po pvFBHhf//K27LP7MM6t9HqLEUpyRaKjFXFScCABf5Y+9bAIAAA== Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: m.szyprowski@samsung.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.175 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , This patch removes useless spinlocks and other unused members from struct exynos_iommu_owner. There is no point is protecting this structure by spinlock because content of this structure doesn't change and other structures have their own spinlocks. Signed-off-by: Marek Szyprowski --- drivers/iommu/exynos-iommu.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index c0262ed1a31e..8a952a573477 100644 --- a/drivers/iommu/exynos-iommu.c +++ b/drivers/iommu/exynos-iommu.c @@ -189,9 +189,6 @@ struct exynos_iommu_owner { struct list_head client; /* entry of exynos_iommu_domain.clients */ struct device *dev; struct device *sysmmu; - struct iommu_domain *domain; - void *vmm_data; /* IO virtual memory manager's data */ - spinlock_t lock; /* Lock to preserve consistency of System MMU */ }; struct exynos_iommu_domain { @@ -477,16 +474,12 @@ static int __exynos_sysmmu_enable(struct device *dev, phys_addr_t pgtable, BUG_ON(!has_sysmmu(dev)); - spin_lock_irqsave(&owner->lock, flags); - data = dev_get_drvdata(owner->sysmmu); ret = __sysmmu_enable(data, pgtable, domain); if (ret >= 0) data->master = dev; - spin_unlock_irqrestore(&owner->lock, flags); - return ret; } @@ -499,16 +492,12 @@ static bool exynos_sysmmu_disable(struct device *dev) BUG_ON(!has_sysmmu(dev)); - spin_lock_irqsave(&owner->lock, flags); - data = dev_get_drvdata(owner->sysmmu); disabled = __sysmmu_disable(data); if (disabled) data->master = NULL; - spin_unlock_irqrestore(&owner->lock, flags); - return disabled; }