From patchwork Thu Nov 20 16:13:33 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 41246 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oi0-f72.google.com (mail-oi0-f72.google.com [209.85.218.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 37E3623C27 for ; Thu, 20 Nov 2014 16:13:24 +0000 (UTC) Received: by mail-oi0-f72.google.com with SMTP id e131sf12313570oig.3 for ; Thu, 20 Nov 2014 08:13:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :mime-version:content-type:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=5dBk4Q+gG1lNrtc300ZTW7b8V2WFqkYlM+pcNdbyV/0=; b=HerxmKqDi2UhWblQ60F81gNRrFqp5eMmsJGo6mJXnIydeWXmNXzP5gaoWugZLF16te kjKp121ZxlgYq+goCo6AGBQ/Ep4prVGt6Bpyk77YcMPrj03kg2R56kwYc+qm3JHrHbEB Atx8su4IPT4kf/3yQ7XaDIghpXIZ8rVITC+jmR3R1C3vzG8pSAmIhQx11l9HH9j4a2tq xI0pW686dkczH50lQ4R2A9FYl/ziVxhHV1ryTwE2K5dDohKerBK8rOmIwoNPHQX0bYu+ plF82dC+LUOPyHbHF5q/BkdWObES0WVzWmDJyz0giqFmlJ9tnobPzxtwQEFul33Tfqea bOEQ== X-Gm-Message-State: ALoCoQlPlc9wf8UzyUUybgUqKYUd35EEwpWHE4BM756pM6ztlBe1DergYFeG4u2FBKpVlR99c32Q X-Received: by 10.182.120.99 with SMTP id lb3mr83663547obb.10.1416500003767; Thu, 20 Nov 2014 08:13:23 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.43.100 with SMTP id d91ls322327qga.6.gmail; Thu, 20 Nov 2014 08:13:23 -0800 (PST) X-Received: by 10.224.74.135 with SMTP id u7mr58493477qaj.67.1416500003684; Thu, 20 Nov 2014 08:13:23 -0800 (PST) Received: from mail-qg0-f50.google.com (mail-qg0-f50.google.com. [209.85.192.50]) by mx.google.com with ESMTPS id n94si3172336qgn.55.2014.11.20.08.13.23 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 20 Nov 2014 08:13:23 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.192.50 as permitted sender) client-ip=209.85.192.50; Received: by mail-qg0-f50.google.com with SMTP id e89so2264156qgf.37 for ; Thu, 20 Nov 2014 08:13:23 -0800 (PST) X-Received: by 10.153.7.170 with SMTP id dd10mr11981187lad.44.1416500003506; Thu, 20 Nov 2014 08:13:23 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.184.201 with SMTP id ew9csp288754lbc; Thu, 20 Nov 2014 08:13:22 -0800 (PST) X-Received: by 10.70.135.41 with SMTP id pp9mr57802473pdb.77.1416500000215; Thu, 20 Nov 2014 08:13:20 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id kp4si3782529pdb.195.2014.11.20.08.13.18 for ; Thu, 20 Nov 2014 08:13:20 -0800 (PST) Received-SPF: none (google.com: linux-usb-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757445AbaKTQNQ (ORCPT + 3 others); Thu, 20 Nov 2014 11:13:16 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:47666 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757073AbaKTQNQ (ORCPT ); Thu, 20 Nov 2014 11:13:16 -0500 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id sAKGDFJg003353 for ; Thu, 20 Nov 2014 10:13:15 -0600 Received: from DLEE70.ent.ti.com (dlemailx.itg.ti.com [157.170.170.113]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id sAKGDFUw031285 for ; Thu, 20 Nov 2014 10:13:15 -0600 Received: from dflp33.itg.ti.com (10.64.6.16) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.3.174.1; Thu, 20 Nov 2014 10:13:15 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id sAKGDEAm019870; Thu, 20 Nov 2014 10:13:15 -0600 From: Felipe Balbi To: Linux USB Mailing List CC: Felipe Balbi Subject: [PATCH] usb: dwc3: trace: don't save pointers Date: Thu, 20 Nov 2014 10:13:33 -0600 Message-ID: <1416500013-19704-1-git-send-email-balbi@ti.com> X-Mailer: git-send-email 2.1.0.GIT MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: balbi@ti.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.192.50 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , There was another instance where we were holding pointers which could be long gone. Fix that by caching only values pointed to by such pointer. Because no crash has been observed, this patch will be sent on v3.19 merge window, instead of -rc. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/trace.h | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/usb/dwc3/trace.h b/drivers/usb/dwc3/trace.h index 7a9d780..9fc20b3 100644 --- a/drivers/usb/dwc3/trace.h +++ b/drivers/usb/dwc3/trace.h @@ -175,17 +175,21 @@ DECLARE_EVENT_CLASS(dwc3_log_gadget_ep_cmd, TP_STRUCT__entry( __dynamic_array(char, name, DWC3_MSG_MAX) __field(unsigned int, cmd) - __field(struct dwc3_gadget_ep_cmd_params *, params) + __field(u32, param0) + __field(u32, param1) + __field(u32, param2) ), TP_fast_assign( snprintf(__get_str(name), DWC3_MSG_MAX, "%s", dep->name); __entry->cmd = cmd; - __entry->params = params; + __entry->param0 = params->param0; + __entry->param1 = params->param1; + __entry->param2 = params->param2; ), TP_printk("%s: cmd '%s' [%d] params %08x %08x %08x", __get_str(name), dwc3_gadget_ep_cmd_string(__entry->cmd), - __entry->cmd, __entry->params->param0, - __entry->params->param1, __entry->params->param2 + __entry->cmd, __entry->param0, + __entry->param1, __entry->param2 ) );