From patchwork Fri Nov 21 14:05:32 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Campbell X-Patchwork-Id: 41318 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f72.google.com (mail-wg0-f72.google.com [74.125.82.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 3BD81244B0 for ; Fri, 21 Nov 2014 14:09:22 +0000 (UTC) Received: by mail-wg0-f72.google.com with SMTP id y19sf3021535wgg.7 for ; Fri, 21 Nov 2014 06:09:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:from:to:date:in-reply-to :references:organization:mime-version:cc:subject:precedence:list-id :list-unsubscribe:list-post:list-help:list-subscribe:content-type :content-transfer-encoding:sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list:list-archive; bh=UK+5HOIm1kuXv4QCRe75Z9eRwTvwNrnz0fF2G01V2v8=; b=eXXDFUCvv8LLx0JgR1gvlW0RX3FQ+5ct6p6XuklgMqlSmFrhWojKVd+w2lNLGVLbNZ Do+RkFgjhi+Dc8LFVt1xjbaF98UuPOc7/sxNOEoFonhfeB5HMJ+oqLmZERyn9uGyY8xX x93Ccplv3s2dhaCm9nkU5y45VBbCOtYgszaFcHl3/vd1Bs47H7PbeHXt4RAqQsiyrm7A sZv77AoeTAIHMfqHk4ZKIsyNbHHlRXHh1YesJ+17iG+eDADCGsloL6/uZPG9Yi4fRv2H TvIedneKtHsbkASbeibiC4Mi9fR8GaqfOywlltsEMQaXiNRQNcusa+0uu6V5BbUzF11j z9Ew== X-Gm-Message-State: ALoCoQlkKkRw1BfX+9LbzkgwKz3ITew0nMrktwinnvH4p4B51Mz6r5GV/J09mdC9F4Hd7t2PxByC X-Received: by 10.180.75.78 with SMTP id a14mr1180987wiw.0.1416578958840; Fri, 21 Nov 2014 06:09:18 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.6.9 with SMTP id w9ls211299law.1.gmail; Fri, 21 Nov 2014 06:09:18 -0800 (PST) X-Received: by 10.112.156.138 with SMTP id we10mr3808696lbb.88.1416578958573; Fri, 21 Nov 2014 06:09:18 -0800 (PST) Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com. [209.85.217.181]) by mx.google.com with ESMTPS id kr10si5526283lac.72.2014.11.21.06.09.18 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 21 Nov 2014 06:09:18 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.181 as permitted sender) client-ip=209.85.217.181; Received: by mail-lb0-f181.google.com with SMTP id l4so4173460lbv.12 for ; Fri, 21 Nov 2014 06:09:16 -0800 (PST) X-Received: by 10.153.7.170 with SMTP id dd10mr4887398lad.44.1416578956913; Fri, 21 Nov 2014 06:09:16 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.184.201 with SMTP id ew9csp96700lbc; Fri, 21 Nov 2014 06:09:16 -0800 (PST) X-Received: by 10.221.19.68 with SMTP id qj4mr4772128vcb.2.1416578955450; Fri, 21 Nov 2014 06:09:15 -0800 (PST) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id 9si2313679vdz.72.2014.11.21.06.09.14 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 21 Nov 2014 06:09:15 -0800 (PST) Received-SPF: none (google.com: xen-devel-bounces@lists.xen.org does not designate permitted sender hosts) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Xros8-0002T8-Ss; Fri, 21 Nov 2014 14:07:40 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Xros7-0002Sy-Ty for xen-devel@lists.xen.org; Fri, 21 Nov 2014 14:07:40 +0000 Received: from [85.158.139.211] by server-1.bemta-5.messagelabs.com id B4/68-24124-B274F645; Fri, 21 Nov 2014 14:07:39 +0000 X-Env-Sender: Ian.Campbell@citrix.com X-Msg-Ref: server-2.tower-206.messagelabs.com!1416578857!12677422!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.12.4; banners=-,-,- X-VirusChecked: Checked Received: (qmail 26771 invoked from network); 21 Nov 2014 14:07:38 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-2.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 21 Nov 2014 14:07:38 -0000 X-IronPort-AV: E=Sophos;i="5.07,431,1413244800"; d="scan'208";a="195245298" Message-ID: <1416578732.17932.9.camel@citrix.com> From: Ian Campbell To: Xing Lin Date: Fri, 21 Nov 2014 14:05:32 +0000 In-Reply-To: <1416562126.26869.8.camel@citrix.com> References: <54648EB3.8040703@citrix.com> <1415955718.31613.34.camel@citrix.com> <1416227964.5466.12.camel@citrix.com> <1416475824.14429.1.camel@citrix.com> <1416562126.26869.8.camel@citrix.com> Organization: Citrix Systems, Inc. X-Mailer: Evolution 3.12.7-1 MIME-Version: 1.0 X-DLP: MIA1 Cc: libvir-list@redhat.com, Jim Fehlig , Roger Pau =?ISO-8859-1?Q?Monn=E9?= , xen-devel@lists.xen.org Subject: Re: [Xen-devel] dom0 kenrel crashes for openstack + libvirt + libxl X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ian.campbell@citrix.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.181 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: On Fri, 2014-11-21 at 09:28 +0000, Ian Campbell wrote: > I think libvirt is wrong to specify an absolute path here, IMHO by > default it should just specify "pygrub" and let libxl figure out the > correct path. Jim, what do you think? e.g. something like the following untested (but pretty obvious[0]) patch. I'm currently rebuilding Debian's libvirt package with this included so I can give it a go. Ian. [0] famous last words, I know! 8<--------------- >From 4edbcbdc7e28896121832d8e226e7aeccf30633c Mon Sep 17 00:00:00 2001 From: Ian Campbell Date: Fri, 21 Nov 2014 14:00:38 +0000 Subject: [PATCH] libxl: Allow libxl to find pygrub binary. Specifying an explicit path to pygrub (e.g. BINDIR "/pygrub") only works if Xen and libvirt happen to be installed to the same prefix. A more flexible approach is to simply specify "pygrub" which will cause libxl to use the correct path which it knows (since it is built with the same prefix as pygrub). This is particular problematic in the Debian packaging, since the Debian Xen package relocates pygrub into a libexec dir, however I think this change makes sense upstream. Signed-off-by: Ian Campbell --- src/libxl/libxl_conf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libxl/libxl_conf.h b/src/libxl/libxl_conf.h index 25f77ea..3669e68 100644 --- a/src/libxl/libxl_conf.h +++ b/src/libxl/libxl_conf.h @@ -53,7 +53,7 @@ # define LIBXL_LIB_DIR LOCALSTATEDIR "/lib/libvirt/libxl" # define LIBXL_SAVE_DIR LIBXL_LIB_DIR "/save" # define LIBXL_DUMP_DIR LIBXL_LIB_DIR "/dump" -# define LIBXL_BOOTLOADER_PATH BINDIR "/pygrub" +# define "pygrub" /* libxl interface for setting VCPU affinity changed in 4.5. In fact, a new * parameter has been added, representative of 'VCPU soft affinity'. If one