| Message ID | 20210402033643.12259-1-steves.lee@maximintegrated.com |
|---|---|
| State | New |
| Headers | show |
| Series | ASoC: max98390: Add controls for tx path | expand |
On Fri, Apr 02, 2021 at 12:36:43PM +0900, Steve Lee wrote: > + SOC_SINGLE("Tx Enable Selection", MAX98390_PCM_TX_EN_A, > + 0, 255, 0), I'm not clear what this is (especially given the source selection below) but it looks like it should be a mute control? > + SOC_SINGLE("Tx Hiz Selection", MAX98390_PCM_TX_HIZ_CTRL_A, > + 0, 255, 0), This I'd expect to be tied into machine driver configuration, either DT properties or TDM slot configuration - it's not something that looks like it's something you'd want to control at runtime. > + SOC_SINGLE("Tx Source Selection", MAX98390_PCM_CH_SRC_2, > + 0, 255, 0), This looks like it should be a DAPM control or possibly a TDM slot configuration - look at how the Arizona devices handle routing from multiple TDM slots for the DAPM version.
> -----Original Message----- > From: Mark Brown <broonie@kernel.org> > Sent: Saturday, April 3, 2021 12:23 AM > To: Steve Lee <SteveS.Lee@maximintegrated.com> > Cc: lgirdwood@gmail.com; perex@perex.cz; tiwai@suse.com; > ckeepax@opensource.cirrus.com; geert@linux-m68k.org; > rf@opensource.wolfsonmicro.com; shumingf@realtek.com; > srinivas.kandagatla@linaro.org; krzk@kernel.org; dmurphy@ti.com; > jack.yu@realtek.com; nuno.sa@analog.com; linux-kernel@vger.kernel.org; > alsa-devel@alsa-project.org; ryan.lee.maxim@gmail.com; > steves.lee.maxim@gmail.com > Subject: [EXTERNAL] Re: [PATCH] ASoC: max98390: Add controls for tx path > > On Fri, Apr 02, 2021 at 12:36:43PM +0900, Steve Lee wrote: > > > + SOC_SINGLE("Tx Enable Selection", MAX98390_PCM_TX_EN_A, > > + 0, 255, 0), > > I'm not clear what this is (especially given the source selection below) but it > looks like it should be a mute control? Yes, each channel of enable and disable control. I will update this also configured by TDM slot configuration. > > > + SOC_SINGLE("Tx Hiz Selection", MAX98390_PCM_TX_HIZ_CTRL_A, > > + 0, 255, 0), > > This I'd expect to be tied into machine driver configuration, either DT properties > or TDM slot configuration - it's not something that looks like it's something > you'd want to control at runtime. I will update this with either TDM slot configuration and DT properties. > > > + SOC_SINGLE("Tx Source Selection", MAX98390_PCM_CH_SRC_2, > > + 0, 255, 0), > > This looks like it should be a DAPM control or possibly a TDM slot configuration - > look at how the Arizona devices handle routing from multiple TDM slots for the > DAPM version. This is for Current Sensing and Voltage sensing slot selection. I will update this as DT properties.
diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs/max98390.c index bb736c44e68a..163093959da8 100644 --- a/sound/soc/codecs/max98390.c +++ b/sound/soc/codecs/max98390.c @@ -656,6 +656,12 @@ static const struct snd_kcontrol_new max98390_snd_controls[] = { MAX98390_AMP_DSP_CFG_RMP_DN_SHIFT, 1, 0), SOC_SINGLE("Boost Clock Phase", MAX98390_BOOST_CTRL3, MAX98390_BOOST_CLK_PHASE_CFG_SHIFT, 3, 0), + SOC_SINGLE("Tx Enable Selection", MAX98390_PCM_TX_EN_A, + 0, 255, 0), + SOC_SINGLE("Tx Hiz Selection", MAX98390_PCM_TX_HIZ_CTRL_A, + 0, 255, 0), + SOC_SINGLE("Tx Source Selection", MAX98390_PCM_CH_SRC_2, + 0, 255, 0), SOC_ENUM("Boost Output Voltage", max98390_boost_voltage), SOC_ENUM("Current Limit", max98390_current_limit), SOC_SINGLE_EXT("DSM Rdc", SND_SOC_NOPM, 0, 0xffffff, 0,
Add controls for tx source. Signed-off-by: Steve Lee <steves.lee@maximintegrated.com> --- sound/soc/codecs/max98390.c | 6 ++++++ 1 file changed, 6 insertions(+)