diff mbox series

[-next] media: camss: csid: Remove redundant dev_err call in msm_csid_subdev_init()

Message ID 20210402093255.2457184-1-yangyingliang@huawei.com
State Accepted
Commit 6c0ed6d4b3211f135905e6f75475788b864234bd
Headers show
Series [-next] media: camss: csid: Remove redundant dev_err call in msm_csid_subdev_init() | expand

Commit Message

Yang Yingliang April 2, 2021, 9:32 a.m. UTC
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/media/platform/qcom/camss/camss-csid.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Robert Foss April 6, 2021, 8:30 a.m. UTC | #1
Hi Yang,

Thanks for the fix.

Reviewed-by: Robert Foss <robert.foss@linaro.org>

On Fri, 2 Apr 2021 at 11:29, Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/media/platform/qcom/camss/camss-csid.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c
> index 463760c29294..cc11fbfdae13 100644
> --- a/drivers/media/platform/qcom/camss/camss-csid.c
> +++ b/drivers/media/platform/qcom/camss/camss-csid.c
> @@ -568,10 +568,8 @@ int msm_csid_subdev_init(struct camss *camss, struct csid_device *csid,
>
>         r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[0]);
>         csid->base = devm_ioremap_resource(dev, r);
> -       if (IS_ERR(csid->base)) {
> -               dev_err(dev, "could not map memory\n");
> +       if (IS_ERR(csid->base))
>                 return PTR_ERR(csid->base);
> -       }
>
>         /* Interrupt */
>
> --
> 2.25.1
>
patchwork-bot+linux-arm-msm@kernel.org May 26, 2021, 7:03 p.m. UTC | #2
Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

On Fri, 2 Apr 2021 17:32:55 +0800 you wrote:
> There is a error message within devm_ioremap_resource

> already, so remove the dev_err call to avoid redundant

> error message.

> 

> Reported-by: Hulk Robot <hulkci@huawei.com>

> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

> 

> [...]


Here is the summary with links:
  - [-next] media: camss: csid: Remove redundant dev_err call in msm_csid_subdev_init()
    https://git.kernel.org/qcom/c/6c0ed6d4b321

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c
index 463760c29294..cc11fbfdae13 100644
--- a/drivers/media/platform/qcom/camss/camss-csid.c
+++ b/drivers/media/platform/qcom/camss/camss-csid.c
@@ -568,10 +568,8 @@  int msm_csid_subdev_init(struct camss *camss, struct csid_device *csid,
 
 	r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[0]);
 	csid->base = devm_ioremap_resource(dev, r);
-	if (IS_ERR(csid->base)) {
-		dev_err(dev, "could not map memory\n");
+	if (IS_ERR(csid->base))
 		return PTR_ERR(csid->base);
-	}
 
 	/* Interrupt */