diff mbox series

[1/2] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm8008 support

Message ID 1568107824b071265b5fc3a195a1d91089ad617a.1617834404.git.gurus@codeaurora.org
State New
Headers show
Series [1/2] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm8008 support | expand

Commit Message

Guru Das Srinagesh April 7, 2021, 10:34 p.m. UTC
Add support for the PM8008 GPIO support to the Qualcomm PMIC GPIO
binding.

Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
---
 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 2 ++
 1 file changed, 2 insertions(+)

Comments

Bjorn Andersson April 8, 2021, 3:36 a.m. UTC | #1
On Wed 07 Apr 17:34 CDT 2021, Guru Das Srinagesh wrote:

> Add support for the PM8008 GPIO support to the Qualcomm PMIC GPIO
> binding.
> 
> Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
> ---
>  Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> index 70e119b..1818481 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> @@ -36,6 +36,7 @@ PMIC's from Qualcomm.
>  		    "qcom,pm6150-gpio"
>  		    "qcom,pm6150l-gpio"
>  		    "qcom,pmx55-gpio"
> +		    "qcom,pm8008-gpio"

Please keep these sorted alphabetically (i.e. '8' < 'x')

With that

Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

>  
>  		    And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio"
>  		    if the device is on an spmi bus or an ssbi bus respectively
> @@ -125,6 +126,7 @@ to specify in a pin configuration subnode:
>  		    gpio1-gpio12 for pm6150l
>  		    gpio1-gpio11 for pmx55 (holes on gpio3, gpio7, gpio10
>  					    and gpio11)
> +		    gpio1-gpio2 for pm8008
>  
>  - function:
>  	Usage: required
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
Bjorn Andersson April 8, 2021, 3:37 a.m. UTC | #2
On Wed 07 Apr 17:35 CDT 2021, Guru Das Srinagesh wrote:

> Add support for the two GPIOs present on PM8008.

> 

> Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>

> ---

>  drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c

> index c2b9f2e..76e997a 100644

> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c

> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c

> @@ -1137,6 +1137,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {

>  	{ .compatible = "qcom,pm6150l-gpio", .data = (void *) 12 },

>  	/* pmx55 has 11 GPIOs with holes on 3, 7, 10, 11 */

>  	{ .compatible = "qcom,pmx55-gpio", .data = (void *) 11 },

> +	{ .compatible = "qcom,pm8008-gpio", .data = (void *) 2 },


As with the binding, please keep these sorted alphabetically.

With that:

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>


Regards,
Bjorn

>  	{ },

>  };

>  

> -- 

> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,

> a Linux Foundation Collaborative Project

>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
index 70e119b..1818481 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
@@ -36,6 +36,7 @@  PMIC's from Qualcomm.
 		    "qcom,pm6150-gpio"
 		    "qcom,pm6150l-gpio"
 		    "qcom,pmx55-gpio"
+		    "qcom,pm8008-gpio"
 
 		    And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio"
 		    if the device is on an spmi bus or an ssbi bus respectively
@@ -125,6 +126,7 @@  to specify in a pin configuration subnode:
 		    gpio1-gpio12 for pm6150l
 		    gpio1-gpio11 for pmx55 (holes on gpio3, gpio7, gpio10
 					    and gpio11)
+		    gpio1-gpio2 for pm8008
 
 - function:
 	Usage: required