Message ID | 1617976766-7852-4-git-send-email-skakit@codeaurora.org |
---|---|
State | Accepted |
Commit | f2f2bc3c0cfc81ee70ad97833a5f788f5e58f600 |
Headers | show |
Series | Add RTC support for PMIC PMK8350 | expand |
Hi satya, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on abelloni/rtc-next] [also build test WARNING on lee-mfd/for-mfd-next robh/for-next v5.12-rc6 next-20210409] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/satya-priya/Add-RTC-support-for-PMIC-PMK8350/20210409-220149 base: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 reproduce: make ARCH=arm dtbs_check If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> dtcheck warnings: (new ones prefixed by >>) arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml: power-controller@2099000: '#power-domain-cells' is a required property From schema: Documentation/devicetree/bindings/power/power-domain.yaml arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml: power-controller@20a9000: '#power-domain-cells' is a required property From schema: Documentation/devicetree/bindings/power/power-domain.yaml arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml: power-controller@20b9000: '#power-domain-cells' is a required property From schema: Documentation/devicetree/bindings/power/power-domain.yaml arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml: sps-sic-non-secure@12100000: compatible: 'anyOf' conditional failed, one must be fixed: ['syscon'] is too short 'syscon' is not one of ['allwinner,sun8i-a83t-system-controller', 'allwinner,sun8i-h3-system-controller', 'allwinner,sun8i-v3s-system-controller', 'allwinner,sun50i-a64-system-controller', 'hisilicon,dsa-subctrl', 'hisilicon,hi6220-sramctrl', 'hisilicon,pcie-sas-subctrl', 'hisilicon,peri-subctrl', 'microchip,sparx5-cpu-syscon', 'mstar,msc313-pmsleep', 'rockchip,px30-qos', 'rockchip,rk3066-qos', 'rockchip,rk3288-qos', 'rockchip,rk3399-qos', 'samsung,exynos3-sysreg', 'samsung,exynos4-sysreg', 'samsung,exynos5-sysreg', 'samsung,exynos5433-sysreg'] From schema: Documentation/devicetree/bindings/mfd/syscon.yaml >> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml: pmic@1: 'mpps@50' does not match any of the regexes: 'pinctrl-[0-9]+', 'rtc@[0-9a-f]+$' From schema: Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.9/dist-packages/dtschema/schemas/rtc/qcom-pm8xxx-rtc.yaml' -- arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml: power-controller@2099000: '#power-domain-cells' is a required property From schema: Documentation/devicetree/bindings/power/power-domain.yaml arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml: power-controller@20a9000: '#power-domain-cells' is a required property From schema: Documentation/devicetree/bindings/power/power-domain.yaml arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml: power-controller@20b9000: '#power-domain-cells' is a required property From schema: Documentation/devicetree/bindings/power/power-domain.yaml arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml: sps-sic-non-secure@12100000: compatible: 'anyOf' conditional failed, one must be fixed: ['syscon'] is too short 'syscon' is not one of ['allwinner,sun8i-a83t-system-controller', 'allwinner,sun8i-h3-system-controller', 'allwinner,sun8i-v3s-system-controller', 'allwinner,sun50i-a64-system-controller', 'hisilicon,dsa-subctrl', 'hisilicon,hi6220-sramctrl', 'hisilicon,pcie-sas-subctrl', 'hisilicon,peri-subctrl', 'microchip,sparx5-cpu-syscon', 'mstar,msc313-pmsleep', 'rockchip,px30-qos', 'rockchip,rk3066-qos', 'rockchip,rk3288-qos', 'rockchip,rk3399-qos', 'samsung,exynos3-sysreg', 'samsung,exynos4-sysreg', 'samsung,exynos5-sysreg', 'samsung,exynos5433-sysreg'] From schema: Documentation/devicetree/bindings/mfd/syscon.yaml >> arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml: pmic@1: 'mpps@50' does not match any of the regexes: 'pinctrl-[0-9]+', 'rtc@[0-9a-f]+$' From schema: Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.9/dist-packages/dtschema/schemas/rtc/qcom-pm8xxx-rtc.yaml' -- arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml: power-controller@2099000: '#power-domain-cells' is a required property From schema: Documentation/devicetree/bindings/power/power-domain.yaml arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml: power-controller@20a9000: '#power-domain-cells' is a required property From schema: Documentation/devicetree/bindings/power/power-domain.yaml arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml: power-controller@20b9000: '#power-domain-cells' is a required property From schema: Documentation/devicetree/bindings/power/power-domain.yaml arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml: sps-sic-non-secure@12100000: compatible: 'anyOf' conditional failed, one must be fixed: ['syscon'] is too short 'syscon' is not one of ['allwinner,sun8i-a83t-system-controller', 'allwinner,sun8i-h3-system-controller', 'allwinner,sun8i-v3s-system-controller', 'allwinner,sun50i-a64-system-controller', 'hisilicon,dsa-subctrl', 'hisilicon,hi6220-sramctrl', 'hisilicon,pcie-sas-subctrl', 'hisilicon,peri-subctrl', 'microchip,sparx5-cpu-syscon', 'mstar,msc313-pmsleep', 'rockchip,px30-qos', 'rockchip,rk3066-qos', 'rockchip,rk3288-qos', 'rockchip,rk3399-qos', 'samsung,exynos3-sysreg', 'samsung,exynos4-sysreg', 'samsung,exynos5-sysreg', 'samsung,exynos5433-sysreg'] From schema: Documentation/devicetree/bindings/mfd/syscon.yaml >> arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml: pmic@1: 'mpps@50' does not match any of the regexes: 'pinctrl-[0-9]+', 'rtc@[0-9a-f]+$' From schema: Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.9/dist-packages/dtschema/schemas/rtc/qcom-pm8xxx-rtc.yaml' -- arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml: power-controller@2099000: '#power-domain-cells' is a required property From schema: Documentation/devicetree/bindings/power/power-domain.yaml arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml: power-controller@20a9000: '#power-domain-cells' is a required property From schema: Documentation/devicetree/bindings/power/power-domain.yaml arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml: power-controller@20b9000: '#power-domain-cells' is a required property From schema: Documentation/devicetree/bindings/power/power-domain.yaml arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml: sps-sic-non-secure@12100000: compatible: 'anyOf' conditional failed, one must be fixed: ['syscon'] is too short 'syscon' is not one of ['allwinner,sun8i-a83t-system-controller', 'allwinner,sun8i-h3-system-controller', 'allwinner,sun8i-v3s-system-controller', 'allwinner,sun50i-a64-system-controller', 'hisilicon,dsa-subctrl', 'hisilicon,hi6220-sramctrl', 'hisilicon,pcie-sas-subctrl', 'hisilicon,peri-subctrl', 'microchip,sparx5-cpu-syscon', 'mstar,msc313-pmsleep', 'rockchip,px30-qos', 'rockchip,rk3066-qos', 'rockchip,rk3288-qos', 'rockchip,rk3399-qos', 'samsung,exynos3-sysreg', 'samsung,exynos4-sysreg', 'samsung,exynos5-sysreg', 'samsung,exynos5433-sysreg'] From schema: Documentation/devicetree/bindings/mfd/syscon.yaml >> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml: pmic@1: 'mpps@50' does not match any of the regexes: 'pinctrl-[0-9]+', 'rtc@[0-9a-f]+$' From schema: Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml Unknown file referenced: [Errno 2] No such file or directory: '/usr/local/lib/python3.9/dist-packages/dtschema/schemas/rtc/qcom-pm8xxx-rtc.yaml' --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
On Fri, 09 Apr 2021 19:29:25 +0530, satya priya wrote: > Convert pm8xxx bindings from .txt to .yaml format. Also, > split this binding into two: parent binding(qcom-pm8xxx.yaml) > and child node RTC binding(qcom-pm8xxx-rtc.yaml). > > Signed-off-by: satya priya <skakit@codeaurora.org> > --- > Changes in V2: > - As per Bjorn's comments, I've split this into two, one parent binding > and one child node rtc binding. > - Fixed bot errors and changed maintainer name. > > .../devicetree/bindings/mfd/qcom-pm8xxx.txt | 100 --------------------- > .../devicetree/bindings/mfd/qcom-pm8xxx.yaml | 54 +++++++++++ > 2 files changed, 54 insertions(+), 100 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/mfd/qcom-pm8xxx.txt > create mode 100644 Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml > Reviewed-by: Rob Herring <robh@kernel.org>
On Fri, 09 Apr 2021, satya priya wrote: > Convert pm8xxx bindings from .txt to .yaml format. Also, > split this binding into two: parent binding(qcom-pm8xxx.yaml) > and child node RTC binding(qcom-pm8xxx-rtc.yaml). > > Signed-off-by: satya priya <skakit@codeaurora.org> > --- > Changes in V2: > - As per Bjorn's comments, I've split this into two, one parent binding > and one child node rtc binding. > - Fixed bot errors and changed maintainer name. > > .../devicetree/bindings/mfd/qcom-pm8xxx.txt | 100 --------------------- > .../devicetree/bindings/mfd/qcom-pm8xxx.yaml | 54 +++++++++++ > 2 files changed, 54 insertions(+), 100 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/mfd/qcom-pm8xxx.txt > create mode 100644 Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
On Wed, Apr 14, 2021 at 3:38 AM Lee Jones <lee.jones@linaro.org> wrote: > > On Fri, 09 Apr 2021, satya priya wrote: > > > Convert pm8xxx bindings from .txt to .yaml format. Also, > > split this binding into two: parent binding(qcom-pm8xxx.yaml) > > and child node RTC binding(qcom-pm8xxx-rtc.yaml). > > > > Signed-off-by: satya priya <skakit@codeaurora.org> > > --- > > Changes in V2: > > - As per Bjorn's comments, I've split this into two, one parent binding > > and one child node rtc binding. > > - Fixed bot errors and changed maintainer name. > > > > .../devicetree/bindings/mfd/qcom-pm8xxx.txt | 100 --------------------- > > .../devicetree/bindings/mfd/qcom-pm8xxx.yaml | 54 +++++++++++ > > 2 files changed, 54 insertions(+), 100 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/mfd/qcom-pm8xxx.txt > > create mode 100644 Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml > > Applied, thanks. You need to apply the rtc schema too. linux-next has an error on this one now. Rob
Hi, On 16/04/2021 12:20:30-0500, Rob Herring wrote: > On Wed, Apr 14, 2021 at 3:38 AM Lee Jones <lee.jones@linaro.org> wrote: > > > > On Fri, 09 Apr 2021, satya priya wrote: > > > > > Convert pm8xxx bindings from .txt to .yaml format. Also, > > > split this binding into two: parent binding(qcom-pm8xxx.yaml) > > > and child node RTC binding(qcom-pm8xxx-rtc.yaml). > > > > > > Signed-off-by: satya priya <skakit@codeaurora.org> > > > --- > > > Changes in V2: > > > - As per Bjorn's comments, I've split this into two, one parent binding > > > and one child node rtc binding. > > > - Fixed bot errors and changed maintainer name. > > > > > > .../devicetree/bindings/mfd/qcom-pm8xxx.txt | 100 --------------------- > > > .../devicetree/bindings/mfd/qcom-pm8xxx.yaml | 54 +++++++++++ > > > 2 files changed, 54 insertions(+), 100 deletions(-) > > > delete mode 100644 Documentation/devicetree/bindings/mfd/qcom-pm8xxx.txt > > > create mode 100644 Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml > > > > Applied, thanks. > > You need to apply the rtc schema too. linux-next has an error on this one now. > I'm going to apply it later tonight
On Fri, Apr 16, 2021 at 2:17 PM Alexandre Belloni <alexandre.belloni@bootlin.com> wrote: > > Hi, > > On 16/04/2021 12:20:30-0500, Rob Herring wrote: > > On Wed, Apr 14, 2021 at 3:38 AM Lee Jones <lee.jones@linaro.org> wrote: > > > > > > On Fri, 09 Apr 2021, satya priya wrote: > > > > > > > Convert pm8xxx bindings from .txt to .yaml format. Also, > > > > split this binding into two: parent binding(qcom-pm8xxx.yaml) > > > > and child node RTC binding(qcom-pm8xxx-rtc.yaml). > > > > > > > > Signed-off-by: satya priya <skakit@codeaurora.org> > > > > --- > > > > Changes in V2: > > > > - As per Bjorn's comments, I've split this into two, one parent binding > > > > and one child node rtc binding. > > > > - Fixed bot errors and changed maintainer name. > > > > > > > > .../devicetree/bindings/mfd/qcom-pm8xxx.txt | 100 --------------------- > > > > .../devicetree/bindings/mfd/qcom-pm8xxx.yaml | 54 +++++++++++ > > > > 2 files changed, 54 insertions(+), 100 deletions(-) > > > > delete mode 100644 Documentation/devicetree/bindings/mfd/qcom-pm8xxx.txt > > > > create mode 100644 Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml > > > > > > Applied, thanks. > > > > You need to apply the rtc schema too. linux-next has an error on this one now. > > > > I'm going to apply it later tonight I've said this before, but MFD bindings with more than one schema file like this one need to go thru one tree or things break temporarily (as now Linus' tree is broken). Rob
On 29/04/2021 10:18:21-0500, Rob Herring wrote: > On Fri, Apr 16, 2021 at 2:17 PM Alexandre Belloni > <alexandre.belloni@bootlin.com> wrote: > > > > Hi, > > > > On 16/04/2021 12:20:30-0500, Rob Herring wrote: > > > On Wed, Apr 14, 2021 at 3:38 AM Lee Jones <lee.jones@linaro.org> wrote: > > > > > > > > On Fri, 09 Apr 2021, satya priya wrote: > > > > > > > > > Convert pm8xxx bindings from .txt to .yaml format. Also, > > > > > split this binding into two: parent binding(qcom-pm8xxx.yaml) > > > > > and child node RTC binding(qcom-pm8xxx-rtc.yaml). > > > > > > > > > > Signed-off-by: satya priya <skakit@codeaurora.org> > > > > > --- > > > > > Changes in V2: > > > > > - As per Bjorn's comments, I've split this into two, one parent binding > > > > > and one child node rtc binding. > > > > > - Fixed bot errors and changed maintainer name. > > > > > > > > > > .../devicetree/bindings/mfd/qcom-pm8xxx.txt | 100 --------------------- > > > > > .../devicetree/bindings/mfd/qcom-pm8xxx.yaml | 54 +++++++++++ > > > > > 2 files changed, 54 insertions(+), 100 deletions(-) > > > > > delete mode 100644 Documentation/devicetree/bindings/mfd/qcom-pm8xxx.txt > > > > > create mode 100644 Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml > > > > > > > > Applied, thanks. > > > > > > You need to apply the rtc schema too. linux-next has an error on this one now. > > > > > > > I'm going to apply it later tonight > > I've said this before, but MFD bindings with more than one schema file > like this one need to go thru one tree or things break temporarily (as > now Linus' tree is broken). > Noted, I'll be more careful next time. > Rob
diff --git a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.txt b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.txt deleted file mode 100644 index 07f4925..0000000 --- a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.txt +++ /dev/null @@ -1,100 +0,0 @@ -Qualcomm PM8xxx PMIC multi-function devices - -The PM8xxx family of Power Management ICs are used to provide regulated -voltages and other various functionality to Qualcomm SoCs. - -= PROPERTIES - -- compatible: - Usage: required - Value type: <string> - Definition: must be one of: - "qcom,pm8058" - "qcom,pm8821" - "qcom,pm8921" - -- #address-cells: - Usage: required - Value type: <u32> - Definition: must be 1 - -- #size-cells: - Usage: required - Value type: <u32> - Definition: must be 0 - -- interrupts: - Usage: required - Value type: <prop-encoded-array> - Definition: specifies the interrupt that indicates a subdevice - has generated an interrupt (summary interrupt). The - format of the specifier is defined by the binding document - describing the node's interrupt parent. - -- #interrupt-cells: - Usage: required - Value type : <u32> - Definition: must be 2. Specifies the number of cells needed to encode - an interrupt source. The 1st cell contains the interrupt - number. The 2nd cell is the trigger type and level flags - encoded as follows: - - 1 = low-to-high edge triggered - 2 = high-to-low edge triggered - 4 = active high level-sensitive - 8 = active low level-sensitive - -- interrupt-controller: - Usage: required - Value type: <empty> - Definition: identifies this node as an interrupt controller - -= SUBCOMPONENTS - -The PMIC contains multiple independent functions, each described in a subnode. -The below bindings specify the set of valid subnodes. - -== Real-Time Clock - -- compatible: - Usage: required - Value type: <string> - Definition: must be one of: - "qcom,pm8058-rtc" - "qcom,pm8921-rtc" - "qcom,pm8941-rtc" - "qcom,pm8018-rtc" - "qcom,pmk8350-rtc" - -- reg: - Usage: required - Value type: <prop-encoded-array> - Definition: single entry specifying the base address of the RTC registers - -- interrupts: - Usage: required - Value type: <prop-encoded-array> - Definition: single entry specifying the RTC's alarm interrupt - -- allow-set-time: - Usage: optional - Value type: <empty> - Definition: indicates that the setting of RTC time is allowed by - the host CPU - -= EXAMPLE - - pmicintc: pmic@0 { - compatible = "qcom,pm8921"; - interrupts = <104 8>; - #interrupt-cells = <2>; - interrupt-controller; - #address-cells = <1>; - #size-cells = <0>; - - rtc@11d { - compatible = "qcom,pm8921-rtc"; - reg = <0x11d>; - interrupts = <0x27 0>; - }; - }; diff --git a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml new file mode 100644 index 0000000..9065ec5 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml @@ -0,0 +1,54 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/qcom-pm8xxx.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm PM8xxx PMIC multi-function devices + +maintainers: + - Satya Priya <skakit@codeaurora.org> + +description: | + The PM8xxx family of Power Management ICs are used to provide regulated + voltages and other various functionality to Qualcomm SoCs. + +properties: + compatible: + enum: + - qcom,pm8058 + - qcom,pm8821 + - qcom,pm8921 + + reg: + maxItems: 1 + + '#address-cells': + const: 1 + + '#size-cells': + const: 0 + + interrupts: + maxItems: 1 + + '#interrupt-cells': + const: 2 + + interrupt-controller: true + +patternProperties: + "rtc@[0-9a-f]+$": + type: object + $ref: "../rtc/qcom-pm8xxx-rtc.yaml" + +required: + - compatible + - '#address-cells' + - '#size-cells' + - interrupts + - '#interrupt-cells' + - interrupt-controller + +additionalProperties: false +...
Convert pm8xxx bindings from .txt to .yaml format. Also, split this binding into two: parent binding(qcom-pm8xxx.yaml) and child node RTC binding(qcom-pm8xxx-rtc.yaml). Signed-off-by: satya priya <skakit@codeaurora.org> --- Changes in V2: - As per Bjorn's comments, I've split this into two, one parent binding and one child node rtc binding. - Fixed bot errors and changed maintainer name. .../devicetree/bindings/mfd/qcom-pm8xxx.txt | 100 --------------------- .../devicetree/bindings/mfd/qcom-pm8xxx.yaml | 54 +++++++++++ 2 files changed, 54 insertions(+), 100 deletions(-) delete mode 100644 Documentation/devicetree/bindings/mfd/qcom-pm8xxx.txt create mode 100644 Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml