diff mbox series

[Outreachy,kernel,1/2] staging: media: omap4iss: Align line break to the open parenthesis in file iss.c

Message ID aed4449f7f054eee329a808527c2a08d79076c78.1617994571.git.alinesantanacordeiro@gmail.com
State New
Headers show
Series [Outreachy,kernel,1/2] staging: media: omap4iss: Align line break to the open parenthesis in file iss.c | expand

Commit Message

Aline Santana Cordeiro April 9, 2021, 7:01 p.m. UTC
Aligns line break with the remaining function arguments
to the open parenthesis. Issue found by checkpatch.

Signed-off-by: Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>
---
 drivers/staging/media/omap4iss/iss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Hans Verkuil April 13, 2021, 2:32 p.m. UTC | #1
On 09/04/2021 21:01, Aline Santana Cordeiro wrote:
> Aligns line break with the remaining function arguments

> to the open parenthesis. Issue found by checkpatch.

> 

> Signed-off-by: Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>


Obsolete, a similar patch from Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com>
has already been applied in the media subsystem tree.

Regards,

	Hans

> ---

>  drivers/staging/media/omap4iss/iss.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c

> index dae9073..c89f268a 100644

> --- a/drivers/staging/media/omap4iss/iss.c

> +++ b/drivers/staging/media/omap4iss/iss.c

> @@ -960,7 +960,7 @@ iss_register_subdev_group(struct iss_device *iss,

>  		}

>  

>  		subdev = v4l2_i2c_new_subdev_board(&iss->v4l2_dev, adapter,

> -				board_info->board_info, NULL);

> +						   board_info->board_info, NULL);

>  		if (!subdev) {

>  			dev_err(iss->dev, "Unable to register subdev %s\n",

>  				board_info->board_info->type);

>
Aline Santana Cordeiro April 13, 2021, 6:16 p.m. UTC | #2
Em ter, 2021-04-13 às 16:32 +0200, Hans Verkuil escreveu:
> On 09/04/2021 21:01, Aline Santana Cordeiro wrote:

> > Aligns line break with the remaining function arguments

> > to the open parenthesis. Issue found by checkpatch.

> > 

> > Signed-off-by: Aline Santana Cordeiro <  

> > alinesantanacordeiro@gmail.com>

> 

> Obsolete, a similar patch from Beatriz Martins de Carvalho <  

> martinsdecarvalhobeatriz@gmail.com>

> has already been applied in the media subsystem tree.

> 

> Regards,

> 

>         Hans

> 


Okay, thank you for letting me know.

Aline

> > ---

> >  drivers/staging/media/omap4iss/iss.c | 2 +-

> >  1 file changed, 1 insertion(+), 1 deletion(-)

> > 

> > diff --git a/drivers/staging/media/omap4iss/iss.c

> > b/drivers/staging/media/omap4iss/iss.c

> > index dae9073..c89f268a 100644

> > --- a/drivers/staging/media/omap4iss/iss.c

> > +++ b/drivers/staging/media/omap4iss/iss.c

> > @@ -960,7 +960,7 @@ iss_register_subdev_group(struct iss_device

> > *iss,

> >                 }

> >  

> >                 subdev = v4l2_i2c_new_subdev_board(&iss->v4l2_dev,

> > adapter,

> > -                               board_info->board_info, NULL);

> > +                                                  board_info-

> > >board_info, NULL);

> >                 if (!subdev) {

> >                         dev_err(iss->dev, "Unable to register

> > subdev %s\n",

> >                                 board_info->board_info->type);

> > 

>
diff mbox series

Patch

diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
index dae9073..c89f268a 100644
--- a/drivers/staging/media/omap4iss/iss.c
+++ b/drivers/staging/media/omap4iss/iss.c
@@ -960,7 +960,7 @@  iss_register_subdev_group(struct iss_device *iss,
 		}
 
 		subdev = v4l2_i2c_new_subdev_board(&iss->v4l2_dev, adapter,
-				board_info->board_info, NULL);
+						   board_info->board_info, NULL);
 		if (!subdev) {
 			dev_err(iss->dev, "Unable to register subdev %s\n",
 				board_info->board_info->type);