| Message ID | 01ad7ff353f805dfc48e7bcc26ed974e7bb5ef9f.1618326535.git.mitaliborkar810@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | staging: media: intel-ipu3: Cleanup patchset for style issues | expand |
On Wed, 14 Apr 2021, Mitali Borkar wrote: > On Tue, Apr 13, 2021 at 09:17:12PM +0300, Dan Carpenter wrote: > > On Tue, Apr 13, 2021 at 08:59:34PM +0530, Mitali Borkar wrote: > > > Removed unnecessary space before tabs to adhere to linux kernel coding > > > style. > > > Reported by checkpatch. > > > > > > Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com> > > > --- > > > > > > Changes from v2:- No changes. > > > Changes from v1:- No changes. > > > > > > drivers/staging/media/ipu3/include/intel-ipu3.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/staging/media/ipu3/include/intel-ipu3.h b/drivers/staging/media/ipu3/include/intel-ipu3.h > > > index 47e98979683c..42edac5ee4e4 100644 > > > --- a/drivers/staging/media/ipu3/include/intel-ipu3.h > > > +++ b/drivers/staging/media/ipu3/include/intel-ipu3.h > > > @@ -633,7 +633,7 @@ struct ipu3_uapi_bnr_static_config_wb_gains_thr_config { > > > * @cg: Gain coefficient for threshold calculation, [0, 31], default 8. > > > * @ci: Intensity coefficient for threshold calculation. range [0, 0x1f] > > > * default 6. > > > - * format: u3.2 (3 most significant bits represent whole number, > > > + *format: u3.2 (3 most significant bits represent whole number, > > > * 2 least significant bits represent the fractional part > > > > Just remove the spaces, don't remove the tab. It's looks silly now. > > > Okay Sir, do I have to send a v4 patch on this now? Yes. If you get feedback on a patch, you should send a new version. julia > > > regards, > > dan carpenter > > > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/YHX3iVCNXJlOsmuQ%40kali. >
On Wed, Apr 14, 2021 at 12:05:04AM +0200, Julia Lawall wrote: > > > On Wed, 14 Apr 2021, Mitali Borkar wrote: > > > On Tue, Apr 13, 2021 at 09:17:12PM +0300, Dan Carpenter wrote: > > > On Tue, Apr 13, 2021 at 08:59:34PM +0530, Mitali Borkar wrote: > > > > Removed unnecessary space before tabs to adhere to linux kernel coding > > > > style. > > > > Reported by checkpatch. > > > > > > > > Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com> > > > > --- > > > > > > > > Changes from v2:- No changes. > > > > Changes from v1:- No changes. > > > > > > > > drivers/staging/media/ipu3/include/intel-ipu3.h | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/staging/media/ipu3/include/intel-ipu3.h b/drivers/staging/media/ipu3/include/intel-ipu3.h > > > > index 47e98979683c..42edac5ee4e4 100644 > > > > --- a/drivers/staging/media/ipu3/include/intel-ipu3.h > > > > +++ b/drivers/staging/media/ipu3/include/intel-ipu3.h > > > > @@ -633,7 +633,7 @@ struct ipu3_uapi_bnr_static_config_wb_gains_thr_config { > > > > * @cg: Gain coefficient for threshold calculation, [0, 31], default 8. > > > > * @ci: Intensity coefficient for threshold calculation. range [0, 0x1f] > > > > * default 6. > > > > - * format: u3.2 (3 most significant bits represent whole number, > > > > + *format: u3.2 (3 most significant bits represent whole number, > > > > * 2 least significant bits represent the fractional part > > > > > > Just remove the spaces, don't remove the tab. It's looks silly now. > > > > > Okay Sir, do I have to send a v4 patch on this now? > > Yes. If you get feedback on a patch, you should send a new version. v2 of this patch can be used as well, it's fine. (I missed this change in v3.) -- Sakari Ailus
diff --git a/drivers/staging/media/ipu3/include/intel-ipu3.h b/drivers/staging/media/ipu3/include/intel-ipu3.h index 47e98979683c..42edac5ee4e4 100644 --- a/drivers/staging/media/ipu3/include/intel-ipu3.h +++ b/drivers/staging/media/ipu3/include/intel-ipu3.h @@ -633,7 +633,7 @@ struct ipu3_uapi_bnr_static_config_wb_gains_thr_config { * @cg: Gain coefficient for threshold calculation, [0, 31], default 8. * @ci: Intensity coefficient for threshold calculation. range [0, 0x1f] * default 6. - * format: u3.2 (3 most significant bits represent whole number, + *format: u3.2 (3 most significant bits represent whole number, * 2 least significant bits represent the fractional part * with each count representing 0.25) * e.g. 6 in binary format is 00110, that translates to 1.5
Removed unnecessary space before tabs to adhere to linux kernel coding style. Reported by checkpatch. Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com> --- Changes from v2:- No changes. Changes from v1:- No changes. drivers/staging/media/ipu3/include/intel-ipu3.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)